Sun, 05 Apr 2026 01:15:16 +0000 https://bugs.horde.org/ticket/10366 Agora fixes and refactoring for H4 First batch of Agora fixes and refactoring for H4. Main changes: * Added driver factory and converted Agora to use it. * Added database migration scripts. * Switched Agora from MDB2 to Horde_Db. * Renamed Agora_Messages to Agora_Driver to better match other applications. I have also marked various bugs in TODO comments which I have found during testing. They exist in old version too. As soon as this is commited I can start fixing those and cleaning the code (oh yes it is a mess :)). Thu, 21 Jul 2011 20:04:38 +0000 https://bugs.horde.org/ticket/10366#t66476 Why are the migration steps 2-4 separate from 1? And there is a column name typo in the down migration in step 2. Sun, 24 Jul 2011 16:42:14 +0000 https://bugs.horde.org/ticket/10366#t66518 Well, the scripts were separate in old version. So I just kept the same structure. Also, maybe someone would have CVS version in between year 2007 and year 2008 of Agora installed. So it would be a lot easier for them to upgrade. Or do you mean that all sql/upgrade scripts for unreleased applications when moved to H4 can be combined into one migration script? If yes, how step 5 is different from 1-4? Sun, 24 Jul 2011 16:57:48 +0000 https://bugs.horde.org/ticket/10366#t66525 By the way, I have noticed that some upgrade .sql scripts were not moved from CVS to git. Was it intentional? Sun, 24 Jul 2011 16:59:20 +0000 https://bugs.horde.org/ticket/10366#t66527 > Well, the scripts were separate in old version. So I just kept the > same structure. Also, maybe someone would have CVS version in between > year 2007 and year 2008 of Agora installed. So it would be a lot > easier for them to upgrade. Or do you mean that all sql/upgrade > scripts for unreleased applications when moved to H4 can be combined > into one migration script? If yes, how step 5 is different from 1-4? You can safely assume that anyone migration from CVS has all SQL scripts that exist in CVS applied already. Anything else would be overcomplicating things. Sat, 30 Jul 2011 12:01:48 +0000 https://bugs.horde.org/ticket/10366#t66655 > By the way, I have noticed that some upgrade .sql scripts were not > moved from CVS to git. Was it intentional? No idea. Honestly, I've given up on Agora long ago. :) Sat, 30 Jul 2011 12:02:23 +0000 https://bugs.horde.org/ticket/10366#t66656 Here you go. A modified patch with migration scripts in two steps. Hopefully I have mastered git rebase/amend/continue right. As for Agora, yes, it's ugly in some ways, but does intranet messaging just right :) Thu, 04 Aug 2011 08:04:52 +0000 https://bugs.horde.org/ticket/10366#t66779 Thanks. Thu, 04 Aug 2011 08:41:10 +0000 https://bugs.horde.org/ticket/10366#t66785