[#5912] set start and stop times for maildrop vacation recipes
Summary set start and stop times for maildrop vacation recipes
Queue Ingo
Queue Version HEAD
Type Enhancement
State No Feedback
Priority 1. Low
Owners
Requester steinkel@ctinetworks.com
Created 2007-11-21 (4609 days ago)
Due
Updated 2008-04-16 (4462 days ago)
Assigned
Resolved 2008-04-16 (4462 days ago)
Milestone
Patch No

Comments
steinkel@ctinetworks.com 2007-11-21 16:41:27
This has been lightly tested.

steinkel@ctinetworks.com 2007-11-21 17:40:41
> This has been lightly tested.

Heavier testing led to the addition to an else clause at the end, so 
the generated reply is not delivered to the local mailbox



=== add after line 518 ===

             $this->_action[] = '  else';

             $this->_action[] = '  {';

             $this->_action[] = '    to "/dev/null";';

             $this->_action[] = '  }';

steinkel@ctinetworks.com 2007-11-21 18:36:06
Here is the latest diff against CVS HEAD, including 'ignorelist' checking.



In the future, I will do more testing before posting.

steinkel@ctinetworks.com 2007-11-21 19:44:25
please move the "current_time=time" line before the vacation start/end 
time checks

steinkel@ctinetworks.com 2007-11-21 20:02:19
After you have rendered judgement on these, I have suggestions for 
handling exclusions as well

Jan Schneider <jan@horde.org> 2007-11-21 23:39:21
> please move the "current_time=time" line before the vacation

> start/end time checks

Please provide an updated patch.

steinkel@ctinetworks.com 2007-11-26 15:36:23
Here is the latest diff, including start and end times, 
list/bulk/junk/admin mail ignoring, and excluded addresses.  I 
simplified the admin mail regexp for debugging purposes.

Jan Schneider <jan@horde.org> 2007-12-03 17:52:22
What does the extra trimming of the email addresses do and why?

What's about the currently outcommented ignorelist stuff a few lines 
above? Can this go now?

steinkel@ctinetworks.com 2007-12-03 18:38:52
> What does the extra trimming of the email addresses do and why?



The extra trims in the foreach loop are from paranoia about too many 
exploits using embedded control characters in mail headers.



> What's about the currently outcommented ignorelist stuff a few lines

> above? Can this go now?



I redid the ignorelist regex to simplify it for debugging my code.  It 
can certainly be bulked-up, but I think the original ignorelist is not 
workable in its current form.  I am using it now as it sits.

Jan Schneider <jan@horde.org> 2007-12-07 14:52:30
>> What does the extra trimming of the email addresses do and why?

>

> The extra trims in the foreach loop are from paranoia about too many

> exploits using embedded control characters in mail headers.



Shouldn't this rather be done through addcslashes() like anywhere else 
in the maildrop driver?



>> What's about the currently outcommented ignorelist stuff a few lines

>> above? Can this go now?

>

> I redid the ignorelist regex to simplify it for debugging my code.

> It can certainly be bulked-up, but I think the original ignorelist is

> not workable in its current form.  I am using it now as it sits.



I consider this as a "yes."

Jan Schneider <jan@horde.org> 2008-02-24 12:34:57
Ping?