[#14196] Kolab driver: Nag's view tabs (All tasks, Incomplete tasks, Future tasks, Completed tasks) not rendered correctly
Summary Kolab driver: Nag's view tabs (All tasks, Incomplete tasks, Future tasks, Completed tasks) not rendered correctly
Queue Kolab
Type Bug
State Resolved
Priority 1. Low
Owners mrubinsk@horde.org
Requester mike.gabriel@das-netzwerkteam.de
Created 2015-12-15 (2006 days ago)
Due
Updated 2015-12-29 (1992 days ago)
Assigned 2015-12-17 (2004 days ago)
Resolved 2015-12-29 (1992 days ago)
Milestone
Patch Yes

Comments
mike.gabriel@das-netzwerkteam.de 2015-12-15 19:18:52
I use Nag_Driver_Kolab as storage backend for tasks.

  Without the attached patch, Nag is not able to retrieve tasklists 
based on the completion flag (or other flags).

The different tasklist tabs (when using the Kolab driver) always show 
_all_ tasks, although they should show what the tab title says, e.g.   
"All tasks", "Incomplete tasks", "Future tasks", "Completed tasks".

This patch fixes the issue. The issue is caused through nested loops 
(foreach, switch) and wrong usage of the continue statement.

See here for details:
http://php.net/manual/en/control-structures.continue.php#96945



Michael Rubinsky <mrubinsk@horde.org> 2015-12-16 23:18:24
Moving to Kolab queue.

Michael Rubinsky <mrubinsk@horde.org> 2015-12-17 15:42:32
I believe something like this was resolved in Git previously, but need 
to verify.

Git Commit <commits@lists.horde.org> 2015-12-29 04:40:48
Changes have been made in Git (FRAMEWORK_5_2):

commit 1197a222a96fe7e3c193dfc5031f2cefe20a314f
Author: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Date:   Mon Dec 28 23:39:27 2015 -0500

     Bug: 14196 Fix displaying tab filters in Kolab driver.

     Signed-off-by: Michael J Rubinsky <mrubinsk@horde.org>

  nag/lib/Driver/Kolab.php |   12 ++++++------
  1 files changed, 6 insertions(+), 6 deletions(-)

http://github.com/horde/horde/commit/1197a222a96fe7e3c193dfc5031f2cefe20a314f

Git Commit <commits@lists.horde.org> 2015-12-29 04:43:40
Changes have been made in Git (master):

commit c02522fed6f33e1e306d5c5b4a8c1136989af87d
Author: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Date:   Mon Dec 28 23:39:27 2015 -0500

     Bug: 14196 Fix displaying tab filters in Kolab driver.

     Signed-off-by: Michael J Rubinsky <mrubinsk@horde.org>

  nag/lib/Driver/Kolab.php |   12 ++++++------
  1 files changed, 6 insertions(+), 6 deletions(-)

http://github.com/horde/horde/commit/c02522fed6f33e1e306d5c5b4a8c1136989af87d

Michael Rubinsky <mrubinsk@horde.org> 2015-12-29 04:44:07
Committed, thanks!