[#13836] Nag Block Task Summery does not check show perm
Summary Nag Block Task Summery does not check show perm
Queue Nag
Queue Version 4.2.3
Type Enhancement
State Feedback
Priority 1. Low
Owners
Requester michael.menge@zdv.uni-tuebingen.de
Created 2015-02-02 (1886 days ago)
Due
Updated 2016-01-27 (1527 days ago)
Assigned 2015-02-06 (1882 days ago)
Resolved
Milestone
Patch No

Comments
michael.menge@zdv.uni-tuebingen.de 2015-02-02 10:24:26
Nag does show task from task list in the summery portal block, for 
task lists where I have
list perms (via creator perm_creator_4 = true) but no show perm.

In Nag these task and tasklist are not shown

michael.menge@zdv.uni-tuebingen.de 2015-02-02 10:29:14
> Nag does show task from task list in the summery portal block, for 
> task lists where I have
> list perms (via creator perm_creator_4 = true) but no show perm.

s/list perms/read perms/

>
> In Nag these task and tasklist are not shown




Jan Schneider <jan@horde.org> 2015-02-06 20:24:44
This may be inconsistent but is inherently correct.

In the portal block you have the option to show tasks from *all* 
lists, which includes lists with read but without show permissions. In 
the regular interface there is no such *all* option, you pick the 
displayed lists individually. And since non-show lists are not 
displayed, you cannot select them, even if you had read permissions.

michael.menge@zdv.uni-tuebingen.de 2015-02-12 08:39:55
> This may be inconsistent but is inherently correct.
>

Maybe I don't understand the permissions system #4021, but ...

> In the portal block you have the option to show tasks from *all* 
> lists, which includes lists with read but without show permissions. 
> In the regular interface there is no such *all* option, you pick the 
> displayed lists individually. And since non-show lists are not 
> displayed, you cannot select them, even if you had read permissions.

... at no other place that I have found that you can select from *all*  lists.
I can see and read task that I did not create, from a task list that I 
can't select/deselct
in the the nag block configuration and I don't have access to that 
task list at any other place.
You can access task from task lists you can't see in nag, or the block 
configuration otherwise.

So this is supprising from the users (the user that sees the task from 
an unkonwn other person
and the person owning the task list, that *all* other users see the 
taks) point of view.

This is changed between horde 3.3. and nag 2.3 and horde 5.2 and nag 4.2.



Jan Schneider <jan@horde.org> 2016-01-26 07:57:15
Maybe we should remove the *all lists* option from the block settings.

michael.menge@zdv.uni-tuebingen.de 2016-01-26 14:08:52
Regarding the status feedback: Do you need my feedback or the feedback 
of other developers?

what do you mean by "remove the *all lists* option"? At the moment 
this Option is the default
as no task list is selected by default.

IHMO I would use all lists that the users  show perm for, if no list 
is selected.
This would be the same as if the user had selected all lists he can select at
that moment, but would autocratically include new lists/ list with new 
show perms.


Michael Rubinsky <mrubinsk@horde.org> 2016-01-26 15:42:22
> Maybe we should remove the *all lists* option from the block settings.

What if we only show the user the tasks from non-show lists that 
he/she is the assignee on?

michael.menge@zdv.uni-tuebingen.de 2016-01-27 08:55:45
>> Maybe we should remove the *all lists* option from the block settings.
>
> What if we only show the user the tasks from non-show lists that 
> he/she is the assignee on?

Could work, but what happens if the show perm is removed? Can he/she 
still unassignee?


Jan Schneider <jan@horde.org> 2016-01-27 10:16:11
> Regarding the status feedback: Do you need my feedback or the 
> feedback of other developers?

Both.

> what do you mean by "remove the *all lists* option"? At the moment 
> this Option is the default
> as no task list is selected by default.

Exactly, but we could default it to display no task list, unless 
explicitly selected.

> IHMO I would use all lists that the users  show perm for, if no list 
> is selected.
> This would be the same as if the user had selected all lists he can select at
> that moment, but would autocratically include new lists/ list with 
> new show perms.

Re-thinking this over and comparing it with Kronolith, this may indeed 
be the most consistent behavior. It even explicitly reads there: "All 
Visible" as an option which is pretty unambiguous.

Jan Schneider <jan@horde.org> 2016-01-27 10:18:03
>> Maybe we should remove the *all lists* option from the block settings.
>
> What if we only show the user the tasks from non-show lists that 
> he/she is the assignee on?

I think this over-complicates things for a block that should just 
provide a summary.

Once we have extended some the usage of assignees in Nag, it would 
make sense to add a separate block to only show assigned tasks.