[#12680] adding Organizer as attendee needs own fb-url in address book
Summary adding Organizer as attendee needs own fb-url in address book
Queue Kronolith
Queue Version Git master
Type Enhancement
State Assigned
Priority 1. Low
Owners jan@horde.org
Requester thpo+horde@dotrc.de
Created 2013-09-13 (2522 days ago)
Due
Updated 2016-01-28 (1655 days ago)
Assigned 2016-01-28 (1655 days ago)
Resolved
Milestone 5.0.0
Patch No

Comments
thpo+horde@dotrc.de 2013-09-13 09:46:29
When one schedules an event in kronolith and adds attendees, a 
free/busy column is added for the
organizer as well.
But this infomation is retrieved by searching the address-book for an 
entry with email = Kronolith.conf.email, that has a correct fb-URL set.
The attached patch skips this search and sets the correkt fb-URL for 
the organizer directly.

thpo+horde@dotrc.de 2013-09-13 09:53:31
Sorry, I attached the wrong patch: strcmp should check "=== 0" instead 
of "!== 0"

Michael Rubinsky <mrubinsk@horde.org> 2013-09-13 20:03:49
This patch assumes that the user wants to use his/her Kronolith 
calendar as the canonical source for FB information. Most likely, yes, 
but we never enforced that restriction before.

thpo+horde@dotrc.de 2013-09-15 10:32:31
So how about this patch? It first checks for a given FB-URL of the 
owner, and only
if there was none, it sets the default.

thpo+horde@dotrc.de 2013-09-15 10:35:00
> So how about this patch? It first checks for a given FB-URL of the 
> owner, and only
> if there was none, it sets the default.

Sorry, wrong patch again. :-(

Michael Rubinsky <mrubinsk@horde.org> 2013-09-15 14:08:06
The idea seems sound to me, but you should refactor that so that you 
only query the identity system if we know we need it. I.e., Check $url 
first, and then get identity and do the comparisons etc...

Jan Schneider <jan@horde.org> 2013-09-16 08:48:28
This approach is completely wrong.

Instead of querying the FB URL for the current user internally, the FB 
information can (and has to) be generated directly, on the fly. See 
attendees.php on how this works in the basic view.