[#12308] Parent task should not be completed while child tasks are open
Summary Parent task should not be completed while child tasks are open
Queue Nag
Queue Version Git master
Type Bug
State Resolved
Priority 1. Low
Owners mrubinsk@horde.org
Requester x.van_dessel@ieee.org
Created 2013-06-05 (2383 days ago)
Due
Updated 2017-10-20 (785 days ago)
Assigned 2015-07-20 (1608 days ago)
Resolved 2016-01-30 (1414 days ago)
Milestone
Patch No

Comments
x.van_dessel@ieee.org 2013-06-05 16:37:21
When a task has subtasks, it makes no sense the parent task can be set 
to completed while there are still subtasks that are not. This 
behaviour is correctly implemented at the level of the task list: the 
parent task checkbox cannot be clicked, only the child task(s) can be. 
However, when one opens the details of the parent task, there the 
checkbox to set the task completed can be actioned. This should be 
greyed out to be consistent.


x.van_dessel@ieee.org 2015-10-13 13:45:31
The same problem occurs when both parent and child are completed. From 
the All tasks list, you cannot reopen de child task as the parent is 
set to completed. However, by opening the child task now in edit mode, 
and then remove the completion flag, the child can be reactivated 
whilst the parent is still completed.


Jan Schneider <jan@horde.org> 2016-01-22 11:39:25
See also ticket #13737

Git Commit <commits@lists.horde.org> 2016-01-30 17:56:04
Changes have been made in Git (master):

commit 7ce2561c4b272916d66d0b1298699388730aed34
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Sat Jan 30 12:12:00 2016 -0500

     Enforce completing subtasks before parent task.

     Bug: 12308

  nag/app/controllers/SaveTask.php |    7 ++++++-
  nag/lib/Api.php                  |   10 ++++++++--
  nag/lib/Task.php                 |    9 ++++++++-
  3 files changed, 22 insertions(+), 4 deletions(-)

http://github.com/horde/horde/commit/7ce2561c4b272916d66d0b1298699388730aed34

Git Commit <commits@lists.horde.org> 2016-01-30 17:56:10
Changes have been made in Git (master):

commit 0ea8beeb79100c26d254b0beac64cac3d17485c1
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Sat Jan 30 12:52:59 2016 -0500

     Disable completed checkbox in UI when appropriate.

     Bug: 12308

  nag/lib/Form/Task.php |   17 +++++++++++++++--
  nag/task.php          |    4 ++++
  2 files changed, 19 insertions(+), 2 deletions(-)

http://github.com/horde/horde/commit/0ea8beeb79100c26d254b0beac64cac3d17485c1

Git Commit <commits@lists.horde.org> 2016-01-30 18:09:57
Changes have been made in Git (master):

commit 4427ada4bed8eccde686a7ecdd4cdcbedc9ddc5a
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Sat Jan 30 13:09:01 2016 -0500

     Mark parent tasks as incomplete when marking child task incomplete.

     Bug: 12308

  nag/lib/Task.php |   18 ++++++++++++------
  1 files changed, 12 insertions(+), 6 deletions(-)

http://github.com/horde/horde/commit/4427ada4bed8eccde686a7ecdd4cdcbedc9ddc5a

Git Commit <commits@lists.horde.org> 2016-01-30 18:19:24
Changes have been made in Git (FRAMEWORK_5_2):

commit a63937953a704ada801c9c26c090cd3ccfdbb35c
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Sat Jan 30 12:12:00 2016 -0500

     Enforce completing subtasks before parent task.

     Bug: 12308

  nag/app/controllers/SaveTask.php |    7 ++++++-
  nag/lib/Api.php                  |   10 ++++++++--
  nag/lib/Task.php                 |    9 ++++++++-
  3 files changed, 22 insertions(+), 4 deletions(-)

http://github.com/horde/horde/commit/a63937953a704ada801c9c26c090cd3ccfdbb35c

Git Commit <commits@lists.horde.org> 2016-01-30 18:19:28
Changes have been made in Git (FRAMEWORK_5_2):

commit f35024b7f55c2bd1afe21236221f8009972560b9
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Sat Jan 30 12:52:59 2016 -0500

     Disable completed checkbox in UI when appropriate.

     Bug: 12308

  nag/lib/Form/Task.php |   17 +++++++++++++++--
  nag/task.php          |    4 ++++
  2 files changed, 19 insertions(+), 2 deletions(-)

http://github.com/horde/horde/commit/f35024b7f55c2bd1afe21236221f8009972560b9

Git Commit <commits@lists.horde.org> 2016-01-30 18:19:33
Changes have been made in Git (FRAMEWORK_5_2):

commit 74f599eb87538a067a43ee00ba51607d3e3a0c06
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Sat Jan 30 13:09:01 2016 -0500

     Mark parent tasks as incomplete when marking child task incomplete.

     Bug: 12308

  nag/lib/Task.php |   18 ++++++++++++------
  1 files changed, 12 insertions(+), 6 deletions(-)

http://github.com/horde/horde/commit/74f599eb87538a067a43ee00ba51607d3e3a0c06

Git Commit <commits@lists.horde.org> 2017-10-20 20:33:53
Changes have been made in Git (FRAMEWORK_5_2):

commit 442363d3abd664c06dd9a8e7be36bb14af636c54
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Sat, 30 Jan 2016 13:16:00 -0500

Enforce completing subtasks before parent task.

Bug: 12308

  M app/controllers/SaveTask.php
  M lib/Api.php
  M lib/Task.php

https://github.com/horde/nag/commit/442363d3abd664c06dd9a8e7be36bb14af636c54

Git Commit <commits@lists.horde.org> 2017-10-20 20:33:53
Changes have been made in Git (FRAMEWORK_5_2):

commit d4cf79611dd74298a934a0c0c8cae6f2cba273ee
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Sat, 30 Jan 2016 13:17:13 -0500

Disable completed checkbox in UI when appropriate.

Bug: 12308

  M lib/Form/Task.php
  M task.php

https://github.com/horde/nag/commit/d4cf79611dd74298a934a0c0c8cae6f2cba273ee

Git Commit <commits@lists.horde.org> 2017-10-20 20:33:54
Changes have been made in Git (FRAMEWORK_5_2):

commit 0e37f2ae863d9e721f457a6700179df8bcf386fa
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Sat, 30 Jan 2016 13:17:43 -0500

Mark parent tasks as incomplete when marking child task incomplete.

Bug: 12308

  M lib/Task.php

https://github.com/horde/nag/commit/0e37f2ae863d9e721f457a6700179df8bcf386fa