[#11738] Revamped kolab-webmail bundle for H5
Summary Revamped kolab-webmail bundle for H5
Queue Kolab
Type Enhancement
State Feedback
Priority 2. Medium
Owners
Requester jmozdzen@nde.ag
Created 2012-11-21 (2433 days ago)
Due
Updated 2017-03-12 (861 days ago)
Assigned
Resolved
Milestone
Patch No

Comments
jmozdzen@nde.ag 2012-11-21 14:55:07
bundle/kolab-webmail needed some work-over to cope with H5.

An open issue remains: How do I (in Bundle.php) read in a password 
without console echo? It can be done, ConfigDb() does it somehow...

This patch, together with the one from bug #11737, give me a mostly 
usable system with working Kolab integration.

Jan Schneider <jan@horde.org> 2012-11-28 12:02:24
> bundle/kolab-webmail needed some work-over to cope with H5.
>
> An open issue remains: How do I (in Bundle.php) read in a password 
> without console echo? It can be done, ConfigDb() does it somehow...

http://dev.horde.org/api/master/lib/Cli/classes/Horde_Cli.html#method_passwordPrompt

> This patch, together with the one from bug #11737, give me a mostly 
> usable system with working Kolab integration.

Looks mostly good.
- Why does 
$GLOBALS['injector']->getInstance('Horde_Kolab_Session')->getImapServer() not 
work?
- Why did you remove the mbox_icon and display_folder hooks?
- Use can use $kolabhost as the default value for the $smtphost and 
$ldaphost prompts.
- Why are the $vars->ldap__* setters necessary?

jmozdzen@nde.ag 2012-11-28 12:47:01
>> bundle/kolab-webmail needed some work-over to cope with H5.
>>
>> An open issue remains: How do I (in Bundle.php) read in a password
>> without console echo? It can be done, ConfigDb() does it somehow...
>
> http://dev.horde.org/api/master/lib/Cli/classes/Horde_Cli.html#method_passwordPrompt

Thanks, I'll rework the code to include this.

>> This patch, together with the one from bug #11737, give me a mostly
>> usable system with working Kolab integration.
>
> Looks mostly good.
> - Why does 
> $GLOBALS['injector']->getInstance('Horde_Kolab_Session')->getImapServer() 
> not work?

You tell me... when I tested my configuration, access to the IMAP 
server only worked after I (originally hard-coded) the server value in 
that config file. This was way before I started changing real code or 
creating bugs, so it may be different with the current implementation 
(bug #11737).

> - Why did you remove the mbox_icon and display_folder hooks?

Because I got fatal PHP errors when the code tries to access
$types = 
$GLOBALS['injector']->getInstance('Horde_Kolab_Storage')->getList()->listFolderTypes();

IIRC it was "listFolderTypes()" that was reported as unknown as a 
member method.

> - Use can use $kolabhost as the default value for the $smtphost and 
> $ldaphost prompts.

Thanks to the above documentation link I can now implement this.

> - Why are the $vars->ldap__* setters necessary?

Those were the values I seem to have to set in consequence of the 
changes in bug #11737. Do you see a different way to handle this? My 
insight into Horde's handling of IMAP server settings is still very 
limited, and I rather suspect that setting "kolab__imap*" is now 
obsolete...

Jan Schneider <jan@horde.org> 2013-01-30 14:08:45
Ping?

jmozdzen@nde.ag 2013-01-30 14:21:50
> Ping?

oops, sorry, most of this was set "pending" (although already coded) 
due to the other H5 issues we encountered and reported.

An open topic to me is the "bundling" definition - I'll try to look 
that up today and provide an updated patch.

jmozdzen@nde.ag 2013-01-30 16:05:40
> An open topic to me is the "bundling" definition - I'll try to look 
> that up today and provide an updated patch.

I was referring to package.xml. I currently have no way to test this, 
the "status" fields are set to "stable" without knowing if that really 
is the proper value, and hopefully the file list actually reflects 
what's in the package. I've updated the versions of the listed 
required packages to those on my server without knowing if there are 
further required packages - this is far above my head.

The "docs" files could use some shaping up, too. But as probably 
nobody will ever actually look into these, that'd be a waste of time ;)

Jan Schneider <jan@horde.org> 2013-03-01 17:08:24
There's still a few of my questions unanswered/unresolved.

jmozdzen@nde.ag 2013-03-01 21:36:59
> There's still a few of my questions unanswered/unresolved.

Thanks for pointing this out - from my point of view I had already 
declared the basar closed ;)

> - Why does 
> $GLOBALS['injector']->getInstance('Horde_Kolab_Session')->getImapServer() 
> not work?
As I wrote, I couldn't tell. I just observed that it does work with an 
explicitly set server and doesn't via the injector statement. But upon 
re-reading this ticket, I noticed that now, due to some other change, 
a re-check is in order - yes, the injector statements currently work.
BTW, what advantage is it in IMP to read the hostname via injector, 
but read the port number from the config? I suggest you or anyone more 
Horde-experienced than me to look this over and create a probably more 
consistent usage of the pre-configured IMAP server.

Do you need a modified patch?

> - Why did you remove the mbox_icon and display_folder hooks?
Do you see this as unresolved? I have not received any response to my 
comments and was not able to resolve the issue myself.
I just retested, when activating the mbox_icon hook the folder list on 
the left no longer loads in IMP, but despite DEBUG logging I couldn't 
spot obvious error messages. It's sufficient to have the code in 
hooks.php, even when not activated in imp/conf.d.

> - Why are the $vars->ldap__* setters necessary?
Do you see this as unresolved? I have not received any response to my 
comments and concluded from my tests that those values needed to be 
set to make it work. Thus I had set them.

Please let me know what you see as open points where I can help.

Jan Schneider <jan@horde.org> 2013-03-07 10:26:27
>> There's still a few of my questions unanswered/unresolved.
>
> Thanks for pointing this out - from my point of view I had already 
> declared the basar closed ;)
>
>> - Why does 
>> $GLOBALS['injector']->getInstance('Horde_Kolab_Session')->getImapServer() 
>> not work?
> As I wrote, I couldn't tell. I just observed that it does work with 
> an explicitly set server and doesn't via the injector statement. But 
> upon re-reading this ticket, I noticed that now, due to some other 
> change, a re-check is in order - yes, the injector statements 
> currently work.

Great.

> BTW, what advantage is it in IMP to read the hostname via injector, 
> but read the port number from the config? I suggest you or anyone 
> more Horde-experienced than me to look this over and create a 
> probably more consistent usage of the pre-configured IMAP server.

AFAIU the IMAP server can be configured per user in Kolab's LDAP 
backend, the port can't.

> Do you need a modified patch?

Yes, please.

>> - Why did you remove the mbox_icon and display_folder hooks?
> Do you see this as unresolved? I have not received any response to 
> my comments and was not able to resolve the issue myself.
> I just retested, when activating the mbox_icon hook the folder list 
> on the left no longer loads in IMP, but despite DEBUG logging I 
> couldn't spot obvious error messages. It's sufficient to have the 
> code in hooks.php, even when not activated in imp/conf.d.

You mentioned fatal errors earlier in the ticket, but I didn't see a 
bug report or more detailed information about those anywhere. If they 
don't work, they need fixing, not disabling.

>> - Why are the $vars->ldap__* setters necessary?
> Do you see this as unresolved? I have not received any response to 
> my comments and concluded from my tests that those values needed to 
> be set to make it work. Thus I had set them.

AFAIU the Kolab code doesn't use the $conf['ldap'] configuration, or 
is it? If not, setting those here is not necessary.
Also, why do you change the default ports for IMAP and SMTP?

> Please let me know what you see as open points where I can help.

The 'kolab' address book is already defined in 
turba/config/backends.php. You only need to enable it in 
backends.d/20-kolab.php.

jmozdzen@nde.ag 2013-03-07 12:39:09
>>> - Why did you remove the mbox_icon and display_folder hooks?
>> Do you see this as unresolved? I have not received any response to my
>> comments and was not able to resolve the issue myself.
>> I just retested, when activating the mbox_icon hook the folder list
>> on the left no longer loads in IMP, but despite DEBUG logging I
>> couldn't spot obvious error messages. It's sufficient to have the
>> code in hooks.php, even when not activated in imp/conf.d.
>
> You mentioned fatal errors earlier in the ticket, but I didn't see a 
> bug report or more detailed information about those anywhere. If 
> they don't work, they need fixing, not disabling.

This ticket is about code specific to the kolab package, the code in 
question no longer works with the new version, I reported the problem 
and suggested a solution (code removal) - I didn't see the need for a 
separate ticket.

Lacking a response telling me differently, I assume that that the code 
is based on functionality no longer available in the current version 
of Horde. As nobody besides me seems to miss Kolab integration at all, 
removing eye candy shouldn't be a problem at all.

jmozdzen@nde.ag 2013-03-07 12:43:44
> The 'kolab' address book is already defined in 
> turba/config/backends.php. You only need to enable it in 
> backends.d/20-kolab.php.

Indeed :[ The next patch will contain this.

jmozdzen@nde.ag 2013-03-07 12:49:13
>>> - Why are the $vars->ldap__* setters necessary?
>> Do you see this as unresolved? I have not received any response to my
>> comments and concluded from my tests that those values needed to be
>> set to make it work. Thus I had set them.
>
> AFAIU the Kolab code doesn't use the $conf['ldap'] configuration, or 
> is it? If not, setting those here is not necessary.

AFAICT, it's the LDAP code that's using the ldap settings - but the 
Kolab code seems somehow to rely on the LDAP code for some of its 
functionality, i.e. the global address book.

> Also, why do you change the default ports for IMAP and SMTP?

Indeed, I should have made that configurable. The upcoming patch will 
contain the according code change.

t.nintemann@medial-networks.de 2013-03-12 13:56:55
Hi List,

i was playing around with horde 5 on Kolab and i saw this Bug-entry.
i have made an new Patch that works to me perfectly on Horde-5.0.4.

The only problem was in the conf.php which is created by kolab-webmail.
There  are  some Horde Tables that are not automatically created in SQL.

horde.alarms, horde.perms and horde.token will not created.
If i comment out this Horde DB Definitions in conf.php, everything works fine.

Next i found, was that when i activate Active Sync in Horde, the 
horde.active-sync Table is not created,
It seems that Horde with Kolab enabled did not create missing Tables in SQL.
Is it possible to create DB Tables per hand?

Thanks for the Work....

Greetings

Thomas


>>>> - Why did you remove the mbox_icon and display_folder hooks?
>>> Do you see this as unresolved? I have not received any response to my
>>> comments and was not able to resolve the issue myself.
>>> I just retested, when activating the mbox_icon hook the folder list
>>> on the left no longer loads in IMP, but despite DEBUG logging I
>>> couldn't spot obvious error messages. It's sufficient to have the
>>> code in hooks.php, even when not activated in imp/conf.d.
>>
>> You mentioned fatal errors earlier in the ticket, but I didn't see a
>> bug report or more detailed information about those anywhere. If they
>> don't work, they need fixing, not disabling.
>
> This ticket is about code specific to the kolab package, the code in 
> question no longer works with the new version, I reported the 
> problem and suggested a solution (code removal) - I didn't see the 
> need for a separate ticket.
>
> Lacking a response telling me differently, I assume that that the 
> code is based on functionality no longer available in the current 
> version of Horde. As nobody besides me seems to miss Kolab 
> integration at all, removing eye candy shouldn't be a problem at all.


Thomas Jarosch <thomas.jarosch@intra2net.com> 2013-03-12 14:03:02
> Next i found, was that when i activate Active Sync in Horde, the 
> horde.active-sync Table is not created,
> It seems that Horde with Kolab enabled did not create missing Tables in SQL.
> Is it possible to create DB Tables per hand?

Note: Kolab with ActiveSync is currently work in progress, it's not 
working out of the box right now. I'm on it.


jmozdzen@nde.ag 2013-03-12 14:09:58
>> Next i found, was that when i activate Active Sync in Horde, the
>> horde.active-sync Table is not created,
>> It seems that Horde with Kolab enabled did not create missing Tables in SQL.
>> Is it possible to create DB Tables per hand?
>
> Note: Kolab with ActiveSync is currently work in progress, it's not 
> working out of the box right now. I'm on it.

Thomas, what exactely is it that is not working? I'm using this for 
several weeks now, and everything syncs nicely... the only change I 
created is to sync only special folders, as I have an *extensive* 
mailbox structure. But even that works, as I can see each time I 
pear-upgrade my install and forget to apply my patch ;)

Regards,
Jens

Thomas Jarosch <thomas.jarosch@intra2net.com> 2013-03-12 14:16:46
>> Note: Kolab with ActiveSync is currently work in progress, it's not
>> working out of the box right now. I'm on it.
>
> Thomas, what exactely is it that is not working? I'm using this for 
> several weeks now, and everything syncs nicely... the only change I 
> created is to sync only special folders, as I have an *extensive* 
> mailbox structure. But even that works, as I can see each time I 
> pear-upgrade my install and forget to apply my patch ;)

The Horde_History backend used by Kolab is in-memory only. Mail sync 
is fine, contacts and calendars are not recommended for larger folders 
as the Horde_History gets rebuilt on every folder since (currently 
once on login).

Even if you hardcode a different Horde_History backend, there are 
other issues with are too much / too complex to list here. Patches 
will follow this month.


t.nintemann@medial-networks.de 2013-03-12 14:22:39
>>> Next i found, was that when i activate Active Sync in Horde, the
>>> horde.active-sync Table is not created,
>>> It seems that Horde with Kolab enabled did not create missing 
>>> Tables in SQL.
>>> Is it possible to create DB Tables per hand?
>>
>> Note: Kolab with ActiveSync is currently work in progress, it's not
>> working out of the box right now. I'm on it.
>
> Thomas, what exactely is it that is not working? I'm using this for 
> several weeks now, and everything syncs nicely... the only change I 
> created is to sync only special folders, as I have an *extensive* 
> mailbox structure. But even that works, as I can see each time I 
> pear-upgrade my install and forget to apply my patch ;)
>
> Regards,
> Jens

Hi Jens,

did you comment the horde_tables definitions in conf.php for alarms, 
perms and token or was the auto-create of those tables in your setup 
successful?

Regards,

Thomas Nintemann







jmozdzen@nde.ag 2013-03-12 14:56:26
>>>> Next i found, was that when i activate Active Sync in Horde, the
>>>> horde.active-sync Table is not created,
>>>> It seems that Horde with Kolab enabled did not create missing
>>>> Tables in SQL.
>>>> Is it possible to create DB Tables per hand?
>>>
>>> Note: Kolab with ActiveSync is currently work in progress, it's not
>>> working out of the box right now. I'm on it.
>>
>> Thomas, what exactely is it that is not working? I'm using this for
>> several weeks now, and everything syncs nicely... the only change I
>> created is to sync only special folders, as I have an *extensive*
>> mailbox structure. But even that works, as I can see each time I
>> pear-upgrade my install and forget to apply my patch ;)
>>
>> Regards,
>> Jens
>
> Hi Jens,
>
> did you comment the horde_tables definitions in conf.php for alarms, 
> perms and token or was the auto-create of those tables in your setup 
> successful?
>
> Regards,
>
> Thomas Nintemann

Hi Thomas,

I have two distinct installs, one originally done as an upgrade from 
H4 (where I don't recall having had issues with table creation) and 
one done as a fresh install (where I am sure everything worked wrt 
database tables).

So while I'm not 100% sure for the upgraded installation (just 95% ;) 
), the answer is "no (nothing commented out / yes (table auto-creation 
was successful)" for the fresh install.

I've been using my modified H5/kolab-webmail version of 
lib/Bundle.php, where I changed the order of calls - without that, the 
install would fail.

Regards,
Jens

t.nintemann@medial-networks.de 2013-09-06 09:56:29
Hi all,

i have created a new patch for the Kolab-Webmail Bundle.

This Patch reallows use of Ingo with Kolab Backend.
It fixes also Fatal Error while create extra Adressbooks. See Bug #12449

Now everything works almost perfect.
The only Problem is Bug #12450.
I don?t now how to fix this.

Is there a Plan for a first Release of Kolab-Webmail Bundle?

Thomas Nintemann


t.nintemann@medial-networks.de 2013-09-06 10:32:06
>>>>> Next i found, was that when i activate Active Sync in Horde, the
>>>>> horde.active-sync Table is not created,
>>>>> It seems that Horde with Kolab enabled did not create missing
>>>>> Tables in SQL.
>>>>> Is it possible to create DB Tables per hand?
>>>>
>>>> Note: Kolab with ActiveSync is currently work in progress, it's not
>>>> working out of the box right now. I'm on it.
>>>
>>> Thomas, what exactely is it that is not working? I'm using this for
>>> several weeks now, and everything syncs nicely... the only change I
>>> created is to sync only special folders, as I have an *extensive*
>>> mailbox structure. But even that works, as I can see each time I
>>> pear-upgrade my install and forget to apply my patch ;)
>>>
>>> Regards,
>>> Jens
>>
>> Hi Jens,
>>
>> did you comment the horde_tables definitions in conf.php for alarms,
>> perms and token or was the auto-create of those tables in your setup
>> successful?
>>
>> Regards,
>>
>> Thomas Nintemann
>
> Hi Thomas,
>
> I have two distinct installs, one originally done as an upgrade from 
> H4 (where I don't recall having had issues with table creation) and 
> one done as a fresh install (where I am sure everything worked wrt 
> database tables).
>
> So while I'm not 100% sure for the upgraded installation (just 95% 
> ;) ), the answer is "no (nothing commented out / yes (table 
> auto-creation was successful)" for the fresh install.
>
> I've been using my modified H5/kolab-webmail version of 
> lib/Bundle.php, where I changed the order of calls - without that, 
> the install would fail.
>
> Regards,
> Jens

Hello Jens,

the Problem with  auto-create Tables was my Problem.
I had to change my Horde Pear Environment to solve the Problem.

I have just Attach a new Patch for Kolab-Webmail Bundle
in my Comment before this.

Now everything works fine for me. ;-)
The only Problem is Bug: #12450

Do  you have the same Problem with Contact List in Turba?

Greetings

Thomas Nintemann














Jan Schneider <jan@horde.org> 2013-09-06 12:45:08
Fixing contact lists is on my todo list for Turba 4.2.

Jan Schneider <jan@horde.org> 2016-01-28 15:08:49
Did anybody recently tried if this patch still applies and works?

jmozdzen@nde.ag 2016-01-29 16:57:47
Hi Jan,

> Did anybody recently tried if this patch still applies and works?

my installation currently is a mix of stable, patched and modified 
code... and no, I haven't tried anything above my own changes 
mentioned in this patch. :-(

vectro@vectro.org 2017-03-12 21:40:23
FWIW this patch does not come close to applying to Horde 5.2.16. ?

Michael Rubinsky <mrubinsk@horde.org> 2017-03-12 22:52:10
Considering it's ~4 years old, it's not surprising.