[#10519] work week view in dynamic mode
Summary work week view in dynamic mode
Queue Kronolith
Queue Version Git master
Type Enhancement
State Resolved
Priority 1. Low
Owners jan@horde.org
Requester rsalmon@mbpgroup.com
Created 2011-09-15 (2199 days ago)
Due
Updated 2012-08-29 (1850 days ago)
Assigned
Resolved 2011-11-15 (2138 days ago)
Milestone 3.1
Patch Yes

Comments
rsalmon@mbpgroup.com 2011-09-15 13:35:34
"work week" view is available in traditional mode, but not in dynamic mode.

rsalmon@mbpgroup.com 2011-09-15 13:47:46
I've started to work on a patch and it nearly works.

The working week shows 5 days, but events are working with 7 days :-(



rsalmon@mbpgroup.com 2011-09-15 14:30:39
some typos

rsalmon@mbpgroup.com 2011-09-22 08:47:05
with the patch attached, everything looks good.

[/var/www/html]# patch -u -p0 -d /var/www/html/horde/ <workweek3.patch

this patch only works with the default theme.



Jan Schneider <jan@horde.org> 2011-11-14 16:14:50
The patch looks really nice, there's only one issue: You can't rely on 
changes in horde.js, because that's a BC break. (Beside that you added 
the new method twice to horde.js).
It should be sufficient to use moveToEndOfWeek() and then move 2 days back.
If you fix this and make sure that the patch applies cleanly to the 
develop branch, we can integrate it. I'm a a bit afraid that this 
might cause space issues in the button bar, but that's a different 
story.

rsalmon@mbpgroup.com 2011-11-14 17:02:56
> The patch looks really nice, there's only one issue: You can't rely 
> on changes in horde.js, because that's a BC break. (Beside that you 
> added the new method twice to horde.js).
> It should be sufficient to use moveToEndOfWeek() and then move 2 days back.
> If you fix this and make sure that the patch applies cleanly to the 
> develop branch, we can integrate it. I'm a a bit afraid that this 
> might cause space issues in the button bar, but that's a different 
> story.

I've updated the patch.



Jan Schneider <jan@horde.org> 2011-11-15 07:12:04
Tweaked and committed. Great work, many thanks!

rsalmon@mbpgroup.com 2011-11-15 08:33:13
> Tweaked and committed. Great work, many thanks!

More than happy to contribute ;)

Do you have an approximate time of release for 3.1 ? weeks, months ... 
years  (hope not!)



Jan Schneider <jan@horde.org> 2011-11-15 13:29:06
April 2012.

rsalmon@mbpgroup.com 2011-11-15 14:02:31
> April 2012.

:-(

Looking at http://www.horde.org/apps/kronolith/roadmap, Kronolith 4.0 
is planned for April 2012

This ticket is set for Milestone 3.1. Is Kronolith 3.1 due for April 
2012 as well ?

Thanks.

Jan Schneider <jan@horde.org> 2011-11-15 14:19:04
Why does it matter which version it will have?

rsalmon@mbpgroup.com 2011-11-15 14:47:08
> Why does it matter which version it will have?

It doesn't. I was just hopping to see the new "work week view" 
function released sooner than April 2012 and make our users happy.


Git Commit <commits@lists.horde.org> 2012-08-29 12:25:01
Changes have been made in Git (master):

commit db71c46002302def4aafa204f2d544071bf24bef
Author: Jan Schneider <jan@horde.org>
Date:   Tue Nov 15 06:48:33 2011 +0100

     [jan] Add work week view to dynamic interface 
(rsalmon@mbpgroup.com, Request #10519).

  kronolith/docs/CHANGES                 |    2 +
  kronolith/js/kronolith.js              |  106 +++++++++++++++++++++----------
  kronolith/package.xml                  |    1 +
  kronolith/templates/index/index.inc    |   12 ++--
  kronolith/templates/index/workweek.inc |   71 +++++++++++++++++++++
  kronolith/themes/default/screen.css    |   33 +++++++---
  kronolith/themes/silver/ie7.css        |    3 +
  kronolith/themes/silver/ie8.css        |    3 +
  kronolith/themes/silver/screen.css     |    6 ++
  9 files changed, 188 insertions(+), 49 deletions(-)

http://git.horde.org/horde-git/-/commit/db71c46002302def4aafa204f2d544071bf24bef