Tickets :: Comment on [#3966] Move duplicate code to build RDN into new method to simplify subclassing of LDAP driver

* Your Email Address
* Spam protection	Enter the letters below: ___ ___ ___ _____ \| \ \ / \ \ / / \| \|_ _\| \| \|\ \ / / \ \ / /\| \| \| \| _ \| \| \ \/ / \ \/ / \| \| \| \| \| \|__\| \| \ / \ / \| \|____ _\| \|_ \____/ \/ \/ \|______\|_____\|
Comment	> In turba/lib/Driver/ldap.php the RDN of objects is currently > assembled in two functions: _makeKey and _save (if an object is > renamed). I suggest to move the code that builds the RDN from the > attributes into a new method. With this change it becomes much easier > to subclass the LDAP driver and to build your own custom DNs. > Maintainance also becomes somewhat easier if no code is duplicated. > > > > I've attached a patch that introduces a new method called _makeRDN. > The patch was created using the files from Turba 2.1.1 but should > should apply against HEAD without problems.
Attachment
Watch this ticket