Toggle Alerts Log
Comment on [#11076] One Time Password Module Implementation - request for comment
Your Email Address
Enter the letters below:
_____ _____ ___ __ / __\ \ / / __| | \ \ / / | (_ |\ \/\/ /| _| || |\ V / \___| \_/\_/ |_| \__/ \_/
> - The driver should probably be called Horde_Auth_HashChain, because > this is just one possible implementation of OTP authentication and > Horde_Auth_Otp is too generic. > - You should use the existing user_pass field. > - It's okay to add an additional field for the chain index to the > general user table. It should follow the column nomenclature though > and should be added by a migration script. > - Why is the _reduce_password method necessary? This doesn't make > sense to me. Also, you are using the pwdformat_length parameter, but > it's not documented and you don't set the default value in the > constructor like for the other parameters. > - You should extend the Horde_Auth_Sql class and only overwrite those > methods and properties that are necessary. > - There also some minor style issues that should be tackled in a > final version.
Watch this ticket