Lee may submit some additional patches but this is certainly no longer a bug.

If you submit a patch against HEAD that doesn't have width: width 
(double specification) , touches the fewest possible lines, and has 
cleaner width determination code, I'll look at it. The PDF looks nice 
enough to make me reconsider a bit.

The difference to these applications is that you can easily resize the 
menu in these applications; in Horde you need to go to the options and 
change it from there, trying as long until all folders appear.

Of course in the end its up to you, but it seems to me like if we can 
definitively improve the usability of imp/horde, even just slightly, 
with just a few lines of code thats already written, why not do it? 
While my coding abilities are passable, my area of expertise is much 
closer to UI design as it relates to usability. In this case i really 
believe there is a good reason that almost every desktop mail client 
(Mac Mail, Outlook etc..) horizontally truncate the folder list with 
ellipses, as opposed letting it run off to the right with horizontal 
scroll bars. When a user sees text cut off, they get an implicit sense 
of something being broken. The ellipses say "there is more to these 
names, and its not broken, but you have set the frame set to something 
that needs to truncate teh text. Aesthetically, maintaining a 
consistent spacial border improves overall look. If i had a spare 
week, id spend the time writing truncation/ellipses code in javascript 
that would extend this to mozilla as well as IE.



Anyway, thats my 2cents. I wont bring it up again, its up to you.

I'm happy with things are now in CVS - some cleanups and tweaks with 
what I applied. Nothing wraps to a new line, and that's the important 
part. Scrollbars are okay on the menu frame, since they ensure that 
everything can be seen, and people can adjust their sidebar width in 
their preferences anyway.

diff -u it is!



The width stuff is essential for two things in Internet Explorer:



1) With the diff you applied there are no ellipses. The width stuff 
forces the div to end and create the ellipses. This makes things much 
cleaner looking.



2) With the diff you applied, the text in the menu forces the left 
menu page to extend as far to the right as the text will take it. This 
can create a long horizontal scroller in the left menu frame. With teh 
width stuff in tact, this doesnt happen, again making things look much 
cleaner.



If you want to see this in action, try applying your modified diff vs. 
the original i submitted with an account with a multi-level folder 
tree (particularly if there are some long folder names) in Internet 
Explorer. You'll see a pretty significant difference (i just tried it 
on my local install to confirm this).

You should look into cvs diff -u :) But the general idea looks good; 
I've committed the patch minus the width specifications, which don't 
seem necessary to me.

I dont know how to make a combined patch, but here are the individual 
patches in one file. I removed the commented stuff, and rebuilt the 
patch off a 100% stock download, so it should apply without warnings.

Can please upload a clean unified patch? This patch didn't apply 
cleanly, there is a stray "alert" in there and some outcommented code.

I didn't try the patch, but the description sounds okay.

I think I'm fine with this change - what do other folks think?

think i reversed the diff, lets try this again:



1) diff templates/portal/sidebar.inc.orig templates/portal/sidebar.inc.new



1,2c1,2

< <div id="expandedSidebar">

<  <div id="menu">

---

22d21

<  </div>

24,26c23,24

<  <!--a75c305b1c0a6022--><table cellspacing="0" width="100%">

<   <tr>

<    <td valign="top" id="sidebarPanel" width="100%" colspan="2">

---
28,31c26

<    </td>

<    <td>&nbsp;</td>

<   </tr>

<  </table>

---
2) diff templates/javascript/tree.js.orig templates/javascript/tree.js.new



165c165

<     var line = '<div style="height:20px; clear:both"' + className + '>';

---
175,176c175,176

<             style = 'float:left;';

<             if (this.header[column] && this.header[column]['width']) {

---
178c178

<             }

---
262d261

<     alert(line);

475c474

<         document.body.style.marginRight = '15px';

---

in RC1 the menu list scrolled off the screen to the right cutting 
things off (when the foldernames were more than x chars long), 
creating a long bottom scroll bar. RC2 remedied this problem, but 
caused folder names to wrap to a new line below their icon 
(firefox/mozilla) - which looks much worse.



Using some fun CSS properties and a little tweaking of the code ive 
fixed the problem. In the code below the folder names do not wrap, 
they just get cut off when the frame ends, they also dont cause the 
whole frame to expand right the length of the longest menu item. In IE 
things are a little cooler, the folder names actually get elipsed 
(i.e. longfoldernamehere becomes longfoldernameh... right before the 
frame's right barrier.



Tested in mozilla and IE, looks alot better than before to me.



Here are the two diff files (not at an expert in submitting diffs, i 
just made them running the straight old diff command with teh two 
files as arguments). If you need a different format diff let me know.



1) HORDE: TEMPLATES/PORTAL/SIDEBAR.INC:



1,2c1,2

< <div id="expandedSidebar" style="width: width:<?php if 
($GLOBALS['browser']->hasQuirk('scrollbar_in_way')) { echo 
isset($prefs) ? ($prefs->getValue('sidebar_width')-35) : 133; } else { 
echo isset($prefs) ? ($prefs->getValue('sidebar_width')-50) : 150; } 
?>; overflow: hidden; padding: 0; margin: 0;">

<  <div id="menu" style="width: width:<?php if 
($GLOBALS['browser']->hasQuirk('scrollbar_in_way')) { echo 
isset($prefs) ? ($prefs->getValue('sidebar_width')-35) : 133; } else { 
echo isset($prefs) ? ($prefs->getValue('sidebar_width')-50) : 150; } 
?>; overflow: hidden; padding: 0; margin: 0;">

---
21a22
23,24c24,26

< </div>

< <div id="sidebarPanel" style="overflow: hidden; width: width:<?php 
if ($GLOBALS['browser']->hasQuirk('scrollbar_in_way')) { echo 
isset($prefs) ? ($prefs->getValue('sidebar_width')-35) : 133; } else { 
echo isset($prefs) ? ($prefs->getValue('sidebar_width')-50) : 150; } 
?>; text-overflow:ellipsis; white-space:nowrap;">

---
26c28,31

< </div>

---
2) TEMPLATES/JAVASCRIPT/TREE.JS:



165c165

<     var line = '<div style="height:20px; clear:both; 
text-overflow:ellipsis; overflow:hidden; white-space:nowrap; 
width:<?php if ($GLOBALS['browser']->hasQuirk('scrollbar_in_way')) { 
echo isset($prefs) ? ($prefs->getValue('sidebar_width')-35) : 133; } 
else { echo isset($prefs) ? ($prefs->getValue('sidebar_width')-50) : 
150; } ?>;' + className + '>';

---
175,176c175,176

<             style = 'float:left; text-overflow:ellipsis; 
overflow:hidden; white-space:nowrap; width:<?php if 
($GLOBALS['browser']->hasQuirk('scrollbar_in_way')) { echo 
isset($prefs) ? ($prefs->getValue('sidebar_width')-35) : 133; } else { 
echo isset($prefs) ? ($prefs->getValue('sidebar_width')-50) : 150; } 
?>;';

<             /*if (this.header[column] && this.header[column]['width']) {

---
178c178

<             }*/

---
261a262
474c475

<         document.body.style.marginRight = '0px';

---
2)