Okay, I'm resolving this ticket. If there are remaining issues (IE 
stuff?), please address them in smaller, more manageable tickets.

Works fine here too.

I don't see any problems with sidebar folders in Safari (also based on 
KHTML). Can anyone reproduce that issue in Konqueror?

This is fixed now, at least for IE 6. Can you check again if 5.0 is 
maybe fixed too?

I agree, but avoiding it here doesn't seem to leave many options for 
fixing the spacing issue...

We should really try to keep browser workarounds with separate css 
files to a minimum.

Also, the push() stuff is fixed.

I can confirm that the vertical space (between the vertical ... tree 
lines) is there in IE6/win. Anyone object to adding more checks to 
Horde::stylesheetLink() to load stylesheets for IE 5.0, 5.5, and 6.0? 
Or should we let this be?

For eliminating those spaces please add:



For MSIE 5.5, 6.0:

#sidebarPanel img {

     vertical-align: middle;

}



For MSIE 5.0 (works in MSIE 5.5 and 6.0 too, but the images and labels 
are not nicely aligned):

#sidebarPanel img {

     vertical-align: bottom;

}



to screen.css to all themes.

(((1))) There is another problem with MSIE 5.0. It doesn't support 
array.push(object) method, so you should instead use 
array[array.length] = object.



For example, now you can't close the branch in the sidebar tree, 
because of that problem. Patch:

templates/javascript/tree.js line 429:

- newNodes.push(nodes[i]);

+ newNodes[newNodes.length] = nodes[i];



... but there are other places where the push method is used.



(((2))) About that horizontal space between rows in tree menu: Yes, I 
use custom theme, but I only changed a color, and I experience this 
problem while using other themes too. This envolves MSIE 5.0, MSIE 
5.5, MSIE 6.0. I'll try to manage to send you the patch asap.



(((3))) Image loading - this problem doesn't show only on page loads, 
but everytime I open or close a branch. The MSIE doesn't cache 
anything for me (or maybe does, but it doesn't influence that). I have 
cache turned on, and Tools/Internet Options/Advanced/Restore Defaults. 
MSIE 5.0, MSIE 5.5, MSIE 6.0.



As I mentioned before, I've been working on a project that uses 
Javascript tree too, supporting dynamic loading and many special 
features, so I know it is possible to improve the tree in the Horde so 
those problems will be eliminated (problem 2 and 3). I'll try to 
manage to look at it, but unfortunately I am under time pressure now.

The IE 5.0 issues with "undefined" have been fixed.



We *do* workaround the horizontal space in IE 5.5+ with the 
"scrollbar-quirk" CSS class. You probably messed this workaround up 
with your custom theme.



We can't improve the image loading in IE any further, at least to our 
knowledge. Pre-loading the images doesn't help either, they still need 
to get loaded. Subsequent page loads have the images cached, so it's 
not an issue then anymore.



And yes, we test XHTML conformancy from time to time, but not on a 
regular basis. Patches to keep conform are always welcome.



AFAICS this leaves only the Konqueror issue open?

<QUOTE>Opera 7.52 - selecting "Horde" menu item, the menu items in the 
top menubar are messed - see screenshot. In other apps it has 
worked</QUOTE>



In the current CVS HEAD it works :-).

e.g.: login.php, line 135:  MSIE 5.0 error message: 'undefined' is undefined



You should use if (typeof something == 'undefined') { ...



I've grepped out theese lines:

===> cut here <===



gollem/templates/login/login.inc:20:    if (e != undefined && 
!enter_key_trap(e)) {

imp/templates/login/login.inc:67:    if (e != undefined && 
!enter_key_trap(e)) {

js/image.js:27:    if (no_cache == undefined) {

js/image.js:54:    if (ratio == undefined) {

templates/common-footer.inc:11:if (typeof(_setHordeTitle) == undefined 
&& parent.frames.horde_main) parent.document.title = '<?php echo 
addslashes($registry->get('name') . ' :: ' . $title) ?>';

templates/javascript/form_sections.js:23:    this._openSection = undefined;

templates/javascript/keybindings.js:48:    if (_keyMap[key] == undefined) {

templates/login/login.inc:13:    if (e != undefined && !enter_key_trap(e)) {

turba/templates/block/minisearch.inc:5:    if (e != undefined && 
!enter_key_trap(e)) {

===> cut here <===

Please provide the full javascript error message from IE 5.0, and the 
(HTML) source code at that position.

1. I've tested horde framework a bit in different browsers. Here are 
my results:

Mozilla Firefox 1.0 - almost OK - see bug 809

Opera 7.52 - selecting "Horde" menu item, the menu items in the top 
menubar are messed - see screenshot. In other apps it has worked

Konqueror 3.x - in the left tree menu under "Mail" there are no 
folders displayed. Selecting "Mail" menuitem causes right frame to be 
forever loading ... see screenshot

MSIE 5.0 - unusable - see screenshot, javascript errors

MSIE 6.0,  MSIE 5.5

- see ugly horizontal spaces in the left tree menu

- image loading is too slow when I open / close tree branch or load a 
page. In the status bar you can see (123 items remaining) and the 
number is decrementing. It tooks about 20 seconds, although all the 
visible images are loaded sooner (in 5 seconds - also too slow ). This 
bug is caused because of buggy MSIE, but there is a workaround by 
precaching images and to display them after they are completly loaded, 
something like:

var img = new Image();

img.onload = function () { document.getElementById('someimage').src = 
img.src; ... }

img.src = "...";



... or I can attach here a Javascript if someone will ask me to.



I've been working on one project using a big dynamic (using hidden 
frames) javascript tree, and I ve managed to get it work on >= MSIE 
5.0, Mozilla, Opera and Konqueror. Yeah, I know, MSIE sucks! But there 
are many users using even MSIE 5.0 :-(





2. Do you occasionaly validate generated pages against W3C standards? 
I tried it recently and there are some errors.