6.0.0-RC7
6/27/26

[#724] smbpasswd needs to close pipe
Summary smbpasswd needs to close pipe
Queue Passwd
Queue Version HEAD
Type Bug
State Resolved
Priority 1. Low
Owners jan (at) horde (dot) org
Requester ctnpublic-horde (at) yahoo (dot) com
Created 10/26/04 (7914 days ago)
Due
Updated 10/26/04 (7914 days ago)
Assigned 10/26/04 (7914 days ago)
Resolved 10/26/04 (7914 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
278 Jan Schneider Comment #2
State ⇒ Resolved
Reply to this comment
I moved this into a separate method to better match the driver layout, thanks.
08 Jan Schneider Assigned to Jan Schneider
State ⇒ Assigned
 
287 ctnpublic-horde (at) yahoo (dot) com Comment #1
State ⇒ Unconfirmed
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ smbpasswd needs to close pipe
Queue ⇒ Passwd
Reply to this comment
My smbpasswd.php does not get any output unless the command exec pipe 
is properly closed.



cvs diff -u -r HEAD passwd/lib/Driver/smbpasswd.php

Index: passwd/lib/Driver/smbpasswd.php

===================================================================

RCS file: /repository/passwd/lib/Driver/smbpasswd.php,v

retrieving revision 1.18

diff -u -r1.18 smbpasswd.php

--- passwd/lib/Driver/smbpasswd.php     6 Apr 2004 00:11:33 -0000       1.18

+++ passwd/lib/Driver/smbpasswd.php     26 Oct 2004 06:59:01 -0000

@@ -110,6 +110,9 @@

              return $res;

          }



+       // must close the pipe else we'll get no output

+       pclose($this->_fp);

+

          $res = file($tmpfile);

          if (strstr($res[count($res) - 1], 'Password changed for 
user') === false) {

              return PEAR::raiseError(strrchr(trim($res[count($res) - 
2]), ':'));


Saved Queries