Summary | Show the script in "Show Active Script" |
Queue | Ingo |
Queue Version | 1.1.5 |
Type | Enhancement |
State | No Feedback |
Priority | 1. Low |
Owners | |
Requester | skhorde (at) smail (dot) inf (dot) fh-bonn-rhein-sieg (dot) de |
Created | 02/28/2008 (6291 days ago) |
Due | |
Updated | 05/05/2008 (6224 days ago) |
Assigned | |
Resolved | 03/13/2008 (6277 days ago) |
Milestone | |
Patch | No |
maintain Net_Sieve.
CAPABILITY string send after STARTTLS:
http://tools.ietf.org/html/draft-martin-managesieve-08#section-2.2
"After the TLS layer is established, the server MUST re-issue the
capability results, followed by an OK response. This is necessary to
protect against man-in-the-middle attacks which alter the
capabilities list prior to STARTTLS. This capability result MUST NOT
include the STARTTLS capability."
This patch allows TLS working:
@@ -373,6 +373,11 @@
if (PEAR::isError($res = $this->_startTLS())) {
return $res;
}
+ // Get STARTTLS capability and parse
+ if (PEAR::isError($res = $this->_doCmd())) {
+ return $res;
+ }
+ $this->_parseCapability($res);
}
}
State ⇒ Feedback
inconsistent behavior?
The behavious is different, if I disable TLS in ./pear/Net/Sieve.php.
With TLS I see the output of LISTSCRIPTS.
Without TLS I see the contents of the active script.
I need to figure out, how to debug a TLS session.
Priority ⇒ 1. Low
Type ⇒ Enhancement
Summary ⇒ Show the script in "Show Active Script"
Queue ⇒ Ingo
State ⇒ New
output of the LISTSCRIPTS command. However, the script is not shown.
It would be good to display the contents of the active script as well,
as it was in Ingo v1.1.4.
Moreover, it would good to have a state shown above, like "the server
script matches the current Ingo script" or not.