6.0.0-alpha10
5/17/25

[#6164] Unable to edit client name
Summary Unable to edit client name
Queue Midas
Queue Version HEAD
Type Bug
State Resolved
Priority 2. Medium
Owners chuck (at) horde (dot) org
Requester paul.g.roy (at) uottawa (dot) ca
Created 01/28/2008 (6319 days ago)
Due
Updated 01/29/2008 (6318 days ago)
Assigned 01/29/2008 (6318 days ago)
Resolved 01/29/2008 (6318 days ago)
Milestone
Patch No

History
01/29/2008 09:49:55 PM Chuck Hagenbuch Comment #4
Assigned to Chuck Hagenbuch
State ⇒ Resolved
Reply to this comment
Fixed now, thanks.
01/29/2008 02:41:45 PM paul (dot) g (dot) roy (at) uottawa (dot) ca Comment #3 Reply to this comment
Unfortuantely, the commit didn't fix it.



I got around the problem with these changes:



- Added line 32:

$client_id = $vars->get('client_id');

-> $formname = $vars->get('formname');  <-



- Wrapped the redefinition of $vars in an if statement:

if ($client_id) {

-> if (empty($formname)) { <-

$vars = new Variables($clients->getUnit($client_id));

-> } <-



Works OK now.



Paul




01/29/2008 05:28:58 AM Chuck Hagenbuch Comment #2
State ⇒ Feedback
Reply to this comment
Can you please see if this commit fixes it for you?



http://cvs.horde.org/diff.php?r1=1.25&r2=1.26&f=midas%2Fclients%2Fedit.php
01/28/2008 08:59:22 PM paul (dot) g (dot) roy (at) uottawa (dot) ca Comment #1
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ Unable to edit client name
Queue ⇒ Midas
State ⇒ Unconfirmed
Reply to this comment
Cannot edit the name of an existing client. The Store button simply 
cycles back to the edit page without saving the change.



Problem is in midas/clients/edit.php on line 35:



$vars = new Variables($clients->getClient($client_id));



- this line clears the 'formname' var on submit and causes form 
validation to fail



Using:

- Horde 4.0-cvs and Midas CVS update from 28 Jan 2008

- midas/clients/edit.php  version is v 1.25 2008/01/02

Saved Queries