6.0.0-beta1
9/14/25

[#6038] horde's config/hooks.php gives kolab examples that use deprecated method calls
Summary horde's config/hooks.php gives kolab examples that use deprecated method calls
Queue Kolab
Type Bug
State Resolved
Priority 1. Low
Owners jan (at) horde (dot) org, wrobel (at) horde (dot) org
Requester m.gabriel (at) das-netzwerkteam (dot) de
Created 12/24/2007 (6474 days ago)
Due
Updated 02/29/2008 (6407 days ago)
Assigned 02/25/2008 (6411 days ago)
Resolved 02/29/2008 (6407 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
02/29/2008 09:44:29 AM Jan Schneider Assigned to Gunnar Wrobel
Taken from Chuck Hagenbuch
State ⇒ Resolved
 
02/29/2008 08:52:51 AM Gunnar Wrobel Comment #2
Assigned to Chuck Hagenbuch
Assigned to Jan Schneider
Taken from Gunnar Wrobel
New Attachment: HK-GW-Deprecated_hooks.patch Download
Reply to this comment
Yes, these examples are indeed outdated.



In the old driver version the whole share management wasn't integrated 
into the main share driver. So the Kolab module had to synchronize 
after any change. This was pretty fragile and was one of the central 
fixes in the newer driver versions.



@Chuck or Jan: Can you commit the attached patch? Thanks!
02/25/2008 01:01:39 AM Jan Schneider State ⇒ Assigned
 
12/25/2007 03:22:55 AM Chuck Hagenbuch Assigned to Gunnar Wrobel
 
12/25/2007 03:22:48 AM Chuck Hagenbuch Version ⇒
Queue ⇒ Kolab
 
12/24/2007 11:14:52 PM m (dot) gabriel (at) das-netzwerkteam (dot) de Comment #1
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ horde's config/hooks.php gives kolab examples that use deprecated method calls
Queue ⇒ Horde Groupware Webmail Edition
State ⇒ Unconfirmed
Reply to this comment
i am using kolab-2.1 (debian unstable) and horde-webmail-1.1rc1



in horde's config/hooks.php you find these hook examples (commented 
out), that still use updateShare, removeShare of horde 3.1.x (i guess).



if (!function_exists('_horde_hook_share_add')) {

      function _horde_hook_share_add(&$share)

      {

          require_once 'Horde/Kolab.php';

          return Kolab::updateShare($share);

      }

}



if (!function_exists('_horde_hook_share_modify')) {

      function _horde_hook_share_modify(&$share)

      {

          require_once 'Horde/Kolab.php';

          return Kolab::updateShare($share);

      }

}



if (!function_exists('_horde_hook_share_remove')) {

      function _horde_hook_share_remove(&$share)

      {

          require_once 'Horde/Kolab.php';

          return Kolab::removeShare($share);

      }

}



what exactly was the meaning of these hooks? are they still needed in 
horde-3.2.x and if yes, how can i substitute them?



best,

mike

Saved Queries