6.0.0-beta1
7/22/25

[#598] Oracle SQL scripts contain blanklines in SQL statements
Summary Oracle SQL scripts contain blanklines in SQL statements
Queue Horde Base
Queue Version HEAD
Type Bug
State Resolved
Priority 1. Low
Owners chuck (at) horde (dot) org
Requester rvs (at) angara (dot) ru
Created 09/16/2004 (7614 days ago)
Due
Updated 09/17/2004 (7613 days ago)
Assigned 09/17/2004 (7613 days ago)
Resolved 09/17/2004 (7613 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
09/17/2004 07:12:41 PM Chuck Hagenbuch Comment #7
State ⇒ Resolved
Reply to this comment
Okay, but then it does need a seperate script. I'm going to resolve 
this ticket; please open seperate tickets as appropriate for:



1. scripts that would work fine if the blank lines had comments. (all 
in one ticket as you can).



2. scripts that need custom oracle versions to work properly (one 
ticket per app would be great).



Thanks!
09/17/2004 07:10:31 PM rvs (at) angara (dot) ru Comment #6 Reply to this comment
Yes it will be OK for SQLPLUS with default settings, but don't forget 
Oracle specific data types and DEFAULT notation. Should be written as 
this:



     task_private    NUMBER(16) DEFAULT 0 NOT NULL,

--

     PRIMARY KEY (task_id)


09/17/2004 07:00:07 PM Chuck Hagenbuch Comment #5 Reply to this comment
What I was thinking was that for the scripts for apps like Nag, we 
could do this:



     task_private    INT NOT NULL DEFAULT 0,

--

     PRIMARY KEY (task_id)



That make more sense?
09/17/2004 07:40:39 AM rvs (at) angara (dot) ru Comment #4 Reply to this comment
Well any comments are accepted. If you comment out the blank lines 
_inside_ SQL

statements, all will work fine. The blank lines will be accepted 
outside of SQL statements also.
09/17/2004 03:47:29 AM Chuck Hagenbuch Comment #3
State ⇒ Feedback
Reply to this comment
I've made the change to oracle_create.sql. I don't want to change 
other apps scripts to eliminate lines if possible, but I don't want to 
have to have oracle-specific scripts either - thus the question about 
comments. Let me know.
09/16/2004 08:36:54 PM Chuck Hagenbuch Comment #2
Assigned to Chuck Hagenbuch
State ⇒ Assigned
Reply to this comment
Will a line with a comment on it count as blank, or would that be accepted?
09/16/2004 06:22:12 PM rvs (at) angara (dot) ru Comment #1
State ⇒ Unconfirmed
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Oracle SQL scripts contain blanklines in SQL statements
Queue ⇒ Horde Base
Reply to this comment
Platform: Apache1.3.31+php4.3.8+Oracle9.2.0.1



File horde/scripts/db/oracle_create.sql,v 1.6.

The table creation scripts for Oracle contain blanklines before

PRIMARY KEY clause.

The SQLPLUS utility on Oracle9.2 doesn't like this by default because 
the SQLBLANKLINES parameter defaults to OFF.



Suggest adding "set sqlblanklines on;" at the script start for 
seamless table creation.

Note: this issue is applicable for other applications, such as Turba, 
Whups etc.


Saved Queries