5.3.0-git
2014-09-18

[#5578] Turba contact lists could lose entries when switching share support on or off
Summary Turba contact lists could lose entries when switching share support on or off
Queue Turba
Queue Version HEAD
Type Bug
State Resolved
Priority 1. Low
Owners mrubinsk (at) horde (dot) org
Requester mrubinsk (at) horde (dot) org
Created 2007-07-24 (2613 days ago)
Due
Updated 2007-08-25 (2581 days ago)
Assigned 2007-08-24 (2582 days ago)
Resolved 2007-08-25 (2581 days ago)
Milestone
Patch No

History
2007-08-25 13:35:22 Michael Rubinsky State ⇒ Resolved
 
2007-08-25 02:41:53 Chuck Hagenbuch Comment #4 Reply to this comment

[Show Quoted Text - 9 lines]
It seems okay to me to let it go.
2007-08-24 20:15:41 Michael Rubinsky Comment #3
State ⇒ Feedback
Reply to this comment
This could also happen, however, when upgrading to Turba 2.2 when the
flatten shares upgrade script is run since this could also change the
$cfgSource array keys as well.  Fixing this in the upgrade script is
not possible for all sources since we would run into authentication
issues with some backends.  We would have to build in some sort of
maintenance in Turba to  run a conversion, although I haven't looked
deeply enough at this yet to know if it is 100% possible or not....
This part of the issue has been resolved with the addition of the 
upgradelists maintenance task.



I'm still torn about the first part of the issue, although I'm leaning 
towards saying that it *is* a change in sources, so we can accept 
those contacts disappearing from lists in other sources.  While 
writing a maintenance task to update them would be trivial, it would 
either requrie a new pref to be added any time a source is switched or 
a hard coded check for some sort of configuration flag that would have 
to be checked EVERY login.  Seeing how these 'foreign contacts` were 
not even working properly in 2.1.4 (or maybe earlier), I say just 
document this somewhere...thoughts?
2007-07-24 17:05:14 Michael Rubinsky Comment #2
State ⇒ Assigned
Reply to this comment
fix state
2007-07-24 16:49:40 Michael Rubinsky Comment #1
State ⇒ Feedback
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Turba contact lists could lose entries when switching share support on or off
Queue ⇒ Turba
Assigned to Michael Rubinsky
Reply to this comment
Currently, if we change the value of 'use_shares' for a given source 
(either turning on or off share support) any contacts contained in 
that source that are present in a contact list in another source would 
be removed from that list.  This is due to the fact that the contact 
list uses the $cfgSource array key to signify what source the contact 
is from, and when we switch share support, the key changes.  For this 
issue we *could* say that changing from shares to no shares (or vice 
versa) constitutes a change in sources so losing those contact list 
entries makes sense (thus turning this issue basically into a note on 
the UPGRADE doc).



This could also happen, however, when upgrading to Turba 2.2 when the 
flatten shares upgrade script is run since this could also change the 
$cfgSource array keys as well.  Fixing this in the upgrade script is 
not possible for all sources since we would run into authentication 
issues with some backends.  We would have to build in some sort of 
maintenance in Turba to  run a conversion, although I haven't looked 
deeply enough at this yet to know if it is 100% possible or not....



Thoughts?