6.0.0-beta1
8/15/25

[#5394] Improve input validation of datetime and hourminutesecond form fields
Summary Improve input validation of datetime and hourminutesecond form fields
Queue Horde Framework Packages
Queue Version HEAD
Type Bug
State Resolved
Priority 1. Low
Owners jan (at) horde (dot) org
Requester thomas.jarosch (at) intra2net (dot) com
Created 05/23/2007 (6659 days ago)
Due
Updated 05/23/2007 (6659 days ago)
Assigned 05/23/2007 (6659 days ago)
Resolved 05/23/2007 (6659 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
05/23/2007 04:12:19 PM Jan Schneider Comment #4
Assigned to Jan Schneider
State ⇒ Resolved
Reply to this comment
Committed, thanks.
05/23/2007 02:58:55 PM thomas (dot) jarosch (at) intra2net (dot) com Comment #3 Reply to this comment
I already committed a fix to the validation recently, did you take
this into account? See
http://cvs.horde.org/diff.php?r1=1.401&r2=1.402&f=framework%2FForm%2FForm.php
Yes, it's another fix on top of your fix. For the new datetime field, 
the empty check gets called with an array of five elements in case of 
nag's "due" field. As you limited the check to only check the date 
relevant fields, $empty counts to three which is != count($date).


05/23/2007 02:40:35 PM Jan Schneider Comment #2
State ⇒ Feedback
Reply to this comment
I already committed a fix to the validation recently, did you take 
this into account? See 
http://cvs.horde.org/diff.php?r1=1.401&r2=1.402&f=framework%2FForm%2FForm.php
05/23/2007 02:29:24 PM thomas (dot) jarosch (at) intra2net (dot) com Comment #1
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Improve input validation of datetime and hourminutesecond form fields
Queue ⇒ Horde Framework Packages
New Attachment: framework-fix-datetime-validation.patch Download
State ⇒ Unconfirmed
Reply to this comment
Hello,



attached patch improves the input validation of datetime and the 
hourminutesecond form fields. PHP considers empty("0") to be empty, 
which is bad for time fields.



If one field is set in datetime, we require all fields. Also datetime 
calls the input validation of the monthdayyear field with an array of 
five elements, this also broke the empty check of monthdayyear.



Thomas


Saved Queries