Tickets :: [#5097] Splitting functionality in the Kolab driver

6.0.0-beta1

8/23/25

Summary	Splitting functionality in the Kolab driver
Queue	Horde Framework Packages
Queue Version	HEAD
Type	Enhancement
State	Resolved
Priority	1. Low
Owners
Requester	wrobel (at) pardus (dot) de
Created	03/09/2007 (6742 days ago)
Due
Updated	03/09/2007 (6742 days ago)
Assigned
Resolved	03/09/2007 (6742 days ago)
Milestone
Patch	No

03/09/2007 04:32:31 PM	Chuck Hagenbuch	Comment #9	Reply to this comment
Fixed now, thanks.

03/09/2007 03:26:25 PM	wrobel (at) pardus (dot) de	Comment #8 New Attachment: framework-Kolab_Driver-split_20070309-3.patch	Reply to this comment
[Show Quoted Text - 12 lines][Hide Quoted Text] I've just update to the latest version of "framework". I haven't tried the code yet, but the include paths look wrong to me: require_once 'Horde/IMAP.php'; require_once 'Horde/LDAP.php'; Shouldn't this read: require_once 'Horde/Kolab/IMAP.php'; require_once 'Horde/Kolab/LDAP.php'; ? Ups, you are certainly right. Sorry for that. I was to quick this morning. Patch attached.

03/09/2007 03:08:31 PM	thomas (dot) jarosch (at) intra2net (dot) com	Comment #7	Reply to this comment
Hello, Committed, thanks. I've just update to the latest version of "framework". I haven't tried the code yet, but the include paths look wrong to me: require_once 'Horde/IMAP.php'; require_once 'Horde/LDAP.php'; Shouldn't this read: require_once 'Horde/Kolab/IMAP.php'; require_once 'Horde/Kolab/LDAP.php'; ? Cheers, Thomas

03/09/2007 12:51:45 PM	Jan Schneider	Comment #6 State ⇒ Resolved	Reply to this comment
Committed, thanks.

03/09/2007 12:48:13 PM	Jan Schneider	Deleted Original Message

03/09/2007 11:49:33 AM	wrobel (at) pardus (dot) de	Comment #5 New Attachment: framework-Kolab_Driver-split_20070309-2.patch	Reply to this comment
Ah, okay. I attached the corrected patch. require_once now loads IMAP.php and LDAP.php and package.xml has been modified accordingly. The Kolab_IMAP.php and Kolab_LDAP.php attached in the previous comments can then be used as IMAP.php and LDAP.php.

03/09/2007 11:27:05 AM	Jan Schneider	Comment #4 State ⇒ Feedback	Reply to this comment
The files should be put in Kolab/IMAP.php and Kolab/LDAP.php.

03/09/2007 08:31:18 AM	wrobel (at) pardus (dot) de	Comment #3 New Attachment: Kolab_LDAP.php	Reply to this comment
New LDAP class for the Kolab driver

03/09/2007 08:30:51 AM	wrobel (at) pardus (dot) de	Comment #2 New Attachment: Kolab_IMAP.php	Reply to this comment
New IMAP class for the Kolab driver.

03/09/2007 08:30:10 AM	wrobel (at) pardus (dot) de	Comment #1 Priority ⇒ 1. Low Type ⇒ Enhancement Summary ⇒ Splitting functionality in the Kolab driver Queue ⇒ Horde Framework Packages New Attachment: framework-Kolab_Driver-split_20070309.patch State ⇒ New	Reply to this comment
The current Kolab driver provides some common functionality that is shared by the specific Kolab drivers of the four groupware applications. The current structure has some problems though: It requires the specific Kolab drivers to directly access the XML modification routines. This way the specific drivers implement a lot more Kolab specific knowledge than they should and links them strongly to the main Kolab driver. We would like to decouple this and allow the specific Kolab drivers to simply operate on a hash that would then be loaded or saved via the main Kolab driver. The main Kolab driver would then handle the XML routines on its own. This is also necessary requirement in order to allow the main Kolab driver to cache the results, thus making data access significantly faster. The attached patch splits the Kolab driver and prepares it for the necessary changes. The Kolab driver retains all its functionality and this is only a structural change.