6.0.0-alpha12
6/12/25

[#4560] Autocomplete broken in IE6
Summary Autocomplete broken in IE6
Queue IMP
Queue Version 4.1.3
Type Bug
State Not A Bug
Priority 1. Low
Owners
Requester hospodarsky (at) gmail (dot) com
Created 10/26/2006 (6804 days ago)
Due
Updated 05/04/2008 (6248 days ago)
Assigned
Resolved 10/27/2006 (6803 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
05/04/2008 09:33:51 PM user (at) anonymous (dot) com Comment #7 Reply to this comment
just commenting the first line make it works on ie7

//document.imp_login.loginButton.disabled = true;

[Show Quoted Text - 17 lines]
10/27/2006 07:48:39 PM hospodarsky (at) gmail (dot) com Comment #6 Reply to this comment
But your code is breaking Auto Complete. Regardless of your or my 
opinions on the Safety/Good Idea of using Auto Complete, it isn't 
working because of code that was added to Imp's login.inc between 
versions 3.2.1 and 4.1.2 of Imp. (Actually, we know from the 
changelogs when you added that code in...but there wasn't much 
information on why it's there or what it does)



Anyway, you say that we can "comment out the code at our own risk"

But you don't offer what I consider to be an adequate solution, but 
instead offer reasons why we shouldn't want that functionality in the 
first  place (which is kind of an admission that it's broken, IMO, a 
bug) --- If I have users that want that functionality, and I, as 
system admin, am not turning it off, then shouldn't they have it if 
they want?



Again, regardless of the politics of Auto Complete, isn't the fact 
that the addition to your code breaks browser functionality a bug? And 
the removal of said piece of code makes it work again.  How is that 
not a bug?



If the code is necessary for certain other functionality, as you say 
in point 1, then maybe you should fix the broken code so people can 
make their own decisions about the rest.
10/27/2006 07:27:16 PM Michael Slusarz Comment #5 Reply to this comment
#1 - that code you commented is necessary for us to discover broken 
versions of IE.  So comment out at your own risk

#2 - in reality, disabling what you term "autocomplete" is a great 
thing.  Anyway, with the new autocomplete code in HEAD (and 4.2), 
autocomplete on IE would be terrible since you would essentially have 
2 competing popup windows.  And you *definitely* don't want IE 
autocomplete for any address fields - that is just a dumb idea (the 
last thing you need is to have someone's address pop up that has been 
changed in the addressbook in the meantime).



so, as jan mentioned, this isn't a bug.  Feel free to modify this to 
your heart's content on your setup.
10/27/2006 07:15:04 PM hospodarsky (at) gmail (dot) com Comment #4 Reply to this comment
Further update:

A quick check of other sites listed on your site, that also use Horde, 
shows that many sites are blocking this:



submit_login(e)    and their sites have the Auto Complete working.



Sites who do not modify or comment out submit_login(e)  do NOT prompt.




10/27/2006 06:49:27 PM hospodarsky (at) gmail (dot) com Comment #3 Reply to this comment
Here's an update on our investigation of this issue. We've commented

out the following lines in /impt/templates/login/login.inc:



//        document.imp_login.loginButton.disabled = true;

//<?php if (!empty($ie_clientcaps)): ?>

//        try {

//           
//document.imp_login.ie_version.valueobjCCaps.getComponentVersion("{89820200-ECBD-11CF-8B85-00AA005B4383}","componentid");

//        } catch (e) {

//        }

//<?php endif; ?>



Now autocomplete magically works.  We can leave our login.inc this way

to work around the issue, but would like to understand why this piece

of code causes IE's autocomplete to break.



Thanks
10/27/2006 05:22:14 PM Jan Schneider Comment #2
State ⇒ Not A Bug
Reply to this comment
This is a browser feature, not IMP's. And we didn't change anything to 
keep the browser from autocompleting.
10/26/2006 09:34:31 PM hospodarsky (at) gmail (dot) com Comment #1
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Autocomplete broken in IE6
Queue ⇒ IMP
State ⇒ Unconfirmed
Reply to this comment
With IE 6, AutoComplete doesn't seem to work using imp login. I've 
received several user complaints becasue we recently upgraded from imp 
3.2.1 to 4.1.2 and now 4.1.3.   Autocomplete does not work for either 
version of Imp.



I've checked CVS and don't see a newer login.inc to try.

Saved Queries