Actually I can't get bad newlines at all now with HEAD, even using the 
attached .eml file.

Adding an IMP 5 milestone.

That does seem reasonable to me.

FWIW, thunderbird sends the message identical to imp so this 
reinforces that this is not an imp issue.

Duplicate of 3565.  Essentially, when sending a message in text/plain 
format you lose the line break characters unless you specifically 
encode them.  And you don't encode these line break characters unless 
the browser specifically informs IMP we are dealing with binary data.



That being said, notepad is terrible and is probably the only editor 
out there that can not handle the different line breaks.



And that being said... (to other dev's): do we want to add code to 
view.php that will automatically convert linebreak characters when 
downloading, for text/* parts only, based on the OS obtained from the 
remote browser?

The downloaded test file.

I attach a message with a test plaintext file attached and the result 
of download this attached file.



Greetings.

You need to provide example files.

I see now that my last change shows OK the text(txt) files but brokens 
the PDF files.



Greetings.



Sebastián Calero.

If I receive a text file, created with notepad, and I click the link 
'Download ...'  and save it to disk. When I double click the text file 
and is opened again with notepad the line breaks are broken. I think 
the original <CR><LF> is now <LF> only.



The follow change in the file 'horde/imp/view.php' solves this:



case 'download_attach':

case 'download_render':

     switch ($actionID) {

     case 'download_attach':

         /* Make sure we get the entire contents of the part. */

         $mime = $contents->getDecodedMIMEPart($id, true);

     --  $body = $mime->getContents();

     ++ $body = $mime->getCanonicalContents();

         $type = $mime->getType(true);

         break;



Can this change cause some problem?



Greetings.





Sebastián Calero.