Tickets :: [#4034] Vacation messages don't declare encoding

6.0.0-RC7

6/27/26

History
Attachments
Comment
Watch
Download

Summary	Vacation messages don't declare encoding
Queue	Ingo
Queue Version	1.0.1
Type	Bug
State	Resolved
Priority	2. Medium
Owners	jan (at) horde (dot) org
Requester	alex (at) segv (dot) de
Created	6/13/06 (7319 days ago)
Due
Updated	2/28/07 (7059 days ago)
Assigned	6/21/06 (7311 days ago)
Resolved	2/28/07 (7059 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

255	Jan Schneider	Comment #8 Assigned to Jan Schneider Taken from Horde Developers State ⇒ Resolved	Reply to this comment
Implemented in CVS and Ingo 1.1.3.

284	julien (dot) savoie (at) usainteanne (dot) ca	Comment #7	Reply to this comment
this isn't a patch against ingo, but one against vacation-h3. Which still uses the vacation program from unix. Even makes less sense then to add it to this ticket. Alright fair enough, I misfiled it. My bad

273	Jan Schneider	Comment #6	Reply to this comment
this isn't a patch against ingo, but one against vacation-h3. Which still uses the vacation program from unix. Even makes less sense then to add it to this ticket.

573	Jan Schneider	Deleted Original Message

132	julien (dot) savoie (at) usainteanne (dot) ca	Comment #5	Reply to this comment
This patch isn't any better, it now hardcodes to iso-8859-1 and still doesn't build a valid mime message. That's silly... .vacation.msg's format is latin1. As as I know you can't encode it any differently there. If it's possible to embed a mime message into .vacation.msg let me know and I'll rewrite my patch. this isn't a patch against ingo, but one against vacation-h3. Which still uses the vacation program from unix.

1710	Jan Schneider	Comment #4	Reply to this comment
This patch isn't any better, it now hardcodes to iso-8859-1 and still doesn't build a valid mime message.

302	julien (dot) savoie (at) usainteanne (dot) ca	Comment #3 New Attachment: forwards.diff	Reply to this comment
We should create a proper MIME message instead, using 8bit transfer encoding is not a good idea. And your patch hardcodes utf-8, it should use NLS::getCharset() instead. Noticed this problem myself when updating the .vacation.msg files. UTF-8 site, plus latin1 requirement for a .vacation.msg... bad when people try to use french characters for example. Fix is easy enough

147	Jan Schneider	Comment #2 Assigned to Horde Developers State ⇒ Assigned	Reply to this comment
We should create a proper MIME message instead, using 8bit transfer encoding is not a good idea. And your patch hardcodes utf-8, it should use NLS::getCharset() instead.

324	alex (at) segv (dot) de	Comment #1 Priority ⇒ 2. Medium Type ⇒ Bug Summary ⇒ Vacation messages don't declare encoding Queue ⇒ Ingo New Attachment: vacation_encoding.patch State ⇒ Unconfirmed	Reply to this comment
When using the procmail backend of ingo the generated formail code for vacation messages doesn't declare the encoding of the mail. E.g. if you use german umlaute in the vacation mail, it is sent encoded in unicode but not declared as such. Some mailers like mutt assume the mail is encoded in ISO-8859-1 and will print garbage. Suggested fix: Add the headers: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit To the formail code. The attached patch does that.