Summary | smbldap backend - inheritance problem |
Queue | Passwd |
Queue Version | HEAD |
Type | Bug |
State | Resolved |
Priority | 2. Medium |
Owners | chuck (at) horde (dot) org |
Requester | lakka (at) users (dot) sourceforge (dot) net |
Created | 05/18/2006 (6965 days ago) |
Due | |
Updated | 05/25/2006 (6958 days ago) |
Assigned | 05/24/2006 (6959 days ago) |
Resolved | 05/25/2006 (6958 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
Taken from
Taken from Jan Schneider
State ⇒ Feedback
Nearly :-)
I suspect that this line:
$userdn = $this->_lookupdn($username, $old_password);
is not going to work because _lookupdn was removed at the same time as
the earlier changes
State ⇒ Resolved
Assigned to
State ⇒ Assigned
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ smbldap backend - inheritance problem
Queue ⇒ Passwd
State ⇒ Unconfirmed
$userdn = $this->_userDN($username, $old_password);
but there is no _userDN function in the class or its ancestors.
Digging around reveals that it was removed in version 1.44 of
Driver/ldap.php - see
http://cvs.horde.org/diff.php?r1=1.43&r2=1.44&f=passwd%2Flib%2FDriver%2Fldap.php
Looks like the code simplification was a bit overenthusiastic!
I am not sure what the best way to fix is. Maybe reintroduce _userDN
in the base class, or copy the old code to smbldap.php, but that would
involve a reasonable amount of hacking.