6.0.0-alpha12
6/12/25

[#3947] smbldap backend - inheritance problem
Summary smbldap backend - inheritance problem
Queue Passwd
Queue Version HEAD
Type Bug
State Resolved
Priority 2. Medium
Owners chuck (at) horde (dot) org
Requester lakka (at) users (dot) sourceforge (dot) net
Created 05/18/2006 (6965 days ago)
Due
Updated 05/25/2006 (6958 days ago)
Assigned 05/24/2006 (6959 days ago)
Resolved 05/25/2006 (6958 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
05/25/2006 11:10:20 AM Chuck Hagenbuch State ⇒ Resolved
 
05/25/2006 09:50:24 AM lakka (at) users (dot) sourceforge (dot) net Comment #5 Reply to this comment
My bad. How about now?
Looks good.  Thanks a lot.




05/24/2006 03:48:48 PM Chuck Hagenbuch Assigned to Chuck Hagenbuch
Taken from Horde DevelopersHorde Developers
Taken from Jan Schneider
 
05/24/2006 03:48:37 PM Chuck Hagenbuch Comment #4
State ⇒ Feedback
Reply to this comment
My bad. How about now?
05/24/2006 07:03:25 AM lakka (at) users (dot) sourceforge (dot) net Comment #3 Reply to this comment
Er ....



Nearly :-)



I suspect that this line:



$userdn = $this->_lookupdn($username, $old_password);



is not going to work because _lookupdn was removed at the same time as 
the earlier changes




05/24/2006 05:41:30 AM Chuck Hagenbuch Comment #2
State ⇒ Resolved
Reply to this comment
Fixed in CVS by inlining the _userDN code (for now, anyway).
05/18/2006 12:52:01 PM Jan Schneider Assigned to Jan Schneider
Assigned to Horde DevelopersHorde Developers
State ⇒ Assigned
 
05/18/2006 09:56:56 AM lakka (at) users (dot) sourceforge (dot) net Comment #1
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ smbldap backend - inheritance problem
Queue ⇒ Passwd
State ⇒ Unconfirmed
Reply to this comment
The smbldap backend is currently broken.  Line 54 of Driver/smbldap.php is:



$userdn = $this->_userDN($username, $old_password);



but there is no _userDN function in the class or its ancestors.   
Digging around reveals that it was removed in version 1.44 of 
Driver/ldap.php - see



http://cvs.horde.org/diff.php?r1=1.43&r2=1.44&f=passwd%2Flib%2FDriver%2Fldap.php



Looks like the code simplification was a bit overenthusiastic!



I am not sure what the best way to fix is.  Maybe reintroduce _userDN 
in the base class, or copy the old code to smbldap.php, but that would 
involve a reasonable amount of hacking.

Saved Queries