This is great. I did as you said, copied the prefs.php.dist to 
prefs.php, and all works great now. I did not have to patch anything.



It really helped me. Thank you very much.



Next time I will have to check the prefs.php.dist. Sorry for all the trouble.



P.V.Anthony

I just figured out why it wasn't working for me.  When I upgraded to 
horde 3.1.1/IMP 4.1.1, I had copied the new files over my old ones and 
went into the admin to regenerate the config files BUT I stupidly 
forgot that certain other files (prefs.php) aren't affected by the 
config in the admin.  Once I copied the new .dist files over the old 
ones, that fixed the issue and I didn't have to patch anything.



Hope that helps somebody.

I understand and respect that.
I want to follow the official patches. Please let me know which is the 
new patch and where to get it from. Will the patch work with 4.1.1?



I am using mysql for my preferences. I have looked in the horde_prefs 
table but could not find vinbox_id. Please let me know where to look 
so that I can delete the entries manually.



Thank you in advance

But it is *not* a correct patch.  It definitely will not be committed.



The patch listed below applied to IMP 4.1.2 fixes the behavior.  If it 
doesn't on your system, you need to manually remove all vinbox_id 
entries from your preferences backend.

I can also confirm that applying the Tuomas Silen patch to Search.php 
v1.37.10.30, the Show/Hide/Purge Deleted links come back.

I did try this patch but it did not work for me.



After adding the patch your mentioned then I added the patch by Tuomas 
Silen, then it worked well.

I got this error after upgrading to IMP 4.1.1. After applying the 
following patch the error is gone.



http://cvs.horde.org/diff.php/imp/lib/Search.php?r1=1.37.10.28&r2=1.37.10.29&ty=u

I got this patch from Tuomas Silen and it works great now.



Tuomas Silen changed the function isVINBOXFolder() in imp/lib/Search.php from



      function isVINBOXFolder($id = null)

      {

          $id = (is_null($id)) ? $this->_id : $this->_strip($id);

          return ($id == $GLOBALS['prefs']->getValue('vinbox_id'));

      }



to



      function isVINBOXFolder($id = null)

      {

          $id = (is_null($id)) ? $this->_id : $this->_strip($id);

          $vinbox_id = $GLOBALS['prefs']->getValue('vinbox_id');

          if (is_null($id) && empty($vinbox_id))

                 return false;

          return ($id == $vinbox_id);

      }

I have tried the patch mentioned below but unfortunately the problem remains.



Is there anything else I can try?



P.V.Anthony

Looking at this a bit more, this patch may also help:

http://lists.horde.org/archives/cvs/Week-of-Mon-20060410/056644.html

You will need to logout/login for the changes to mainfest themselves.

Actually, looking at this again, this is the only way the purge links 
will not show up (from the comment below):



This is because in isVINBOXFolder() (in lib/Search.php) $this->_id is 
null, because no searches are made and also

$GLOBALS['prefs']->getValue('vinbox_id') is empty.

(null == "") is true so this function returns true even for normal mailboxes.



As mentioned, this issue was already fixed in IMP 4.1.1.  vinbox_id 
was being set to the null value incorrectly.  This should no longer be 
happening.

I too am having the same problem after I have patched from 4.1 to 4.1.1.



On 4.1, I could at least see the "purge deleted" link.

This was already fixed in IMP 4.1.1 when we fixed the duplicate 
Virtual INBOX problem.

Right after logging in there are no show/hide deleted links even if you

have emails marked as deleted in your INBOX, if you had hide deleted 
enabled before upgrading to 4.x you don't have any links at all to 
show or purge the deleted messages.

(No threaded view, use_trash or use_vtrash are enabled).



This would seem to be because showDeleteLinks() (in lib/Mailbox.php) 
checks if $GLOBALS['imp_search']->isVINBOXFolder() returns false, but 
it never does at this point.



This is because in isVINBOXFolder() (in lib/Search.php) $this->_id is 
null, because no searches are made and also

$GLOBALS['prefs']->getValue('vinbox_id') is empty.

(null == "") is true so this function returns true even for normal mailboxes.



Because _showdelete won't be set if hide deleted is used, no links at 
all to either show deleted or purge deleted are shown. If no hide 
deleted was enabled then only purge deleted link is shown.



In the newest CVS whole showDeletedLinks is removed, but there is no 
corresponding change to mailbox.php yet to accommondate this. So the 
problem with the links will probably be solved. The problem with 
isVINBOXFolder() might, however, affect some other places too.



If I go to search page and just search for all emails in INBOX, then 
the links are shown as $this->_id won't be null.