Cleaned up and implemented in HEAD. Thanks!

Are you going to update the patch?

Good thinking, that makes sense. Some comments:

- this doesn't apply against latest CVS, can you make sure you have 
HEAD and re-generate the patch?



- you shouldn't set nicetitle attributes directly - set them as title=""



- you use $html for a few too many different things, I thought it was 
buggy; on second reading it looks like it isn't, but it's confusing. :)



- you need to either attach the voip-call.png image, or remove that 
part from the patch.



- _renderVarInput_phone should get the current body of 
_renderVarInput_cellphone, and _renderVarInput_cellphone should just 
call _renderVarInput_phone. If you think both should be replaced with 
_renderVarInput_text, I can see that, too, but then you should just 
remove both methods.



- you should check for errors from the registry call.

Here you go :-) I didn't remove / rename Horde_Form_Type_cellphone as 
cellphones

will also accept SMS messages. I modified Horde_Form_Type_cellphone to call

Horde_Form_Type_phone and to also add a link to the SMS engine (if 
some Horde app

provides SMS).



In Italy it's also possible to send SMS messages to "normal" phones, 
but nonetheless

I wouldn't remove this separation.

Are you going to update the patch according to Chuck's comments?

This doesn't look so bad to me actually in terms of specificness. Do 
you happen to know what API name ScopServ uses? And if it'd be 
appropriate to have a "standard" telephony api for Horde, or should 
there be a few API spaces for this functionality?



If you take out the icon, or put the icon into Hore, this is just fine 
in terms of being generic enough.



My only other suggestion for the patch is that you rename 
Horde_Form_Type_cellphone to Horde_Form_Type_phone and make use of 
that. Then for BC, of course, you'll want to put in stubs for 
Horde_Form_Type_cellphone that just call the _phone parent class.

Don't get this patch too serious - it's just an idea how things could work.



I have had to develop a VoIP web application based on Horde for a local

ISP. The whole system is very specific to fit our needs so please don't ask

me to immediatly publish the whole thing as OSS ;-)



Our infrastructure is a quite complex mixture of OpenSER, Asterisk, STUNd,

Mediaproxy and others - in my believes there is no one-size-fits-all VoIP

solution out there. Our setup will also never be a PBX (like ScopServ) but is

intended to be a comfortable and rock-solid SIP-Proxy - using Asterisk for

nothing but Voicemail, Conferences etc.



Things are running really fine here - I'll try to post ideas / patches / code

fragments useful for others too. This one is an example how phone support

could be added to Horde Renderers. I tried to keep it generic, but as you'll

see it's still very specific and bound to our application.



My application opens a little popup window which:

- tries to establish a call to the currently logged in Horde user's phone

- shows an error message if this call fails

- is able to realize if I respond the call and then

- tells me that it's now going to establish a call between my phone and the

   extension that has been clicked



Things stops here - as the whole thing is transaction statfull but not call

statfull I'm at the moment unable to find out if the final recipient has

answered and the call has been set up. Sure, I'm able to find it out - but

it's not that important right now, maybe I'll add such support later.



Just take this as a little inspiration, maybe one day there will be a cool

and powerful free Horde VoIP application...



Yours sincerly,

Thomas Gelf