Should be set now.

No, it really isn't - that way if you set the default to 5:00am, it'd 
show up as 5 mm.

Ah, actually, by just checking for null this doesn't work on a 
refresehed form. This is because on the refresh the time values are 
nothing ('') as per the option and this is then converted to zero.



Checking for empty values is a better option:



$this->_selectOptions($hours, (empty($time['hour'])) ? '' : 
sprintf('%02d', $time['hour'])),



&



$this->_selectOptions($minutes, (empty($time['minute'])) ? '' : 
sprintf('%02d', $time['minute'])),



If you want to get pedantic passing nothing ('') rather than null (as 
above) is also more technically correct isn't it?

Thx for the quick turn round. Minutes are fixed:



$this->_selectOptions($minutes, ($time['minute'] === null) ? null : 
sprintf('%02d', $time['minute'])),



But hours are not:



$this->_selectOptions($hours, sprintf('%02d', ($time['hour'] === null) 
? null : $time['hour'])),

Should be fixed in CVS.

If one simply creates an hourminutesecond input, but does not assign 
variables one would expect the inputs to appear with 2 drop downs, one 
with 'hh' selected, and the other 'mm'.



This isn't the case - '00' shows in both dropdowns.



Around line 362 of UI/VarRenderer/html.php we see this:



         $html = sprintf('<select name="%s[hour]" id="%s[hour]"%s>%s</select>',

                         $varname,

                         $varname,

                         $this->_selectOptions($hours, sprintf('%02d', 
$time['hour'])),

                         $this->_getActionScripts($form, $var));



The sprintf of $time['hour'] is causing a blank value of hour to be 
converted to '00' and hence 'hh' (represented in the dropdown by 
blank) is never shown).



Minutes are affected in the same way.