| Summary | Custom folder icons not shown in sidebar [patch] |
| Queue | IMP |
| Queue Version | 4.0.4 |
| Type | Bug |
| State | Resolved |
| Priority | 1. Low |
| Owners | |
| Requester | okuhl (at) netcologne (dot) de |
| Created | 12/13/2005 (7116 days ago) |
| Due | |
| Updated | 01/12/2006 (7086 days ago) |
| Assigned | 12/13/2005 (7116 days ago) |
| Resolved | 01/12/2006 (7086 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | |
| Patch | No |
State ⇒ Resolved
to backport the solution to 4.1, then to find a temporary hack.
http://lists.horde.org/archives/cvs/Week-of-Mon-20051219/052302.html
If someone would like to backport this to 4.1, that would be great.
If not, then we should probably close this bug.
1) I don't think Chucks patch will work, because the first thing I did
was adding the hook call to tree_folders.php and it didn't. This is
because folders.php need the complete <img>-code and tree_folders.php
simply the filename.
Because I don't have a HEAD installation running, can someone confirm
that there is still a problem? Then I will improve my patches and
upload them again.
4) I changed the hook examples because the old one won't work with the
new code.
5) Those are used in folders.php. I could remove the 'alt' tag and
replace it with a default description like _("Mailbox").
State ⇒ Feedback
something yesterday or two days ago.
2) The upgrading instructions should go to IMP, because IMP is
breaking bc in expecting a different return value from the hook.
3) We already added a spam folder icon to HEAD that is always used now.
4) AFAICS you merged the two examples in hooks.php.dist, why?
5) Don't set unnecessary image attributes in the hooks code.
Hm, now looking at the patches again, and what Chuck committed, the
icons will probably work already if you replace $dir2 with
$mbox_icons in tree_folders.php.
New Attachment: spam.png
New Attachment: hooks.php.dist.patch
New Attachment: folders.php.patch
New Attachment: tree_folders.php.patch
New Attachment: UPGRADING.patch
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Custom folder icons not shown in sidebar [patch]
Queue ⇒ IMP
State ⇒ Unconfirmed
imp's folder view, but not in the menu to the left.
Here are the patches for a working version, but bc is broken, because
the hook's return values changed. I added a comment to UPGRADING in
horde. Maybe there should be something in imp? Problem is that the
patches affect horde and imp.
I also added a spam folder icon for the example in hooks.php.dist to
work fine and besides hope that my changes in hooks.php.dist to the
kolab example are ok - I cannot test this.
Regards,
Ollie.