5.2.0-git
04/17/2014

[#3123] select (enum) fields get no name - config generator broken
Summary select (enum) fields get no name - config generator broken
Queue Horde Framework Packages
Queue Version HEAD
Type Bug
State Resolved
Priority 3. High
Owners Horde Developers (at)
Requester thijs (at) balpol (dot) tudelft (dot) nl
Created 12/12/2005 (3048 days ago)
Due
Updated 12/24/2005 (3036 days ago)
Assigned 12/13/2005 (3047 days ago)
Resolved 12/14/2005 (3046 days ago)
Milestone
Patch No

History
12/24/2005 08:52:16 PM tkess (at) icg (dot) us Comment #8 Reply to this comment
I have been having the same problem with 3.0.9 and it appears you have 
already implemented the change.  Are there any further patches.
12/14/2005 08:21:57 PM Chuck Hagenbuch Comment #7
State ⇒ Resolved
Reply to this comment
Yup, thanks. Looks like this is it; I'm resolving and will roll 3.0.9.
12/14/2005 08:20:31 PM simon (at) tachyon (dot) net Comment #6 Reply to this comment
This patch works for me. I had the same problem that has been 
described: Unable to save Horde config. I applied the patch to 
lib/Horde/UI/VarRenderer/html.php and everything started working just 
fine.



...thought you might like to have input from one more source.



Tx.
12/14/2005 11:33:49 AM johnny (at) centos (dot) org Comment #5 Reply to this comment
I can verify that this is an issue and that the proposed patch fixes 
it for me.  I do not see any other issues after patching.



I am rolling the patch into a bugfix update for the CentOS generated RPMS.
12/13/2005 08:53:29 PM Chuck Hagenbuch Comment #4
State ⇒ Feedback
Reply to this comment
And it also breaks all other enum fields. Like the charset menu when
composing e-mail, etc.
That menu has nothing to do with Horde_Form and doesn't use 
VarRenderer independently, though. Are you sure that was broken? And 
if so, does the patch really fix it?



I have the fix committed and will roll 3.0.9 as soon as this is 
confirmed. Are there any problems anyone is seeing with 3.0.8 that are 
NOT fixed by applying this patch:



http://cvs.horde.org/diff.php/framework/UI/UI/VarRenderer/html.php?r1=1.98.2.12.2.1&r2=1.98.2.12.2.2&ty=u



Thanks,

-chuck
12/13/2005 08:50:18 PM Chuck Hagenbuch State ⇒ Assigned
Assigned to Horde DevelopersHorde Developers
 
12/13/2005 10:48:56 AM chutz (at) gg3 (dot) net Comment #3 Reply to this comment
And it also breaks all other enum fields. Like the charset menu when 
composing e-mail, etc.



I can confirm that the attached patch fixes both observed problems.
12/12/2005 02:50:37 PM daniel (at) caret (dot) cam (dot) ac (dot) uk Comment #2 Reply to this comment
I can confirm this is happening!

Platform: Fedora Core 3.

Php version: 4.3.10.

Php buildline: --with-mysql --with-dom --with-zlib --with-xml 
--with-apxs2=/usr/local/apache2/bin/apxs 
--prefix=/usr/local/php-apache2 --with-pg

sql --with-ldap --with-mcrypt --with-gd --with-jpeg-dir=/usr 
--with-gettext --with-iconv --enable-mbstring --with-mbstring=all 
--with-pear --with-openssl --with-imap --with-mcal --with-kerberos 
--with-imap-ssl

Apache version: 2.0.55

I can't believe this bug got through release testing! It really does 
break the configurator horribly ( ; _ ; )
12/12/2005 08:59:25 AM thijs (at) balpol (dot) tudelft (dot) nl Comment #1
State ⇒ Unconfirmed
New Attachment: html.php.patch Download
Queue ⇒ Horde Framework Packages
Summary ⇒ select (enum) fields get no name - config generator broken
Type ⇒ Bug
Priority ⇒ 3. High
Reply to this comment
It seems there's a problem in UI/VarRenderer/html.php in the 3.0.8 
framework that causes select fields to have no name (name=""), which 
breaks the config generator with "There was an error in the 
configuration form. Perhaps you left out a required field."



I've included a patch.

(replace $varname with $var->getVarName())