6.0.0-beta1
7/10/25

[#3090] Tracking bug for XHTML cleanup
Summary Tracking bug for XHTML cleanup
Queue Horde Base
Queue Version HEAD
Type Bug
State Resolved
Priority 1. Low
Owners Horde Developers (at) , chuck (at) horde (dot) org
Requester kevin_myer (at) iu13 (dot) org
Created 12/05/2005 (7157 days ago)
Due
Updated 05/22/2006 (6989 days ago)
Assigned 12/21/2005 (7141 days ago)
Resolved 05/22/2006 (6989 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
05/22/2006 06:22:24 PM Chuck Hagenbuch Comment #31
State ⇒ Resolved
Reply to this comment
I've fixed all issues in this ticket that are reasonably resolvable 
(i.e, not the xml-id syntax for now) and that I can reproduce. I'm 
closing it as it's gotten rather unwieldy; please create individual 
tickets for other significant issues.
05/20/2006 02:47:36 AM Chuck Hagenbuch Deleted Original Message
 
05/19/2006 10:00:39 PM Chuck Hagenbuch Deleted Original Message
 
05/19/2006 10:00:34 PM Chuck Hagenbuch Deleted Original Message
 
05/19/2006 09:59:58 PM Chuck Hagenbuch Deleted Original Message
 
05/19/2006 09:59:21 PM Chuck Hagenbuch Deleted Original Message
 
05/18/2006 08:55:25 PM Chuck Hagenbuch Assigned to Chuck Hagenbuch
 
12/30/2005 12:04:40 AM Matt Selsky Comment #30 Reply to this comment
External URLs in Wicked are generated as <a 
href="http://wiki.horde.org/horde/services/go.php?url=http%3A%2F%2Fwww.horde.org%2Fpapers%2Ffosdem2005%2F" target=" target="_blank title="http://www.horde.org/papers/fosdem2005/">http://www.horde.org/papers/fosdem2005/</a>.  Notice the target=" 
target="_blank
12/29/2005 11:50:06 PM Matt Selsky Comment #29 Reply to this comment
Empty span on http://wiki.horde.org/RecentChanges?referrer=WikiHome 
due to logic in wicked/templates/display/title.inc
12/29/2005 03:32:56 AM Matt Selsky Comment #28 Reply to this comment
Small input close for block collection...
Committed.
12/29/2005 03:16:55 AM kevin_myer (at) iu13 (dot) org Comment #27
New Attachment: xhtml-framework-block.patch
Reply to this comment
Small input close for block collection...
12/28/2005 11:51:24 PM kevin_myer (at) iu13 (dot) org Comment #26
New Attachment: xhtml-imp-fetchmail.patch
Reply to this comment
IMP fetchmail initial maintenance task cleanups.  I'm not sure if my 
placement of the htmlspecialchars is correct.
12/25/2005 07:16:29 PM Chuck Hagenbuch Queue ⇒ Horde Base
Version ⇒ HEAD
 
12/22/2005 10:22:08 PM Chuck Hagenbuch Deleted Original Message
 
12/22/2005 08:08:12 PM kevin_myer (at) iu13 (dot) org Comment #25 Reply to this comment
Kronolith -> New Event has several tags with invalid id attributes.
Also there are input tags inside tables.
There are a number of places that I saw that had the invalid id 
attributes (with pseudo-XML syntax), including this one.  I wasn't 
sure what to do with them, but if you let me know, I'll track them 
down and modify accordingly.


12/22/2005 07:59:33 PM Matt Selsky Comment #24 Reply to this comment
Kronolith -> New Event has several tags with invalid id attributes.   
Also there are input tags inside tables.
12/22/2005 07:41:05 PM Matt Selsky Comment #23 Reply to this comment
I took the easy route for the spelling page and used the inline style.
12/22/2005 07:10:57 PM Chuck Hagenbuch Deleted Original Message
 
12/22/2005 03:46:57 AM Chuck Hagenbuch Comment #22 Reply to this comment
On the spell check complete page:

<span class="fixed"><pre>Happy holidays</pre></span>

pre is not permitted inside a span.  What is the correct fix?
Several possibilities; one is completely throwing out the existing 
spell checker and using the one from DIMP, one is using 
Text::htmlAllSpaces() instead of the pre, and another is using <span 
style="white-space:pre"> or some such.
12/22/2005 03:28:00 AM Chuck Hagenbuch Deleted Original Message
 
12/22/2005 03:27:32 AM Matt Selsky Comment #21 Reply to this comment
xhtml-mnemo.patch has been committed.
12/22/2005 03:17:11 AM Matt Selsky Comment #20 Reply to this comment
Mnemo -> My Notepads: The cancel button doesn't encode the parameter 
separators (& should be &amp;)
12/22/2005 02:58:46 AM Chuck Hagenbuch Deleted Original Message
 
12/22/2005 02:58:36 AM Chuck Hagenbuch Deleted Original Message
 
12/22/2005 02:57:51 AM Matt Selsky Comment #19 Reply to this comment
IMP ACL and S/MIME fixes committed with slight tweaks.
12/22/2005 02:49:02 AM Chuck Hagenbuch Deleted Original Message
 
12/22/2005 02:48:51 AM Chuck Hagenbuch Deleted Original Message
 
12/22/2005 02:48:35 AM Chuck Hagenbuch Deleted Original Message
 
12/22/2005 02:46:10 AM Matt Selsky Comment #18 Reply to this comment
On the spell check complete page:



<span class="fixed"><pre>Happy holidays</pre></span>



pre is not permitted inside a span.  What is the correct fix?
12/22/2005 12:34:55 AM Matt Selsky Comment #17 Reply to this comment
Ingo portion committed with slight tweaks.  Thanks.
12/21/2005 05:01:14 PM Chuck Hagenbuch State ⇒ Assigned
Assigned to Horde DevelopersHorde Developers
 
12/21/2005 01:02:16 AM kevin_myer (at) iu13 (dot) org Comment #16 Reply to this comment
The options screen for Remote Servers (services/portal/rpcsum.php) 
which includes templates/rpcsum/rpcsum.inc, also has some errors.   
From CVS, it looks like they have been there for awhile and I'm not 
exactly sure what formatting is intended to be there :)
12/13/2005 03:33:45 AM kevin_myer (at) iu13 (dot) org Comment #15
New Attachment: xhtml-kronolith-search.patch
Reply to this comment
Kronolith search cleanups
12/13/2005 03:06:24 AM kevin_myer (at) iu13 (dot) org Comment #14
New Attachment: xhtml-remotecal-kronolith.patch
Reply to this comment
Closing tags
12/12/2005 04:32:18 AM kevin_myer (at) iu13 (dot) org Comment #13
New Attachment: xhtml-mnemo.patch
Reply to this comment
Nit for nemo (proper syntax for names)
12/12/2005 04:17:33 AM kevin_myer (at) iu13 (dot) org Comment #12
New Attachment: xhtml-ingo[2].patch
Reply to this comment
Spurious tag cleanups, drop px from width tags, close input tags
Try again, without actually having the file open in vi...
12/12/2005 04:16:00 AM kevin_myer (at) iu13 (dot) org Comment #11
New Attachment: xhtml-ingo[1].patch
Reply to this comment
Spurious tag cleanups, drop px from width tags, close input tags
12/12/2005 04:15:53 AM kevin_myer (at) iu13 (dot) org Comment #10
New Attachment: xhtml-ingo.patch
Reply to this comment
Spurious tag cleanups, drop px from width tags, close input tags
12/12/2005 03:49:44 AM kevin_myer (at) iu13 (dot) org Comment #9
New Attachment: xhtml-imp-smime.patch
Reply to this comment
Missing </div> on S/MIME pref screen.
12/12/2005 03:35:15 AM kevin_myer (at) iu13 (dot) org Comment #8
New Attachment: xhtml-imp-abookselect[1].patch
Reply to this comment
Not too sure about this one.  If a browser doesn't support
javascript, these links will break, so its not recommended to use
links in this manner.  But as it is, they do nothing anyway, if your
browser doesn't support javascript.  But if a browser doesn't support
javascript, you wouldn't be able to select address books either..
Whoops - widths shouldn't have been px...
12/12/2005 03:31:33 AM kevin_myer (at) iu13 (dot) org Comment #7
New Attachment: xhtml-imp-abookselect.patch
Reply to this comment
Not too sure about this one.  If a browser doesn't support javascript, 
these links will break, so its not recommended to use links in this 
manner.  But as it is, they do nothing anyway, if your browser doesn't 
support javascript.  But if a browser doesn't support javascript, you 
wouldn't be able to select address books either..
12/12/2005 03:20:08 AM kevin_myer (at) iu13 (dot) org Comment #6
New Attachment: xhtml-imp-acl.patch
Reply to this comment
Reorder input elements in ACL table.
12/12/2005 02:49:45 AM kevin_myer (at) iu13 (dot) org Comment #5 Reply to this comment
Not sure how to handle page loads that currently have duplicate <a> 
names..  Example would be any page that includes a file at both top 
and bottom (usually navigational in nature), usually results in 
duplicate prev and next <a> names.



Also, is there a way to push <!--a75c305b1c0a6022--><link> elements to 
the header of a page?  On the portal page, many of the blocks contain 
CSS <!--a75c305b1c0a6022--><link> elements, which should be in the 
header.  But it looks like the header is static.
12/12/2005 02:43:45 AM kevin_myer (at) iu13 (dot) org Comment #4
New Attachment: xhtml-sidebar.patch
Reply to this comment
Unused <div> in sidebar.
12/05/2005 03:41:55 AM Chuck Hagenbuch Deleted Original Message
 
12/05/2005 03:41:50 AM Chuck Hagenbuch Deleted Original Message
 
12/05/2005 03:41:42 AM Chuck Hagenbuch Comment #3
State ⇒
Reply to this comment
Both fixed, thanks. I took a different approach and only output the 
menu if it wasn't empty, since even though menu.php.dist isn't there, 
you could put one there.
12/05/2005 02:41:34 AM kevin_myer (at) iu13 (dot) org Comment #2
New Attachment: xhtml-weatherdotcom.patch
Reply to this comment
weatherdotcom cleanups
12/05/2005 02:41:07 AM kevin_myer (at) iu13 (dot) org Comment #1
Priority ⇒ 1. Low
State ⇒ Unconfirmed
New Attachment: xhtml-horde-login.patch
Queue ⇒ Horde Framework Packages
Summary ⇒ Tracking bug for XHTML cleanup
Type ⇒ Bug
Reply to this comment
On the login.php patch, the span I removed doesn't seem to ever be 
used.  I var_dump'ed $menu and it always seems to be pointing to 
horde/config/menu.php (which doesn't exist, nor does menu.php.dist).   
But maybe it is used somewhere else?




Saved Queries