6.0.0-beta1
7/9/25

[#3076] show log info when hovering a revision in the annotate screen
Summary show log info when hovering a revision in the annotate screen
Queue Chora
Queue Version HEAD
Type Enhancement
State Resolved
Priority 2. Medium
Owners Horde Developers (at)
Requester robzilla (at) siklos (dot) ca
Created 12/01/2005 (7160 days ago)
Due
Updated 03/05/2006 (7066 days ago)
Assigned 01/03/2006 (7127 days ago)
Resolved 03/05/2006 (7066 days ago)
Milestone
Patch No

History
03/05/2006 03:49:34 AM Chuck Hagenbuch Comment #10
State ⇒ Resolved
Reply to this comment
I cleaned things up a bit, but it looked pretty good. We did put you 
through a lot of revisions. :) In general it'd be great if you took a 
quick look at the differences between what you had and what I 
committed and at horde/docs/CODING_STANDARDS. Mainly we don't use # 
for comments, but a few spacing things as well. But all minor.



Thanks!
03/05/2006 02:47:36 AM Chuck Hagenbuch Deleted Original Message
 
01/03/2006 10:35:32 PM Jan Schneider Assigned to Horde DevelopersHorde Developers
State ⇒ Assigned
 
01/03/2006 07:12:33 PM robzilla (at) siklos (dot) ca Comment #9
New Attachment: 3076-v5.patch Download
Reply to this comment
Ok, this patch should be good to go.



I put all the nasty JavaScript in chora/templates/annotate/footer.inc 
(instead of header.inc), since it depends on some php variables that 
get defined after header.inc is sourced.



I know the JS is ugly - I tried to make it as readable as possible, 
but if anyone has any suggestions on cleaning it up, I'd be happy to 
make changes.
12/27/2005 04:07:40 PM Jan Schneider Deleted Original Message
 
12/27/2005 04:07:31 PM Jan Schneider Deleted Original Message
 
12/27/2005 04:06:04 PM Jan Schneider Comment #8 Reply to this comment
1) Where should all the JS code that I put in annotate.php ?
Put it into chora/templates/annotate/header.inc
2) What to do about the "unclickable url-in-the-toolip" issue?
Don't create them. This would reduce the payload even more.
12/05/2005 06:36:50 PM robzilla (at) siklos (dot) ca Comment #7
New Attachment: 3076-v4.patch
Reply to this comment
Here's a patch that's complete, as far as I can tell.



However it's not ready to go.  Here's what I still don't know:

1) Where should all the JS code that I put in annotate.php ?

2) What to do about the "unclickable url-in-the-toolip" issue?



Thanks.
12/02/2005 08:59:35 PM robzilla (at) siklos (dot) ca Comment #6
New Attachment: 3076-v3.patch
Reply to this comment
Ok, here's another patch, It's not polished (by a long shot), but I 
just want to make sure I'm on the right track.



I think I'm doing everything right, except there is still no way to 
click on a link in the tooltip, and I don't know how to fix this 
(separate bug?)



Also, I'm not sure how to implement the EventCache::remove() function 
in horde.js - can anyone help me with this?  Because I haven't 
implemented this, my patch won't work with IE (but it works fine with 
Mozilla and the like)
12/02/2005 09:45:09 AM Jan Schneider Comment #5 Reply to this comment
Much better, but please take a short ride through docs/TRANSLATION and 
watch out especially for quotes, xhtml, and horizontal whitespace.



And there is still a major concern regarding page size. This patch 
adds the complete changelog message (including markup) for *every* 
line of the code which could easily double the page size, if not more.

A solution would be to not add the title to each revision link, but 
create some fancy javascript that is called onload, that goes through 
all revision links and sets the titles from a js array with all 
changelog messages, indexed by revision.
12/02/2005 03:33:21 AM Chuck Hagenbuch Deleted Original Message
 
12/02/2005 01:51:38 AM robzilla (at) siklos (dot) ca Comment #4
New Attachment: 3076-v2.patch
Reply to this comment
ok, disregard my last comment - i found everything I needed.  Sooo 
nice to have such a handy framework with all this stuff already coded.



However, I still have doubts:

1) if the cvs log message contains a link to the bug tracking system, 
that link is not clickable (since when you move your mouse to click on 
it, the tooltip will disappear)



2) I'm not sure if the code that calls the tooltip function belongs in 
the script or the template.





** new patch - 3076-v2.patch **


12/02/2005 01:16:22 AM robzilla (at) siklos (dot) ca Comment #3 Reply to this comment
You should use the link title/tooltip code from CVS instead
Can you tell me where to find this code, or better yet, point me to an 
example of it somewhere in existing code?


12/01/2005 10:37:47 PM Jan Schneider Comment #2
State ⇒ Feedback
Reply to this comment
The idea is very nice, but the implementation is awful! ;-)



You should use the link title/tooltip code from CVS instead, and 
create the necessary title attributes on page load.
12/01/2005 10:24:14 PM robzilla (at) siklos (dot) ca Comment #1
Priority ⇒ 2. Medium
Type ⇒ Enhancement
Summary ⇒ show log info when hovering a revision in the annotate screen
Queue ⇒ Chora
New Attachment: logmsg.patch
State ⇒ New
Reply to this comment
When viewing the annotation of a file, it is very helpful to know what 
the log message is for the various revisions that appear.



When hovering the mouse over a revision in the annotation screen, a 
box should appear showing the log message (plus other info).



** Patch attached **

Saved Queries