Summary | show log info when hovering a revision in the annotate screen |
Queue | Chora |
Queue Version | HEAD |
Type | Enhancement |
State | Resolved |
Priority | 2. Medium |
Owners | Horde Developers (at) |
Requester | robzilla (at) siklos (dot) ca |
Created | 12/01/2005 (7160 days ago) |
Due | |
Updated | 03/05/2006 (7066 days ago) |
Assigned | 01/03/2006 (7127 days ago) |
Resolved | 03/05/2006 (7066 days ago) |
Milestone | |
Patch | No |
State ⇒ Resolved
through a lot of revisions. :) In general it'd be great if you took a
quick look at the differences between what you had and what I
committed and at horde/docs/CODING_STANDARDS. Mainly we don't use #
for comments, but a few spacing things as well. But all minor.
Thanks!
State ⇒ Assigned
New Attachment: 3076-v5.patch
I put all the nasty JavaScript in chora/templates/annotate/footer.inc
(instead of header.inc), since it depends on some php variables that
get defined after header.inc is sourced.
I know the JS is ugly - I tried to make it as readable as possible,
but if anyone has any suggestions on cleaning it up, I'd be happy to
make changes.
New Attachment: 3076-v4.patch
However it's not ready to go. Here's what I still don't know:
1) Where should all the JS code that I put in annotate.php ?
2) What to do about the "unclickable url-in-the-toolip" issue?
Thanks.
New Attachment: 3076-v3.patch
just want to make sure I'm on the right track.
I think I'm doing everything right, except there is still no way to
click on a link in the tooltip, and I don't know how to fix this
(separate bug?)
Also, I'm not sure how to implement the EventCache::remove() function
in horde.js - can anyone help me with this? Because I haven't
implemented this, my patch won't work with IE (but it works fine with
Mozilla and the like)
watch out especially for quotes, xhtml, and horizontal whitespace.
And there is still a major concern regarding page size. This patch
adds the complete changelog message (including markup) for *every*
line of the code which could easily double the page size, if not more.
A solution would be to not add the title to each revision link, but
create some fancy javascript that is called onload, that goes through
all revision links and sets the titles from a js array with all
changelog messages, indexed by revision.
New Attachment: 3076-v2.patch
nice to have such a handy framework with all this stuff already coded.
However, I still have doubts:
1) if the cvs log message contains a link to the bug tracking system,
that link is not clickable (since when you move your mouse to click on
it, the tooltip will disappear)
2) I'm not sure if the code that calls the tooltip function belongs in
the script or the template.
** new patch - 3076-v2.patch **
example of it somewhere in existing code?
State ⇒ Feedback
You should use the link title/tooltip code from CVS instead, and
create the necessary title attributes on page load.
Priority ⇒ 2. Medium
Type ⇒ Enhancement
Summary ⇒ show log info when hovering a revision in the annotate screen
Queue ⇒ Chora
New Attachment: logmsg.patch
State ⇒ New
the log message is for the various revisions that appear.
When hovering the mouse over a revision in the annotation screen, a
box should appear showing the log message (plus other info).
** Patch attached **