6.0.0-beta1
8/8/25

[#3033] Better default addressbook listing
Summary Better default addressbook listing
Queue Turba
Queue Version 2.0.4
Type Enhancement
State Resolved
Priority 1. Low
Owners
Requester tr (at) erdfunkstelle (dot) de
Created 11/24/2005 (7197 days ago)
Due
Updated 12/08/2005 (7183 days ago)
Assigned
Resolved 12/07/2005 (7184 days ago)
Milestone
Patch No

History
12/08/2005 08:18:02 AM Jan Schneider Comment #10 Reply to this comment
...and while we're at it, how about using the existing pref for
maximum number of entries per page to determine when to do the alpha
page instead of hard coding the current limit of 10?
Yes, we should use that.
12/08/2005 08:15:41 AM Jan Schneider Comment #9 Reply to this comment
Should we add a user option to allow them to choose which page to
default to? (See Ticket: 855)
I think this would be unnecessary overhead. How many users will choose 
something different than "A"?
12/07/2005 11:23:09 PM Michael Rubinsky Comment #8 Reply to this comment
Should we add a user option to allow them to choose which page to
default to? (See Ticket: 855)
...and while we're at it, how about using the existing pref for 
maximum number of entries per page to determine when to do the alpha 
page instead of hard coding the current limit of 10?


12/07/2005 11:19:40 PM Michael Rubinsky Comment #7
State ⇒ Resolved
Reply to this comment
Now if you could make a patch against CVS HEAD (which is where we
only accept enhancements for), that would be perfect.
I updated this for use in HEAD and commited.



Should we add a user option to allow them to choose which page to 
default to? (See Ticket: 855)


11/28/2005 04:49:43 PM Jan Schneider Comment #6 Reply to this comment
Now if you could make a patch against CVS HEAD (which is where we only 
accept enhancements for), that would be perfect.
11/25/2005 06:55:01 PM Chuck Hagenbuch Deleted Original Message
 
11/25/2005 11:01:19 AM tr (at) erdfunkstelle (dot) de Comment #5
New Attachment: list2.diff Download
Reply to this comment
Here comes a new patch, which covers the problems mentioned previously.

If someone has a better solution to distinct between showing a 
list-view and their contents, please comment on it :)



bye,

thomas
11/24/2005 01:55:12 PM tr (at) erdfunkstelle (dot) de Comment #4 Reply to this comment

[Show Quoted Text - 14 lines]
Hm, sorry for the noise, but now i see some not so fine side effects 
of the proposed changes:



- clicking on "show lists" show only lists beginning with "A" unless 
the users chooses "all" afterwards

- after this, clicking on a list to show their content has the same 
result, only listmembers beginning with "A" are beeing displayed :(



So some more work has to be spent on this issue, my and jans proposed 
solution does fix the inital wish, but raises 2 new issues ;-(



Bye,

Thomas
11/24/2005 01:31:01 PM tr (at) erdfunkstelle (dot) de Comment #3 Reply to this comment
Funny, I did this for a customer not long ago, who experienced the
same problem. Maybe we should make this the default?

It's much easier btw., (from my head) just replace:
$page = Util::getFormData('page', '*');
with:
$page = Util::getFormData('page', 'A');
and drop all the other changes.
Yes, i would propose this as the default.

I just tested your above changes and it does exactly what i want it to do :)



If no one objects, i would like to see the above in the next release 
of turba :)



Bye,

Thomas Reitelbach
11/24/2005 01:20:29 PM Jan Schneider Comment #2
State ⇒ Feedback
Reply to this comment
Funny, I did this for a customer not long ago, who experienced the 
same problem. Maybe we should make this the default?



It's much easier btw., (from my head) just replace:

$page = Util::getFormData('page', '*');

with:

$page = Util::getFormData('page', 'A');

and drop all the other changes.
11/24/2005 12:49:26 PM tr (at) erdfunkstelle (dot) de Comment #1
Priority ⇒ 1. Low
Type ⇒ Enhancement
Summary ⇒ Better default addressbook listing
Queue ⇒ Turba
New Attachment: list.diff
State ⇒ New
Reply to this comment
I hope this is the correct way to submit a little patch for turba.



I am not satisfied with the way how turba displays the addressbook 
listing. When one has many addressbook entries (let's say several 
hundred), and the default view is set to "list" instead of "search", 
then _all_ addressbook objects are beeing displayed, which can take 
very long. unfortunately there seems to be no way to disable this 
behaviour.



As a result i created the attached little patch. After applying the 
patch to Turba, the default addressbook listing is page "A" instead of 
"all", which takes less time, since the max length for individual 
pages can be configured (for me max. 50 entries per page).



This is my very first patch for turba, so i ask someone to review it, 
even if it's a very minimal patch.



bye,

thomas

Saved Queries