Summary | Will not import PGP private key |
Queue | IMP |
Queue Version | HEAD |
Type | Bug |
State | Resolved |
Priority | 2. Medium |
Owners | slusarz (at) horde (dot) org |
Requester | dan (at) familybrown (dot) org |
Created | 06/10/2004 (7646 days ago) |
Due | |
Updated | 10/13/2004 (7521 days ago) |
Assigned | 06/15/2004 (7641 days ago) |
Resolved | 10/13/2004 (7521 days ago) |
Milestone | |
Patch | No |
State ⇒ Resolved
the import window to prevent confusion in the future.
key. Obviously, I didn't carefully read that screen; I was somewhat
aided in my misunderstanding by the "Import Keypair" button and my
(apparently incorrect) understanding that the "private key block"
contained both keys.
To possibly help alleviate this confusion in the future, any chance
the process could be changed to a single step, with one form that has
two text area fields, one for the private key and one for the public?
It would probably require a larger window, but it would make it pretty
obvious that it needs two separate inputs (and save a click in the
process, too). Just a thought. Thanks for the help on this!
you are pasting *both* your public and private key at the same time.
If this is the case, this is completely incorrect. The first screen
is for the public key *only*. The second screen is for the private
key *only*. There should be a different key entered for both screens.
output, at least that I could see, from the print_r command (and I
looked in the source for the pop-up window to make sure, as well as
the system log), and it appeared to behave in the same way. However,
something very interesting (to me, anyway) happened. I clicked on
Import Keypair from the PGP options screen, which opened the pop-up
window. I pasted the key in there and clicked Import, and it
refreshed and showed "PGP Public Key Imported Successfully" at the
top--the same as it had done before. Then, just out of curiousity, I
tried pasting the same thing in again, and clicking on Import again.
Surprise! The pop-up window closed, and the PGP options screen
reloaded. "PGP private key successfully added" appeared as a banner
at the top of the options screen, and that appears to be the case.
So, it would seem that I need to import the key twice in a row to get
it to work. Seems odd.
correctly, a change I just made to CVS.
imp/pgp.php. Now reads like this, in relevant part:
} else {
foreach ($key_info['signature'] as $sig) {
$notification->push(sprintf(_("PGP Public Key for
\"%s (%s)\" w$
}
print_r($prefs->getValue('pgp_public_key'));
_reloadWindow();
}
Now when I click the Import Keypair button from the PGP options
screen, the new window pops up with a dark blue background and nothing
else. The source to that window ends with:
<body>
<!--a75c305b1c0a6022--><form enctype="multipart/form-data"
method="post" name="import_pgp_key" action="/test/newhorde/imp/pgp.php">
When this happens, there's the following error logged in the system log:
Sep 29 06:42:14 e-smith httpd: PHP Fatal error: Call to a member
function on a non-object in
/home/e-smith/files/ibays/Primary/html/test/newhorde/imp/templates/pgp/import_key.inc on line
2
imp/templates/pgp/import_key.inc?
If not, could you add this line to pgp.php on line 159:
print_r($prefs->getValue('pgp_public_key'));
and let me know what it outputs?
updated within the last half hour, and framework updated from there.
Here's what I'm doing to try to get it to import:
* Log in to horde (using application/imp authentication).
* Click on Mail in the sidebar.
* Click on Options at the top.
* Click on PGP Options.
* Click on Import Keypair.
- A new window pops up, titled "Mail :: Import PGP Key"
* Paste keypair (below) in the "Insert Key Here" field.
* Click Import Key
- Window refreshes, "Insert Key Here" field is blank. Header has been
added at the top of the window with a green checkmark, and the text
"PGP public key successfully added."
* Click Cancel in the Import PGP Key window.
- Options screen is still there (in its original window), and nothing
has changed.
* Click <<Address Books, then PGP Options>>, to get IMP to refresh the
PGP options screen
- "Import Keypair" and "Create Keys" buttons are still present and
active, along with fields to enter data for new keypair.
* Using PHPMyAdmin, take a look at IMP's prefs in horde_prefs table.
- pgp_private_key exists for this user, but it's empty (nothing in
pref_value). pgp_public_key exists, and pref_value is set to the
keypair I pasted in.
I'd be happy to try inserting some troubleshooting code, but I'm not
sure what to add, or where to put it. Nothing (at all) is logged to
the system log when I attempt to import the key (i.e., when I click on
"Import Key"), even with the log level set to PEAR_LOG_DEBUG.
-----BEGIN PGP PRIVATE KEY BLOCK-----
Version: GnuPG v1.2.4 (MingW32)
lQHhBEEzQyoRBADwXP+CAASICMyqpQys8o02tb/MHJjpaoULHFNNCJW55LlUuKFD
J7+UxIGjSJy1KN0YB2Me0LzBUcqD+bNBwPXV6mB2kNqDirmWHInnVlm7L4x/2QG+
/nsXX4GzSShOh15p7SbvOa2CcfNV7NRVxLMf9G0qYze2z8Xzo1uKSoWSPwCgn+Df
jZ4xh/NFVgo2zHwYhPBMP6cD/jmriVxxMTNjHbVvKocOT5vqUmTQXp6QV1i5GwRy
KCAute7Ygaclab/Yy8qT0BIXUQTjfaSHTNaQxPsUBj19F77zKwqJQiRcpsKg038e
BD2V0eAafSO+/T8h2/aT08OjEZA33qT94+YsPZXB3Rt/6opRj7QXLHW5VGqcWQGq
0A8CA/48ugkEIxQTojK8AyW+LjIPYqMoCUQ1+lR52WL2kRaUwauMbPS7Cfjmwtqx
4SXBNCF5mQ50hfhoGoKWNaD4pdnL30p6TOaNfjY5FqFzxGawhunrZm7jVfxV2lIN
8BjKjiZzlXp03fkrvWB5AV4ObOdLw4k2azZXIM4brTy1A58t1v4DAwKtV88JU/Wa
EGAKGBQ+UKtm2vYmTSdubpWT8Jf6uwc6/MzRdWz/UIQtoTddsinyKQKH29zr4BJT
QYbBILQuRGFuIEJyb3duICh0ZXN0aW5nIG9ubHkpIDxkYW5AZmFtaWx5YnJvd24u
b3JnPohbBBMRAgAbBQJBM0MqBgsJCAcDAgMVAgMDFgIBAh4BAheAAAoJEDux980V
QOa0GTwAn2OyGZhUtQ5WJFAyg2VY7ZOZGVnpAJ93761rVAvYl4CFIvPRB4V0C4Fq
mZ0CIARBM0MuEAcA3QcLX1NUMpv3guOoDKldl/tyHJ7uA956ANQPa0sk1aDbJSEQ
ShPSMqbTG6SlGCV7J21TH9jl70lrqa3MqsV+6Kazryn3LR9+6rnT4+M5dUfCJ2DC
8BStWIb7hXXYTkbYcBcbZDvE2eJxg2jJm+kASt9n609fTlsYlmGhLpUqZlscifG/
w1oEIBu0Ug7cPHnAqgZOH5pzsuYbCeSdKB0ZpRLbXpokh0J/0SPNctb9iB69BUut
NrEykLY5EO/K3HX+oqtK1ZLchOOxcZhpdER6OlHONngOoKxMxVMCWdQlvc8AAwcH
AKrilSbYL74WHiGNdnTm36wyrq2f3qANS2UBZHt3f63B6hGScaOF/IXIFb/gWqO5
OKPNTa8r2ndrQUsjFxNHbSsCAP+bFma5BVuRT96x6YoYi2bqCQpDdQfRBSpxcuR4
Mi6ZJLcZ0wdLrKn5epV6JA4EUFFb0mbx7O1rhclCUYoaqLxEHkoFgbKSscCGUGaV
RFwgmbkBruwTUzS81LeMQRT+juc/3yHbAXOErZhygnszrdTl2Ef7/eLMip2Swj3a
9iJg3dEcOUzYf06Tr4j20gp8/AMT5gewIx1McuoEQo+J/gMDAq1XzwlT9ZoQYNvq
pQo5pZke2UYRvsXPThZoxkDyPmMZqWp/F//jCYAD7Cv3yjuLrWLNPNYWce+gQV+A
brG/R4wwpqP35VOYhdCNQ5RF4QmIRgQYEQIABgUCQTNDLgAKCRA7sffNFUDmtE2m
AJ9X7knr8E9YIJeJ7e+3J0U5KZy46QCglqN4RiYKxMua4oBmSgbRqFvHdH4=
=btxl
-----END PGP PRIVATE KEY BLOCK-----
working on their system or else this will not be fixed because, simply
enough, it works perfectly fine for me.
Also, make sure you are using up-to-date CVS. There is no guarantee
that an out of date or alpha version will work.
-----BEGIN PGP PUBLIC KEY BLOCK-----
Version: GnuPG v1.2.3 (GNU/Linux)
mQGiBEFKe/QRBAC8l75eyau4t74J/h8m3WA0MO4nxxugdWq5yaMDDCeBaRitg7nf
KHZygZoU7fiSp6JanPOk/wD3MN34BoMUf4BTGdoiD2w3TjKb8wTBbuksLI6g3An5
OZYBch3P0QYN6uyy0q0TUsDJDyFFVu1NAu/IKwCjazxw01glJs2u4wD1zwCgllIH
jKvL+Amo22ooDfXpvBHeK8sEAJIgPb3XyM3PpPGSeBxp6nf2gb6d3YIi/Tp2LJcF
NAmr+FNhGTYOuLWVDn0ecC35vhlOEPTn2eieFB9wo030bBRPvUleG9w7fegxsTaM
Cn1/n81+Jxskb4XF+bKWvv5HA4Fmvdke7IZI8AKhxNlRWxppSbL7fGTWp+qXxpuY
Oja/A/0UZuy+h/I0NM5lbtPe2hpxN07KT5zVKxucjiWYly273u89Sejspr/Gp2v5
IHV2PtuDjv9lJAsfmjmVa8qdhFDcs/7i5bUP4qtGmHr6xky0OLAOV2xotHgcuCGK
ECOzt3iWyhCO+SdsqwtqLdXBiBDMxL/ioDJsL2kjLp0muhRnVrQkVGVzdGluZyAo
VGVzdGluZykgPHRlc3RAZXhhbXBsZS5jb20+iFsEExECABsFAkFKe/QGCwkIBwMC
AxUCAwMWAgECHgECF4AACgkQaijTo0oNnHm9iACeNeUqw0CdjyM0VrTy+ItUibOn
2y0Anj5NSys4Asmwmg4A8XRiK2wS58DduQENBEFKe/UQBACB2EgxpAMqZW8lYiYR
F09ydDPUhWXSMd9zwXkQs25LOHHfUv0IClgLq2aGomc+CAKs92L15KWCcRus0VMJ
ujhPBAkKtF7fq4/uE8j3VCBrI9s9K5zEb4ytirx6UkPh1IoqEHLfmDBP4+8td08b
wfKcjlLi2z1VSrNuOFwt+lRGmwADBQP/aRb6EqBeEHl0KkBY+2pg0hOH9l8SCuaB
wuJ46WgArm6gdpEFR+rNl3Qc2Zn5o704F93A7QzufDmNj92075eHKxtSGqsh25A5
Y2eZXT2zPESwwgfSmDL8Dax5YEk1Je5Ct5KDqYh1RPaHQPJdX4o7TroRyZUh0JZM
NFEghXXyCz6IRgQYEQIABgUCQUp79QAKCRBqKNOjSg2cedGTAJ45+wwU4Ixr1Oxu
AQ6fh2Gr0WaaZgCcDqp2wwMWDj9AxMAot31GHWkXZ+A=
=b18f
-----END PGP PUBLIC KEY BLOCK-----
-----BEGIN PGP PRIVATE KEY BLOCK-----
Version: GnuPG v1.2.3 (GNU/Linux)
lQHhBEFKe/QRBAC8l75eyau4t74J/h8m3WA0MO4nxxugdWq5yaMDDCeBaRitg7nf
KHZygZoU7fiSp6JanPOk/wD3MN34BoMUf4BTGdoiD2w3TjKb8wTBbuksLI6g3An5
OZYBch3P0QYN6uyy0q0TUsDJDyFFVu1NAu/IKwCjazxw01glJs2u4wD1zwCgllIH
jKvL+Amo22ooDfXpvBHeK8sEAJIgPb3XyM3PpPGSeBxp6nf2gb6d3YIi/Tp2LJcF
NAmr+FNhGTYOuLWVDn0ecC35vhlOEPTn2eieFB9wo030bBRPvUleG9w7fegxsTaM
Cn1/n81+Jxskb4XF+bKWvv5HA4Fmvdke7IZI8AKhxNlRWxppSbL7fGTWp+qXxpuY
Oja/A/0UZuy+h/I0NM5lbtPe2hpxN07KT5zVKxucjiWYly273u89Sejspr/Gp2v5
IHV2PtuDjv9lJAsfmjmVa8qdhFDcs/7i5bUP4qtGmHr6xky0OLAOV2xotHgcuCGK
ECOzt3iWyhCO+SdsqwtqLdXBiBDMxL/ioDJsL2kjLp0muhRnVv4DAwLxYCP+pmp4
CWBvNv1XaaEsg9EEH5grDpmeLRqVLA+B5dM/XfnANSegk9cluReOAeQVcheSPZDS
ThNgQrQkVGVzdGluZyAoVGVzdGluZykgPHRlc3RAZXhhbXBsZS5jb20+iFsEExEC
ABsFAkFKe/QGCwkIBwMCAxUCAwMWAgECHgECF4AACgkQaijTo0oNnHm9iACfRzuf
ubks0UM1JzIoeJSBp1b2o5oAmwfWUdbrC/viCPyY2PYUW9nmXd3inQFXBEFKe/UQ
BACB2EgxpAMqZW8lYiYRF09ydDPUhWXSMd9zwXkQs25LOHHfUv0IClgLq2aGomc+
CAKs92L15KWCcRus0VMJujhPBAkKtF7fq4/uE8j3VCBrI9s9K5zEb4ytirx6UkPh
1IoqEHLfmDBP4+8td08bwfKcjlLi2z1VSrNuOFwt+lRGmwADBQP/aRb6EqBeEHl0
KkBY+2pg0hOH9l8SCuaBwuJ46WgArm6gdpEFR+rNl3Qc2Zn5o704F93A7QzufDmN
j92075eHKxtSGqsh25A5Y2eZXT2zPESwwgfSmDL8Dax5YEk1Je5Ct5KDqYh1RPaH
QPJdX4o7TroRyZUh0JZMNFEghXXyCz7+AwMC8WAj/qZqeAlg731Bq98C7Yr9IDPG
ixir2i3E25GsclA0AAbAOfLKtdQCPom6LNkyhbDuNq8JILdet5fd2yrkgxDaM3Gc
Y4hGBBgRAgAGBQJBSnv1AAoJEGoo06NKDZx50ZMAnjs2JPr02FJB5cpG4EAMcLfP
5+hcAJ42L8YZ1DVn8pCWjRFKp/7e/e21SQ==
=vFKd
-----END PGP PRIVATE KEY BLOCK-----
And attached you will find some screenshots. As you see, everything
works perfectly (take my word - when I click on view public key, I get
the public key; when I click on view private key, I get the private
key).
getting exactly the same trouble as the reporter.
Michael - perhaps you could tell us exactly what you're clicking and
when in order to import the keys separately, and successfully?
fine for me. Import the public key - it is stored in the public key
pref. Import the private key - it is stored in the private key pref.
Verified by clicking on the "View" links on the main PGP Options page
- the public key View link displays the public key; the private key
View link displays the private key.
Not sure if it is something on your end or not, but since it works
exactly as expected here I can't do anything further.
recognizes that the keys are there, it populates the pgp_private_key
pref with the private key block, and the pgp_public_key pref with the
public key block. When I try to import (via copy/paste) a key
generated on my windows machine (also using GnuPG 1.2.4), the import
window says "PGP public key successfully added" at the top. The
private key block (beginning with "BEGIN PGP PRIVATE KEY BLOCK") is
saved to the pgp_public_key pref. I generated a new key just for
testing purposes (just in case something was wrong with the old one),
and had the same results. Here's that key:
-----BEGIN PGP PRIVATE KEY BLOCK-----
Version: GnuPG v1.2.4 (MingW32)
lQHhBEEzQyoRBADwXP+CAASICMyqpQys8o02tb/MHJjpaoULHFNNCJW55LlUuKFD
J7+UxIGjSJy1KN0YB2Me0LzBUcqD+bNBwPXV6mB2kNqDirmWHInnVlm7L4x/2QG+
/nsXX4GzSShOh15p7SbvOa2CcfNV7NRVxLMf9G0qYze2z8Xzo1uKSoWSPwCgn+Df
jZ4xh/NFVgo2zHwYhPBMP6cD/jmriVxxMTNjHbVvKocOT5vqUmTQXp6QV1i5GwRy
KCAute7Ygaclab/Yy8qT0BIXUQTjfaSHTNaQxPsUBj19F77zKwqJQiRcpsKg038e
BD2V0eAafSO+/T8h2/aT08OjEZA33qT94+YsPZXB3Rt/6opRj7QXLHW5VGqcWQGq
0A8CA/48ugkEIxQTojK8AyW+LjIPYqMoCUQ1+lR52WL2kRaUwauMbPS7Cfjmwtqx
4SXBNCF5mQ50hfhoGoKWNaD4pdnL30p6TOaNfjY5FqFzxGawhunrZm7jVfxV2lIN
8BjKjiZzlXp03fkrvWB5AV4ObOdLw4k2azZXIM4brTy1A58t1v4DAwKtV88JU/Wa
EGAKGBQ+UKtm2vYmTSdubpWT8Jf6uwc6/MzRdWz/UIQtoTddsinyKQKH29zr4BJT
QYbBILQuRGFuIEJyb3duICh0ZXN0aW5nIG9ubHkpIDxkYW5AZmFtaWx5YnJvd24u
b3JnPohbBBMRAgAbBQJBM0MqBgsJCAcDAgMVAgMDFgIBAh4BAheAAAoJEDux980V
QOa0GTwAn2OyGZhUtQ5WJFAyg2VY7ZOZGVnpAJ93761rVAvYl4CFIvPRB4V0C4Fq
mZ0CIARBM0MuEAcA3QcLX1NUMpv3guOoDKldl/tyHJ7uA956ANQPa0sk1aDbJSEQ
ShPSMqbTG6SlGCV7J21TH9jl70lrqa3MqsV+6Kazryn3LR9+6rnT4+M5dUfCJ2DC
8BStWIb7hXXYTkbYcBcbZDvE2eJxg2jJm+kASt9n609fTlsYlmGhLpUqZlscifG/
w1oEIBu0Ug7cPHnAqgZOH5pzsuYbCeSdKB0ZpRLbXpokh0J/0SPNctb9iB69BUut
NrEykLY5EO/K3HX+oqtK1ZLchOOxcZhpdER6OlHONngOoKxMxVMCWdQlvc8AAwcH
AKrilSbYL74WHiGNdnTm36wyrq2f3qANS2UBZHt3f63B6hGScaOF/IXIFb/gWqO5
OKPNTa8r2ndrQUsjFxNHbSsCAP+bFma5BVuRT96x6YoYi2bqCQpDdQfRBSpxcuR4
Mi6ZJLcZ0wdLrKn5epV6JA4EUFFb0mbx7O1rhclCUYoaqLxEHkoFgbKSscCGUGaV
RFwgmbkBruwTUzS81LeMQRT+juc/3yHbAXOErZhygnszrdTl2Ef7/eLMip2Swj3a
9iJg3dEcOUzYf06Tr4j20gp8/AMT5gewIx1McuoEQo+J/gMDAq1XzwlT9ZoQYNvq
pQo5pZke2UYRvsXPThZoxkDyPmMZqWp/F//jCYAD7Cv3yjuLrWLNPNYWce+gQV+A
brG/R4wwpqP35VOYhdCNQ5RF4QmIRgQYEQIABgUCQTNDLgAKCRA7sffNFUDmtE2m
AJ9X7knr8E9YIJeJ7e+3J0U5KZy46QCglqN4RiYKxMua4oBmSgbRqFvHdH4=
=btxl
-----END PGP PRIVATE KEY BLOCK-----
that - I've committed a change that hopefully cleans this up a bit) it
seems to be working correctly. Testing for me reveals that the keys
are stored in the correct preferences and everything seems to be
working ok.
IMP is really hard for me to follow. It kind of looks like the
'import_personal_private_key' and the 'process_import_personal_key'
cases are reversed?
Taken from
keypair through IMP, the pgp_private_key and pgp_public_key prefs were
populated with, respectively, the private and public keys. When
attempting to import a key, the pgp_public_key pref contains the
pasted private key, and the pgp_private_key pref is empty.
include the fix indicated. I made sure to run install-packages.php,
and the copy of pgp.php in /usr/share/pear indicates revision 1.77.
Things still don't work.
I used the delete keys function from the IMP options, and both the
pgp_private_key and pgp_public_key prefs were dropped. I then used
"import keypair" and pasted in the PGP private key. The banner at the
top of the screen said the key was imported successfully. The
pgp_private_key and pgp_public_key prefs were re-created, but only the
pgp_public_key was populated. "Your PGP Public/Private Keys" in the
IMP prefs doesn't recognize that a key has been imported; it has the
fields for creating a new key.
http://cvs.horde.org/diff.php/framework/Crypt/Crypt/pgp.php?r1=1.76&r2=1.77&ty=u
(committed a day or 2 ago) and see if things still don't work?
that may be relevant. When the key is imported, it's saved in the
prefs table as pgp_public_key. pgp_private_key is there, but
pref_value for that row is empty. When I manually paste the key into
that field, then log out and back in to horde, the key is recognized.
However, it still won't recognize the passphrase (which may be a
different issue).
Priority ⇒ 2. Medium
Assigned to
Priority ⇒ 2. Medium
State ⇒ Unconfirmed
Queue ⇒ IMP
Type ⇒ Bug
for Linux on my server. When I try to import my existing private key from
my desktop machine into IMP (either by pasting it into the text entry field
or by browsing for the file), I get the message at the top of the import
window that importing the key succeeded. However, the key is not
imported--the PGP options screen doesn't show it there, and still gives the
fields to create a new key. Returning to the options menu and going back
to that page doesn't change anything.