| Summary | from_addr not always available for vacation.php |
| Queue | Ingo |
| Queue Version | HEAD |
| Type | Bug |
| State | Resolved |
| Priority | 1. Low |
| Owners | |
| Requester | sky (at) columbia (dot) edu |
| Created | 08/01/2005 (7297 days ago) |
| Due | |
| Updated | 08/02/2005 (7296 days ago) |
| Assigned | 08/02/2005 (7296 days ago) |
| Resolved | 08/02/2005 (7296 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | |
| Patch | No |
committed instead.
State ⇒ Feedback
instead.
State ⇒ Unconfirmed
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ from_addr not always available for vacation.php
Queue ⇒ Ingo
New Attachment: vacation.php.patch
account creation isn't done. Our instance, in particular, displays no
address by default for the user. This is fixed in the attached patch
by instead calling:
$identity->getDefaultFromAddress()
which has the disadvantage of only getting one address, but
getDefaultFromAddress will fall over to the Auth::getAuth() string if
from_addr is not available.
...and the comments in the vacation.php file suggest that the goal is
to get "at least one address," so this seems to be better.
Alternatively, it could try getAll('from_addr'), and if that returns
nothing, then call getDefaultFromAddress(). That patch would look
like:
57a58
59c60,66
< $vacation->setVacationAddresses(implode("\n",
$identity->getAll('from_addr')));
---