6.0.0-beta1
7/16/25

[#2336] Impossible/difficult to set a min value on Plots
Summary Impossible/difficult to set a min value on Plots
Queue Horde Framework Packages
Type Enhancement
State Resolved
Priority 1. Low
Owners chuck (at) horde (dot) org
Requester horde (at) addelei (dot) nu
Created 07/25/2005 (7296 days ago)
Due
Updated 08/03/2005 (7287 days ago)
Assigned 07/28/2005 (7293 days ago)
Resolved 08/03/2005 (7287 days ago)
Milestone
Patch No

History
08/03/2005 09:11:49 PM Chuck Hagenbuch Comment #6
State ⇒ Resolved
Reply to this comment
I'm not sure I like the extra parameters to draw(), but I don't have 
time to work on this myself now, so I'm committing it.
07/28/2005 01:54:12 PM Jan Schneider Assigned to Chuck Hagenbuch
State ⇒ Assigned
 
07/28/2005 12:59:57 PM horde (at) addelei (dot) nu Comment #5
New Attachment: SetMinValue_2.diff Download
Reply to this comment
These patches are updated [hope I didn't miss anything].
Please read docs/CODING_STANDARDS and update your patches. Hint:
curly braces, indentation.
07/28/2005 12:55:37 PM horde (at) addelei (dot) nu Comment #4
New Attachment: DontDrawBelowMinY_2.diff Download
Reply to this comment
Please read docs/CODING_STANDARDS and update your patches. Hint:
curly braces, indentation.
07/28/2005 12:14:37 PM Jan Schneider Comment #3
State ⇒ Feedback
Reply to this comment
Please read docs/CODING_STANDARDS and update your patches. Hint: curly 
braces, indentation.
07/25/2005 04:33:39 PM horde (at) addelei (dot) nu Comment #2
New Attachment: DontDrawWithoutRange.diff Download
Reply to this comment
Well... while at it I thought I could make a patch for avoiding 
drawing outside of the drawing region.



This patch simply ignores y-values < minY. It could be argued that the 
user should be warned that some values are ignored, this patch doesn't 
do anything like that.



In case of a line plot, the line is broken by the ignored value. If 
the dataset contains (toLowValue, OKValue, toLowValue) a single dot is 
made at the accepted value.


07/25/2005 03:57:10 PM horde (at) addelei (dot) nu Comment #1
Priority ⇒ 1. Low
Type ⇒ Enhancement
Summary ⇒ Impossible/difficult to set a min value on Plots
Queue ⇒ Horde Framework Packages
New Attachment: SetMinValue.diff Download
State ⇒ New
Reply to this comment
It seems impossible to set a minimum value on Plots, ie the Y axis 
always starts at 0. It is possible to set minY using the set() 
function or using _findRange, however these are overwritten when 
calling draw() (or display()) since draw() calls initialize() which 
re-calculate these so I can't see a way to change it persistently.



I propose an update as per the attached diff. It works by sending 
additional parameters to draw(), minY is the value to be used for the 
"bottom" of the chart, stepLabelsY is the step between the lines in 
the grid. No error checking is done, this means that some parts of the 
line can be below the chart area, this should probably be taken care 
of (deleting that part of the line?).



The attached diff is agains the Chart.php found in Horde 3.0.4. It is 
tested and it seems to work with the existing plot types.

Saved Queries