Summary | Override VFS username and password (patch) |
Queue | Ingo |
Queue Version | HEAD |
Type | Enhancement |
State | Resolved |
Priority | 1. Low |
Owners | |
Requester | maddog2k (at) maddog2k (dot) net |
Created | 07/23/2005 (7292 days ago) |
Due | |
Updated | 07/29/2005 (7286 days ago) |
Assigned | |
Resolved | 07/28/2005 (7287 days ago) |
Milestone | |
Patch | No |
function are still '$this->substVars()'. Also, you forgot to fill
['vfs_user'] and ['vfs_pass'], since those variables are used by the
VFS driver.
Perhaps it would be cleaner to not use 'vfs_user' & 'vfs_pass', but
to use 'username' and 'password'. But that's up to you :)
these values.
New Attachment: vfs-fix.patch
You broke 2 things:
You renamed function substVars to _substVars, but the calls to this
function are still '$this->substVars()'. Also, you forgot to fill
$this->_params['username'] and ['password'] with the values of
['vfs_user'] and ['vfs_pass'], since those variables are used by the
VFS driver.
Perhaps it would be cleaner to not use 'vfs_user' & 'vfs_pass', but to
use 'username' and 'password'. But that's up to you :)
I've added a fix for the 2 problems above.
State ⇒ Resolved
changes still work.
New Attachment: horde_ingo-override_vfs[2].diff
I messed up the previous patch. Here 's the final one :)
New Attachment: horde_ingo-override_vfs[1].diff
as you requested :)
Also, you were right about the broken writeData().
I missed the line when merging the patch with the 'clean' source :)
I've adjusted this in the new patch, making all the variables optional.
Hopefully you will be satisfied with this one :)
State ⇒ Accepted
i.e. commented out in backends.php.dist by default, and checked with
empty() in vfs.php.
And you break existing system with writeData() change in vfs.php. I
see where you're heading at, but this should solved more elegantly,
and most important, backward compatible.
Priority ⇒ 1. Low
Type ⇒ Enhancement
Summary ⇒ Override VFS username and password (patch)
Queue ⇒ Ingo
New Attachment: horde_ingo-override_vfs.diff
State ⇒ New
override of the username & password used for VFS.
It still defaults to '$username' and '$password' as it currently does.
I needed this because all my mail-accounts are virtual and under the
same uid+gid.