6.0.0-beta1
7/10/25

[#2240] configuration option to turn off country flags
Summary configuration option to turn off country flags
Queue IMP
Queue Version HEAD
Type Enhancement
State Rejected
Priority 2. Medium
Owners
Requester Graeme.Wood (at) ed (dot) ac (dot) uk
Created 07/08/2005 (7307 days ago)
Due
Updated 12/01/2005 (7161 days ago)
Assigned
Resolved 12/01/2005 (7161 days ago)
Milestone
Patch No

History
12/01/2005 07:16:23 PM Chuck Hagenbuch Comment #8
State ⇒ Rejected
Reply to this comment
Happy to re-open if a patch shows up, but closing for now.
10/24/2005 02:49:41 PM Jan Schneider Comment #7 Reply to this comment
differently.I could take time to download the HEAD release and I
could look at generating a new patch but then there would be no
guarantee that you would like that one either. I know you ask for
people to contribute to the effort but my experience of doing so is
that it is often a pretty thankless task.
Of course there won't be guarantee. What do you think what a thankless 
task it is most times to develop open source software? And now *you*, 
who wants a feature, is expecting *me* to fix your patch so that it 
fits into the software. *sheesh*
Do I need to open a new bug
now that you have closed this one?
I reopened it already.
10/24/2005 02:27:33 PM Graeme (dot) Wood (at) ed (dot) ac (dot) uk Comment #6 Reply to this comment
Well your comment from before led me to believe there was nothing 
about my patch that you liked and that you were going to implement it 
differently.I could take time to download the HEAD release and I could 
look at generating a new patch but then there would be no guarantee 
that you would like that one either. I know you ask for people to 
contribute to the effort but my experience of doing so is that it is 
often a pretty thankless task. Do I need to open a new bug now that 
you have closed this one?
10/24/2005 02:17:59 PM Jan Schneider Comment #5
State ⇒ Feedback
Reply to this comment
No, I actually thought you would update your patch.
10/24/2005 02:06:09 PM Graeme (dot) Wood (at) ed (dot) ac (dot) uk Comment #4 Reply to this comment
I wasn't aware that you were expecting feedback. If you reject this 
bug and aren't going to do anything to address it then I really do 
want to give the feedback that I think it is not acceptable.  I had 
assumed that you were going to address it by making the changes you 
proposed rather than using my patch.
10/24/2005 01:56:35 PM Jan Schneider Comment #3
State ⇒ Rejected
Reply to this comment
No feedback.
07/28/2005 10:51:17 AM Jan Schneider Comment #2
State ⇒ Feedback
Reply to this comment
I think it makes more sense to configure this in Horde, where the 
GeoIP database is configured too. And you should not turn the flags 
off completely, but only the gethostbyaddr() call in NLS.php.
07/08/2005 07:00:12 PM Graeme (dot) Wood (at) ed (dot) ac (dot) uk Comment #1
Priority ⇒ 2. Medium
Type ⇒ Enhancement
Summary ⇒ configuration option to turn off country flags
Queue ⇒ IMP
New Attachment: flags-imp.patch Download
State ⇒ New
Reply to this comment
I have found that having the display of country flags in message headers can

cause a significant slowdown in message display. This happens if the reverse

lookup of the originating IP address fails.  In such messages you can be

waiting for up to a minute for the message to be display e.g. all Jan

Schneider's messages ;-)



Since the flags, while pretty, don't actually perform any function, I

think it should be possible to turn these off with a configuration 
setting. This patch will implement such a setting

Saved Queries