Summary | Delete Monthly Maintenance |
Queue | IMP |
Queue Version | 4.0.3 |
Type | Bug |
State | Resolved |
Priority | 2. Medium |
Owners | slusarz (at) horde (dot) org |
Requester | francesco.allegretti (at) fameccanica (dot) com |
Created | 07/08/2005 (7321 days ago) |
Due | |
Updated | 07/12/2005 (7317 days ago) |
Assigned | 07/08/2005 (7321 days ago) |
Resolved | 07/12/2005 (7317 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
State ⇒ Resolved
be using string comparison functions when all we are doing is a simple
integer comparison. Additionally, $dir['val'] isn't assigned so
change the code to use the correct array indices instead.
Assigned to Michael Slusarz
Taken from Chuck Hagenbuch
Michael, some things in the file didn't make sense to me, so I'm
passing this off to you now. Do we really want to run the
deleteFolder() call if strnatcmp returns anything but zero? Wouldn't
we want either < 0 or > 0, but not both?
And did I do the right thing changing $val to $dir on line 41? Looks
like there was some confusion there. Anyways, please take a look and
make sure this is doing the right thing.
State ⇒ Assigned
State ⇒ Unconfirmed
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ Delete Monthly Maintenance
Queue ⇒ IMP
New Attachment: delete_attachments_monthly.php
During the monthly maintenance where it should delete every old
attachment (According to the option set in user's options), horde/imp
deletes the ENTIRE VFS directory.
it appears the error resides in the file called
/horde/imp/lib/Maintenance/Task/delete_attachments_monthly.php
The class function vfs->Deletefolder has an empty parameter
($dir['val']). Httpd log shows a warning about its undefined state.
Since it is empty it will start the deletion from the VFS root.
We solved the problem..... just watch the file in attachment... i hope
for a quick fix :)
Regards