| Summary | reading binary files under Windows |
| Queue | Horde Base |
| Queue Version | 3.0.4 |
| Type | Bug |
| State | Resolved |
| Priority | 2. Medium |
| Owners | |
| Requester | edul (at) isd (dot) dp (dot) ua |
| Created | 05/26/2005 (7467 days ago) |
| Due | |
| Updated | 05/29/2005 (7464 days ago) |
| Assigned | 05/28/2005 (7465 days ago) |
| Resolved | 05/28/2005 (7465 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | |
| Patch | No |
Revision of lib/Horde/VC/svn.php file is 1.28.4.4.
I checked the lib/Horde/VC/svn.php file and made sure you're right -
the VC_WINDOWS constant is checked in it. So it's really an issue of
SVN access only.
As for other "suspicious files", please get me right - I have no
understanding of their purpose, I just found them grepping by "popen"
pattern. I just tried to give you the key, not beeing sure they are
affected by the same bug. However it was potentially possible, that's
why I called them "suspicious". Double-checking is better than
ignoring, I hope you're agree.
Thank you for your prompt response for this ticket.
State ⇒ Resolved
you didn't specify. Fixed in CVS.
State ⇒ Feedback
and use rb if we're on windows. Please specify line numbers, version
numbers, etc.
Also, please keep tickets to a single issue. Your list of other
"suspicious files" isn't very useful, and all of them deal with
text/html - which shouldn't be binary - anyway.
State ⇒ Assigned
State ⇒ Unconfirmed
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ reading binary files under Windows
Queue ⇒ Horde Base
downloaded) when Horde is installed at Windows host.
Reason: The popen() funsion is passed the "r" argument, which assumes
text mode on Windows systems by default. The "rb" mode should be used
in order to fix this.
Affected files:
- lib/Horde/VC/cvs.php
- lib/Horde/VC/svn.php
Other suspicious files:
- lib/Horde/Crypt/pgp.php
- lib/Horde/MIME/Viewer/deb.php
- lib/Horde/MIME/Viewer/msexcel.php
- lib/Horde/MIME/Viewer/mspowerpoint.php
- lib/Horde/MIME/Viewer/rpm.php
The same problem can be with usage of fopen() function.