6.0.0-beta1
11/9/25

[#1868] Incorrect size calculation for FB (work)week view
Summary Incorrect size calculation for FB (work)week view
Queue Kronolith
Queue Version HEAD
Type Bug
State Resolved
Priority 1. Low
Owners
Requester tasin (at) fhm (dot) edu
Created 04/26/2005 (7502 days ago)
Due
Updated 04/27/2005 (7501 days ago)
Assigned
Resolved 04/27/2005 (7501 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
04/27/2005 08:20:00 AM Jan Schneider Comment #3
State ⇒ Resolved
Reply to this comment
Committed, thanks.
04/26/2005 01:07:35 PM tasin (at) fhm (dot) edu Comment #2 Reply to this comment
correction in explanation:

instead of

"... It will only calculate correctly if the range is exactly 9 hours."

it should be

"... It will only calculate correctly if the range is exactly the 
value of _startHour."


04/26/2005 12:44:42 PM tasin (at) fhm (dot) edu Comment #1
State ⇒ Unconfirmed
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Incorrect size calculation for FB (work)week view
Queue ⇒ Kronolith
New Attachment: FBView.diff Download
Reply to this comment
- Since the changement from fix time grids to variable time grids 
(i.e. implementing startHour and endHour), the size of the busy blocks 
are not calculated correctly. It will only calculate correctly if the 
range is exactly 9 hours.

- Even the calculation of the number of blocks a day will not be 
correctly, if the time range for a day isn't dividable by 3 (modulus 
!= 0).

- if endHours is set to 19:30 (i.e. 39), any view is calculated only 
for 19:00 due to the floor() call in FBView.php

- This patch makes _getBlockes() inside workview.php obsolete (and so 
the patch should also close Bug #1557 for HEAD).


Saved Queries