Tickets :: [#1667] Use bind variables in Auth SQL driver

6.0.0-beta1

11/7/25

Summary	Use bind variables in Auth SQL driver
Queue	Horde Base
Queue Version	HEAD
Type	Enhancement
State	Resolved
Priority	1. Low
Owners
Requester	selsky (at) columbia (dot) edu
Created	04/02/2005 (7524 days ago)
Due
Updated	04/04/2005 (7522 days ago)
Assigned
Resolved	04/04/2005 (7522 days ago)
Milestone
Patch	No

04/04/2005 02:50:34 AM	Chuck Hagenbuch	Comment #5 State ⇒ Resolved	Reply to this comment
Committed, thanks!

04/03/2005 08:48:28 AM	selsky (at) columbia (dot) edu	Comment #4 New Attachment: Auth.sql.php-HEAD.patch	Reply to this comment
This patch is against CVS HEAD. There's still a call to Horde_SQL::updateValues(), which doesn't use parameters. I guess I'll work on that later.

04/03/2005 08:35:18 AM	selsky (at) columbia (dot) edu	Comment #3 New Attachment: Auth.sql.php[1].patch	Reply to this comment
Sorry. This patch is actually against FRAMEWORK_3 CVS. I'll do another patch for HEAD in a bit.

04/03/2005 02:31:39 AM	Chuck Hagenbuch	Comment #2 State ⇒ Feedback	Reply to this comment
This patch doesn't apply; looks like it wasn't done against HEAD. I'll try this one against FRAMEWORK_3 after testing in HEAD, please upload a new one. Also, please make sure that you always put a space after commas in argument lists: function($var1, $var2, $var3) - not func($var1,$var2,$var3). There are probably a few other things in horde/docs/CODING_STANDARDS for you to read, but that was the most noticeable one.

04/02/2005 05:07:52 AM	selsky (at) columbia (dot) edu	Comment #1 Priority ⇒ 1. Low Type ⇒ Enhancement Summary ⇒ Use bind variables in Auth SQL driver Queue ⇒ Horde Base New Attachment: Auth.sql.php.patch State ⇒ New	Reply to this comment
Use bind variables in Auth SQL driver.