6.0.0-beta1
7/10/25

[#1060] moving rules
Summary moving rules
Queue Ingo
Queue Version 1.0
Type Enhancement
State Resolved
Priority 1. Low
Owners
Requester ivan.zilic (at) mainnetworks (dot) net
Created 01/04/2005 (7492 days ago)
Due
Updated 07/25/2005 (7290 days ago)
Assigned 01/04/2005 (7492 days ago)
Resolved 07/25/2005 (7290 days ago)
Milestone
Patch No

History
07/25/2005 03:13:08 PM Jan Schneider Comment #7
State ⇒ Resolved
Reply to this comment
Tweaked and committed, thanks.
07/25/2005 02:11:03 PM gergely (at) risko (dot) hu Comment #6 Reply to this comment
Ohh, and one note: please use RISKO Gergely <gergely@risko.hu>, 
instead of risko@risko.hu in changelog entries, so google can find it ;)



Thanks,

Gergely


07/25/2005 02:08:19 PM risko (at) risko (dot) hu Comment #5
New Attachment: ingo-move-v2.patch Download
Reply to this comment
Looks fine so far, but I have severaly comments/suggestions:

- Don't use a POST submit, but a document.location redirection.
- Use the rule_up/rule_down actions, just add an optional offset. You
can do the calculation with JavaScript.
- in ruleUp()/ruleDown() merge the while() test into the for() test.
- Move the JavaScript to a separate function in filters/header.inc.
Thanks for the feedback, here is the result.



Gergely
07/25/2005 08:07:30 AM Jan Schneider Comment #4
State ⇒ Feedback
Reply to this comment
Looks fine so far, but I have severaly comments/suggestions:



- Don't use a POST submit, but a document.location redirection.

- Use the rule_up/rule_down actions, just add an optional offset. You 
can do the calculation with JavaScript.

- in ruleUp()/ruleDown() merge the while() test into the for() test.

- Move the JavaScript to a separate function in filters/header.inc.
07/25/2005 03:13:46 AM risko (at) risko (dot) hu Comment #3
New Attachment: ingo-sort.patch Download
Reply to this comment
This has been brought up on the ingo list *many* times and, so far,
no one has submitted a patch that handles this gracefully.
I attach a proposal.



Please note, that there is debbuging output, etc., I just submit it, 
because now I have to sleep and I hope for some feedback by tomorrow ;)



Is it basically acceptable?  Where should I put "long" generated javascripts?



Thanks,

Gergely
01/04/2005 02:40:40 AM Michael Slusarz Comment #2
State ⇒ Assigned
Reply to this comment
This has been brought up on the ingo list *many* times and, so far, no 
one has submitted a patch that handles this gracefully.
01/04/2005 12:24:30 AM ivan (dot) zilic (at) mainnetworks (dot) net Comment #1
Priority ⇒ 1. Low
Type ⇒ Enhancement
Summary ⇒ moving rules
Queue ⇒ Ingo
State ⇒ New
Reply to this comment
it would great to have a position number for each rule, and be able to 
make changes in their positions using this numbers, specially when 
having lots of rules.



Best Regards,



IVAN

Saved Queries