6.0.0-alpha14
7/1/25

[#9859] Ingo does not filter
Summary Ingo does not filter
Queue Ingo
Queue Version 2.0
Type Bug
State Resolved
Priority 3. High
Owners slusarz (at) horde (dot) org
Requester andy (at) andreasmueller (dot) net
Created 04/09/2011 (5197 days ago)
Due
Updated 04/13/2011 (5193 days ago)
Assigned 04/11/2011 (5195 days ago)
Resolved 04/13/2011 (5193 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
04/13/2011 10:02:15 PM andy (at) andreasmueller (dot) net Comment #18 Reply to this comment
Take 5.
Filtering from inside Ingo now is okay.

But clicking on "apply filters" in the left menu inside of Imp does 
nothing except throwing a red popup which tells me "Class Imp-Filter 
does not exist". Horde.log gives this:

2011-04-13T23:59:16+02:00 NOTICE: HORDE [imp] PHP ERROR: Trying to get 
property of non-object [pid 12457 on line 74 of 
"/usr/share/php/www/horde/imp/lib/Ui/Mailbox.php"]

I don't know if this has to do with that error message.




04/13/2011 09:57:00 PM Michael Slusarz State ⇒ Resolved
 
04/13/2011 09:31:45 PM is (dot) wms (at) smmc (dot) org Comment #17 Reply to this comment
Thanks for all your work. This last change seems to have solved all 
the issues I was seeing (and clean horde.log)

Cheers.
Bill
04/13/2011 04:17:23 PM Michael Slusarz Comment #16 Reply to this comment
Take 5.

Apologize for the painful, long process in fixing this.  But I'm not 
really familiar with this part of the code and I do not have a way to 
really test this code at this time.  So its kind of a trial-and-error 
process.
04/13/2011 04:14:59 PM Git Commit Comment #15 Reply to this comment
Changes have been made in Git for this ticket:

Bug #9859: IMP flagMessages API call requires an array

  1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/9e1d3e7f865785e2af59bf9099993e113ad39f5f
04/13/2011 02:47:47 PM is (dot) wms (at) smmc (dot) org Comment #14 Reply to this comment
Take 4.  Try this.
Take 4 commit solved the issue of filters not applying when the IMP 
Apply Filters button was clicked. However, now I am seeing two 
different errors in horde.log when filters try to automatically apply 
when new mail arrives (and the filters don't apply). Here are the 
entries...

2011-04-13T10:31:56-04:00 WARN: HORDE [imp] PHP ERROR: Invalid 
argument supplied for foreach() [pid 735 on line 2895 of 
"/usr/share/php/Horde/Imap/Client/Socket.php"]
2011-04-13T10:31:56-04:00 ERR: HORDE [imp] Bad IMAP request: Missing 
or invalid argument to UID STORE [pid 735 on line 212 of 
"/usr/share/php/Horde/Imap/Client/Base.php"]

Also, when filters are applied or mail is checked, I am seeing a red 
popup saying 'There was an error flagging messages in the folder 
"Inbox". This folder is read-only'. I think this began with the commit 
for bug #9888. There are no additional log messages when this happens 
(just the same two shown above).

Thanks.
04/13/2011 07:40:49 AM andy (at) andreasmueller (dot) net Comment #13 Reply to this comment
Take 4.  Try this.
When opening Horde4 this morning my installation seems to be totally 
screwed up. I am getting a red popup "error in communicating with 
server" (in my german version it is another text, but should mean this).

Additionally I can't open any folder except Inbox. They are empty and 
on top there is "loading ...." but I can wait and wait and nothing 
happens.

Then I changed imp/lib/Filter.php like suggested. Filtering still 
doesn't work and all my folders are not being opened.

Horde.log gives me that:

2011-04-13T09:27:26+02:00 NOTICE: HORDE [imp] PHP ERROR: Trying to get 
property of non-object [pid 12450 on line 74 of 
"/usr/share/php/www/horde/imp/lib/Ui/Mailbox.php"]
2011-04-13T09:27:31+02:00 WARN: HORDE [imp] PHP ERROR: json_encode(): 
Invalid UTF-8 sequence in argument [pid 12451 on line 242 of 
"/usr/share/php/Horde/Serialize.php"]

In the meantime this installation isn't useable at all. How to revert 
all to at least show the content of my folders? Even if not being able 
to filter is making this useless.



04/13/2011 06:29:09 AM Michael Slusarz Comment #12 Reply to this comment
Take 4.  Try this.
04/13/2011 06:26:59 AM Git Commit Comment #11 Reply to this comment
Changes have been made in Git for this ticket:

Bug #9859: Make sure mailbox is a string value

  1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/e91b9b6acd6bd63a038a64e170a558ae58221e44
04/13/2011 02:25:42 AM is (dot) wms (at) smmc (dot) org Comment #10 Reply to this comment
Commit for Bug #9888 didn't resolve this issue. Same horde.log entry.

(Thanks for #9888 though, that solved my other issue).
Bill
04/12/2011 10:38:43 PM Michael Slusarz Comment #9 Reply to this comment
Try this.
Updated the four files, but still seeing the same issue. When 
clicking the 'Apply Filters' in the IMP side menu, filters don't 
apply (although swirly wait icon appears), and

2011-04-12T17:19:57-04:00 WARN: HORDE [imp] PHP ERROR: Illegal 
offset type in isset or empty [pid 684 on line 174 of 
"/var/www/secure/horde4/imp/lib/Indices.php"]
See Bug #9888.  Commit in that bug might fix this ticket also.

04/12/2011 09:33:07 PM is (dot) wms (at) smmc (dot) org Comment #8 Reply to this comment
Try this.
Updated the four files, but still seeing the same issue. When clicking 
the 'Apply Filters' in the IMP side menu, filters don't apply 
(although swirly wait icon appears), and

2011-04-12T17:19:57-04:00 WARN: HORDE [imp] PHP ERROR: Illegal offset 
type in isset or empty [pid 684 on line 174 of 
"/var/www/secure/horde4/imp/lib/Indices.php"]

is still appearing in the horde.log.


04/12/2011 04:47:25 PM Michael Slusarz Comment #7 Reply to this comment
Try this.
04/12/2011 04:47:12 PM Git Commit Comment #6 Reply to this comment
Changes have been made in Git for this ticket:

Bug #9859: Ingo needs to use Horde_Imap_Client_Data_Fetch

  4 files changed, 31 insertions(+), 25 deletions(-)
http://git.horde.org/horde-git/-/commit/a442178d8c783788e661ae4749f0c3d881183d1d
04/12/2011 01:39:38 PM andy (at) andreasmueller (dot) net Comment #5 Reply to this comment
Does this fix?
No, not really.

After changing line 61 in ingo/lib/Script/Imap/Live.php from:
  return 
$GLOBALS['registry']->call('mail/imapOb')->fetch($this->_params['mailbox'], 
$query, array('ids' => $indices));

to:
return 
$GLOBALS['registry']->call('mail/imapOb')->fetch($this->_params['mailbox'], 
$query, array('ids' => new Horde_Imap_Client_Ids($indices)));

the following happens:


when clicking "apply filters" inside IMP (at the sidebar) nothing 
happens but these records in horde.log and no entry in apache-logs:

2011-04-12T10:18:09+02:00 WARN: HORDE [imp] PHP ERROR: Illegal offset 
type in isset or empty [pid 31485 on line 174 of 
"/usr/share/php/www/horde/imp/lib/Indices.php"]
2011-04-12T10:18:09+02:00 WARN: HORDE [imp] PHP ERROR: Illegal offset 
type in isset or empty [pid 31485 on line 174 of 
"/usr/share/php/www/horde/imp/lib/Indices.php"]

and nothing else happens.


When openening "filter" inside Imp sidebar menu on the portal page I 
get a blank page and this entry in apache error.log:

[Tue Apr 12 10:24:29 2011] [error] [client 192.168.2.14] PHP Fatal 
error:  Cannot use object of type Horde_Imap_Client_Data_Fetch as 
array in /usr/share/php/www/horde/ingo/lib/Script/Imap.php on line 
282, referer: https://myfqdn/horde/ingo/

There is no entry in horde.log

Furthermore _all_ messages in Inbox are being moved(!!) to the folder 
which is targeted by the first filtering rule and my Inbox is pretty 
clean. Not so perfect ;).


04/12/2011 01:25:39 PM is (dot) wms (at) smmc (dot) org Comment #4 Reply to this comment
This seemed to fix filtering inside Ingo (Apply Filters) for me, but 
filters still don't apply when clicking Apply Filters in the IMP side 
menu, or when they should be automatically applied when logging in. 
The message listed below still appears in horde.log in this case:

2011-04-12T09:08:23-04:00 WARN: HORDE [imp] PHP ERROR: Illegal offset 
type in isset or empty [pid 20305 on line 174 of 
"/var/www/secure/horde4/imp/lib/Indices.php"]
04/11/2011 06:36:38 AM Michael Slusarz Comment #3
State ⇒ Feedback
Assigned to Michael Slusarz
Reply to this comment
Does this fix?
04/11/2011 06:36:16 AM Git Commit Comment #2 Reply to this comment
Changes have been made in Git for this ticket:

Bug #9859: Fix imap filtering using envelope data

  3 files changed, 6 insertions(+), 5 deletions(-)
http://git.horde.org/horde-git/-/commit/d9d603229b05371bec78f549c9550d901c78791c
04/09/2011 02:55:15 PM andy (at) andreasmueller (dot) net Comment #1
Priority ⇒ 3. High
State ⇒ Unconfirmed
Patch ⇒ No
Milestone ⇒
Summary ⇒ Ingo does not filter
Type ⇒ Bug
Queue ⇒ Ingo
Reply to this comment
I have configured Horde4 and all is running fine.

Also I have defined some rules for filtering. But if I click that 
button "Filterregeln anwenden" (apply filters) _inside_ Ingo (opened 
per portal sidebar) where I define these rules, nothing happens except 
a white page and this entry in Apache's error.log:

PHP Fatal error:  Call to a member function isEmpty() on a non-object 
in /usr/share/php/Horde/Imap/Client/Base.php on line 1884, referer: 
http:/****(my fqdn_here******/horde/ingo


When I click "Filterregeln anwenden" in left Imp-sidebar while I have 
_Imp_ open and looking at my Inbox then no Apache errorlog is 
generated but this entry in horde.log:

WARN: HORDE [imp] PHP ERROR: Illegal offset type in isset or empty 
[pid 14784 on line 174 of 
"/usr/share/php/www/horde/imp/lib/Indices.php"]



Saved Queries