Tickets :: [#9711] VFS Folder creation broken

6.0.0-beta6

4/10/26

Ticket 7572 was not found.

Summary	VFS Folder creation broken
Queue	Horde Framework Packages
Queue Version	Git master
Type	Bug
State	Resolved
Priority	3. High
Owners	slusarz (at) horde (dot) org
Requester	slusarz (at) horde (dot) org
Created	3/24/11 (5496 days ago)
Due
Updated	3/24/11 (5496 days ago)
Assigned	3/24/11 (5496 days ago)
Resolved	3/24/11 (5496 days ago)
Github Issue Link
Github Pull Request
Milestone	4
Patch	No

03/24/2011 11:28:57 PM	Michael Slusarz	Comment #7 Assigned to Michael Slusarz Summary ⇒ VFS Folder creation broken State ⇒ Resolved	Reply to this comment
This ended up being broken code in VFS' folder creation.

03/24/2011 11:27:19 PM	Git Commit	Comment #6	Reply to this comment
Changes have been made in Git for this ticket: ~~Bug #9711~~: Fix VFS SQL call This was breaking autoincrement on postgresql 2 files changed, 11 insertions(+), 9 deletions(-) http://git.horde.org/horde-git/-/commit/0e996549bd41236f76e7f9bd8aa6a936d7de703b

03/24/2011 11:27:15 PM	Git Commit	Comment #5	Reply to this comment
Changes have been made in Git for this ticket: Revert "~~Bug #9711~~: Fix creation of auto-increment columns in Postgresql" This reverts commit 395a6e1f5eaf894889892e2d1c58f5bb71a22188. Problem occurred in VFS library. Added more complete unit tests. 3 files changed, 40 insertions(+), 13 deletions(-) http://git.horde.org/horde-git/-/commit/07c40864adc4f8f8d05a95ba75321d09daef7e4c

03/24/2011 08:57:32 PM	Michael Slusarz	Comment #4 State ⇒ Feedback	Reply to this comment
This seems to fix things for me (migration works for me now and autoincrementing work). I just don't know if these are correct assumptions for primaryKey. Two further thoughts: 1. According to the 'primaryKey' implementation in the Postgresql schema class, primaryKey is expected/required to be an autoincrement column. If that is the case, we should really pick a different name (e.g. 'autoincrementKey') since non-autoincrement columns can also be primary keys. 2. 'primaryKey' (or 'autoincrementKey' or whatever) should be a defined constant.

03/24/2011 08:55:13 PM	Git Commit	Comment #3	Reply to this comment
Changes have been made in Git for this ticket: ~~Bug #9711~~: Fix creation of auto-increment columns in Postgresql 2 files changed, 12 insertions(+), 8 deletions(-) http://git.horde.org/horde-git/-/commit/395a6e1f5eaf894889892e2d1c58f5bb71a22188

03/24/2011 08:54:53 PM	Michael Slusarz	Comment #2 Taken from Horde Developers	Reply to this comment
http://lists.horde.org/archives/dev/Week-of-Mon-20110321/025993.html

03/24/2011 08:51:04 PM	Michael Slusarz	Comment #1 Priority ⇒ 3. High Type ⇒ Bug Summary ⇒ Postgresql autoincrement broken Queue ⇒ Horde Framework Packages Assigned to Horde Developers Milestone ⇒ 4 Patch ⇒ No State ⇒ Assigned	Reply to this comment
'primaryKey' virtual column broken for Postgresql - PRIMARY KEY contains a not-null constraint.