Changes have been made in Git for this ticket:

Bug #9600: Fix variable scope

  1 files changed, 4 insertions(+), 4 deletions(-)
http://git.horde.org/horde-git/-/commit/1f2728072340fcc4263c0f77bc1e7e1c9ea5ced9

The problem came with my addition of the session key check for treeob. 
  I misread the code and thought that this key was not set until after 
the first session access.  However, it is created before we even 
initialize the imaptree object the first time.  This has been fixed 
(although strangely enough, this did not affect me).

Changes have been made in Git for this ticket:

Bug #9600: Fix determination if imaptree object has been initialized

  1 files changed, 11 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/c5e1618dd1a4e2cf055d70de869c9d6fc4572f94

Definitely no.  We only want to update the tree object *IF* it has 
already been created.  We don't need to update if has not yet been 
created (virtual folders will automatically be added the first time 
the tree object is created).

I can confirm the issue, as well as the fact that this change fixes 
it. Though if this fix is correct, I don't think we even need the 
conditional to begin with. I admit I don't fully understand how we 
*don't* get infinite recursion here, but my guess is that it's because 
the IMP_Imap_Tree object is already cached by the injector even though 
IMP_Imap_Tree::init() hasn't completed, so when 
IMP_Search::setVFolders() is called, the 
IMP_Imap_Tree::updateVFolders() call succeeds?

Either way, I'll leave this for Michael to fix :)

with this commit, IMP runs indefinitely over here and never get passed 
the following call
$injector->getInstance('IMP_Imap_Tree')->updateVFolders($vfolders);


Typo ?

--  if (IMP_Factory_Imaptree::initialized()) {
++ if (!IMP_Factory_Imaptree::initialized()) {

Changes have been made in Git for this ticket:

Bug #9600: Fix disabling virtual folders

http://git.horde.org/horde-git/-/commit/23fdbbab5d1dd4529405e87c7afbf68b55d046ea

I can't disable the virtual inbox. Unchecking the virtual inbox in the 
preferences has no effect. I don't see any usage for the virtual inbox 
either.