Tickets :: [#9369] Use ckeditor preferences on signatures too

6.0.0-alpha14

7/2/25

Summary	Use ckeditor preferences on signatures too
Queue	IMP
Queue Version	Git master
Type	Enhancement
State	Resolved
Priority	1. Low
Owners	slusarz (at) horde (dot) org
Requester	rui.carneiro (at) portugalmail (dot) net
Created	11/05/2010 (5353 days ago)
Due
Updated	01/19/2011 (5278 days ago)
Assigned
Resolved	11/09/2010 (5349 days ago)
Milestone
Patch	No

01/19/2011 09:50:27 AM	rui (dot) carneiro (at) portugalmail (dot) net	Comment #8	Reply to this comment
I have spotted the issue - we should be telling ckeditor to use our configuration array which is stored in the page in a javascript variable. Fixed. Confirmed, fixed. Thanks!

01/18/2011 06:47:47 PM	Michael Slusarz	Comment #7	Reply to this comment
We should NEVER be manually entering CKEDITOR.replace() calls in .js files - this is done by IMP_Ui_Editor::.. But this is the compose-dimp.js behavior: https://github.com/horde/horde/blob/master/imp/js/compose-dimp.js#L438 This is a special case - it is needed because the HTML editor is being toggled within the page. All other uses of HTML editor should be initialized automatically by calling Horde_Editor_Ckeditor. [Show Quoted Text - 12 lines][Hide Quoted Text] Sure enough, it appears in the page output: <!--a75c305b1c0a6022--><script type="text/javascript" src="/horde/imp/js/signaturehtml.js"></script> <!--a75c305b1c0a6022--><script type="text/javascript">//<![CDATA[ Event.observe(window, "load", function() {CKEDITOR.replace("signature_html",{"scayt_autoStartup":false});});window.IMP = [...] Thats the problem. You are creating a CKEditor where the only config you have is {"scayt_autoStartup":false}. All other configurations (toolbar buttons, font-size, font-family, etc) are being ignored. I have spotted the issue - we should be telling ckeditor to use our configuration array which is stored in the page in a javascript variable. Fixed.

01/18/2011 06:47:41 PM	Git Commit	Comment #6	Reply to this comment
Changes have been made in Git for this ticket: ~~Bug #9369~~: Allow a javascript variable name to be used for ckeditor config http://git.horde.org/horde-git/-/commit/4d8a00f6ca6b844df40e9805cd1bbe383d183676

01/18/2011 10:20:45 AM	rui (dot) carneiro (at) portugalmail (dot) net	Comment #5 New Attachment: Screenshot.png	Reply to this comment
What about this isn't working? It works fine here. Pulled your code and replaced my prefs.php with the defaults (prefs.php.dists) and is not working. In order to avoid any communication problem here I just uploaded a screenshot of the problem :) We should NEVER be manually entering CKEDITOR.replace() calls in .js files - this is done by IMP_Ui_Editor::.. But this is the compose-dimp.js behavior: https://github.com/horde/horde/blob/master/imp/js/compose-dimp.js#L438 Sure enough, it appears in the page output: <!--a75c305b1c0a6022--><script type="text/javascript" src="/horde/imp/js/signaturehtml.js"></script> <!--a75c305b1c0a6022--><script type="text/javascript">//<![CDATA[ Event.observe(window, "load", function() {CKEDITOR.replace("signature_html",{"scayt_autoStartup":false});});window.IMP = [...] Thats the problem. You are creating a CKEditor where the only config you have is {"scayt_autoStartup":false}. All other configurations (toolbar buttons, font-size, font-family, etc) are being ignored. There is two aways to fix this: - As compose-dimp.js, initialize IMP_Ui_Editor without an ID and do CKEditor.replace on signaturehtml.js. - Fix IMP_Ui_Editor::init and use "$injector->getInstance('Horde_Editor')->initialize" to send the correct config to all Horde_Editor instances.

01/18/2011 05:52:43 AM	Michael Slusarz	Comment #4	Reply to this comment
This wasn't working. Submitted patch to solve the issue What about this isn't working? It works fine here. We should NEVER be manually entering CKEDITOR.replace() calls in .js files - this is done by IMP_Ui_Editor::. Sure enough, it appears in the page output: <!--a75c305b1c0a6022--><script type="text/javascript" src="/horde/imp/js/signaturehtml.js"></script> <!--a75c305b1c0a6022--><script type="text/javascript">//<![CDATA[ Event.observe(window, "load", function() {CKEDITOR.replace("signature_html",{"scayt_autoStartup":false});});window.IMP = [...]

01/17/2011 07:38:11 PM	goncalo (dot) queiros (at) portugalmail (dot) net	Comment #3 New Attachment: 0001-Use-prefs-values-for-ckeditor-on-html-signature.patch	Reply to this comment
This wasn't working. Submitted patch to solve the issue

11/09/2010 08:45:06 AM	Michael Slusarz	State ⇒ Resolved Assigned to Michael Slusarz

11/09/2010 08:44:52 AM	Git Commit	Comment #2	Reply to this comment
Changes have been made in Git for this ticket: ~~Request #9369~~: Use IMP HTML editor configuration for all Horde_Editor instances create mode 100644 imp/lib/Ui/Editor.php http://git.horde.org/diff.php/imp/compose.php?rt=horde-git&r1=82bccce8fadb4691aafcf803bee94164da573408&r2=5907d00d695bffc7821333168c33b463821c3b8d http://git.horde.org/diff.php/imp/lib/Prefs/Ui.php?rt=horde-git&r1=4f599be8fe37e6ac0926dd003b7d12dffea44074&r2=5907d00d695bffc7821333168c33b463821c3b8d http://git.horde.org/diff.php/imp/lib/Ui/Compose.php?rt=horde-git&r1=8a48c691e1aca573ea14cea1dfe16c92ed128e59&r2=5907d00d695bffc7821333168c33b463821c3b8d http://git.horde.org/co.php/imp/lib/Ui/Editor.php?rt=horde-git&r=5907d00d695bffc7821333168c33b463821c3b8d http://git.horde.org/diff.php/imp/lib/Views/Compose.php?rt=horde-git&r1=8a48c691e1aca573ea14cea1dfe16c92ed128e59&r2=5907d00d695bffc7821333168c33b463821c3b8d

11/05/2010 05:01:10 PM	rui (dot) carneiro (at) portugalmail (dot) net	Comment #1 Priority ⇒ 1. Low Type ⇒ Enhancement Summary ⇒ Use ckeditor preferences on signatures too Queue ⇒ IMP Milestone ⇒ Patch ⇒ No State ⇒ New	Reply to this comment
We should use the same preferences on compose and signatures: https://github.com/horde/horde/blob/master/framework/Editor/lib/Horde/Editor/Ckeditor.php#L30 https://github.com/horde/horde/blob/master/imp/lib/Ui/Compose.php#L155