Tickets :: [#9325] No identities in IMP anymore after removal of shared prefs

6.0.0-beta1

7/15/25

Summary	No identities in IMP anymore after removal of shared prefs
Queue	Horde Framework Packages
Queue Version	Git master
Type	Bug
State	Resolved
Priority	2. Medium
Owners	jan (at) horde (dot) org, slusarz (at) horde (dot) org
Requester	jan (at) horde (dot) org
Created	10/20/2010 (5382 days ago)
Due
Updated	01/25/2011 (5285 days ago)
Assigned	11/24/2010 (5347 days ago)
Resolved	01/25/2011 (5285 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

01/25/2011 06:34:38 AM	Michael Slusarz	Comment #17 State ⇒ Resolved	Reply to this comment
The new login tasks I added will automatically convert from the old format as long as the current DB has the same charset as the previous DB. If the DB has changed, however, the admin will have to do the conversions himself.

01/25/2011 06:32:42 AM	Git Commit	Comment #16	Reply to this comment
Changes have been made in Git for this ticket: ~~Bug #9325~~: Upgrade serialized prefs from Horde 3 create mode 100644 framework/Core/lib/Horde/Core/Prefs/Storage/Upgrade.php create mode 100644 hermes/lib/LoginTasks/SystemTask/UpgradeFromHermes1.php create mode 100644 horde/lib/LoginTasks/SystemTask/UpgradeFromHorde3.php create mode 100644 ingo/lib/LoginTasks/SystemTask/UpgradeFromIngo1.php http://git.horde.org/horde-git/-/commit/cff66908a40c3fc9ab9241a24efbd7925d54ac43

11/24/2010 08:01:45 PM	Michael Slusarz	Comment #15	Reply to this comment
That's because your identities value is stored in the backend in the old format (charset converted before serializing, instead of after). If we keep the current way of handling prefs (see out dev@lists discussion), we will need to bring this upgrade task back (and make sure it handles all prefs from H3 stored this way): http://git.horde.org/co.php/horde/lib/LoginTasks/SystemTask/UpgradeFromHorde3.php?r=88b14f559a0b15fbb17f5d41e6ae4bc50174399b

11/24/2010 01:43:03 PM	Jan Schneider	Comment #14 State ⇒ Assigned	Reply to this comment
It's back with the charset conversion changes.

11/11/2010 08:48:45 PM	Jan Schneider	Comment #13 State ⇒ Resolved	Reply to this comment
It did indeed.

11/11/2010 08:41:51 PM	Michael Slusarz	Comment #12	Reply to this comment
Did removing json encoding from Horde_Session fix this?

10/22/2010 05:22:12 PM	Michael Slusarz	Comment #11 Assigned to Jan Schneider	Reply to this comment
Still can't reproduce. FWIW, my storage backend is memcache and I am using LZF compression (possible items of note if it is an encoding issue).

10/21/2010 08:58:24 AM	Jan Schneider	Comment #10	Reply to this comment
Not fixed yet.

10/21/2010 01:24:47 AM	Git Commit	Comment #9	Reply to this comment
Changes have been made in Git for this ticket: ~~Bug #9313~~: Fix logintask confirmation Session data type might change - if it changes from array/object to scalar, remove the typehint declaration stored in the session. Possibly fixes ~~Bug #9324~~ Possibly fixes ~~Bug #9325~~ http://git.horde.org/diff.php/framework/Core/lib/Horde/Session.php?rt=horde-git&r1=0ab36983a478f9137f04e428f85ccd389e617710&r2=6d69e71624b0a9bcc47b62d64c4f0e002b64fbe0

10/20/2010 06:31:12 PM	Michael Slusarz	Comment #8	Reply to this comment
Do you have any non-ascii chars in your identities? Yes.

10/20/2010 06:06:35 PM	Jan Schneider	Comment #7	Reply to this comment
Do you have any non-ascii chars in your identities?

10/20/2010 05:58:44 PM	Michael Slusarz	Comment #6	Reply to this comment
Maybe you have a hook blowing away the value? Or a stray identities entry in imp? I can verify the identities pref is stored/retrieved in the session cache correctly.

10/20/2010 05:16:02 PM	Jan Schneider	Comment #5	Reply to this comment
I don't follow the prefs code completely yet, but the identity is there when stored in the sql storage class, but it's gone in the session storage.

10/20/2010 04:08:20 PM	Michael Slusarz	Comment #4	Reply to this comment
Don't know. Maybe changes in the new session storage code fixes this. I will push those changes now. Meant "prefs storage code".

10/20/2010 04:07:14 PM	Michael Slusarz	Comment #3	Reply to this comment
Horde_Core_Prefs Object ( ... [_scope:protected] => imp ... [_scopes:protected] => Array ( [horde] => Array ( [identities] => Array ( [m] => 0 [v] => [serialized value] [d] => a:0:{} ) ) ) ) Don't know. Maybe changes in the new session storage code fixes this. I will push those changes now.

10/20/2010 04:00:46 PM	Michael Slusarz	Comment #2 State ⇒ Feedback Priority ⇒ 2. Medium	Reply to this comment
Works perfectly for me.

10/20/2010 03:37:44 PM	Jan Schneider	Comment #1 Priority ⇒ 3. High State ⇒ Assigned Patch ⇒ No Milestone ⇒ Assigned to Michael Slusarz Summary ⇒ No identities in IMP anymore after removal of shared prefs Type ⇒ Bug Queue ⇒ Horde Framework Packages	Reply to this comment
While in IMP, $prefs->getValue('identities') returns null.