Tickets :: [#9095] Fix dimp_show_preview default value

6.0.0-beta1

7/19/25

Summary	Fix dimp_show_preview default value
Queue	IMP
Queue Version	Git master
Type	Bug
State	Resolved
Priority	2. Medium
Owners	slusarz (at) horde (dot) org
Requester	leandro.damascena (at) gmail (dot) com
Created	06/14/2010 (5514 days ago)
Due
Updated	06/29/2010 (5499 days ago)
Assigned	06/15/2010 (5513 days ago)
Resolved	06/28/2010 (5500 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

06/29/2010 03:52:15 AM	leandro (dot) damascena (at) gmail (dot) com	Comment #7	Reply to this comment
Thank you Michael.

06/28/2010 11:10:28 PM	Michael Slusarz	Comment #6 Taken from Ben Klang Summary ⇒ Fix dimp_show_preview default value State ⇒ Resolved	Reply to this comment
This is a simple fix. Boolean true is no longer a valid value for this setting - default to 'horiz' instead. LDAP rewrite sounds great, but this ticket is not the proper place for further input on that topic.

06/28/2010 11:10:20 PM	Git Commit	Comment #5	Reply to this comment
Changes have been made in Git for this ticket: ~~Bug #9095~~: Fix default value for dimp_show_preview preference http://git.horde.org/diff.php/imp/config/prefs.php.dist?rt=horde-git&r1=e0b94d1c9d08ff8a0d94ba0aa507b33c3858244a&r2=df76797cc3bf64bb3ee216994de06eecd6f8c082 http://git.horde.org/diff.php/imp/templates/dimp/javascript_defs_dimp.php?rt=horde-git&r1=6291908e487ca530962ed9df16171db3504e1345&r2=df76797cc3bf64bb3ee216994de06eecd6f8c082

06/21/2010 06:02:20 PM	leandro (dot) damascena (at) gmail (dot) com	Comment #4	Reply to this comment
I totally agree with your point of view Ben, and it will be an amazing change to ldap backend because saves more space and number of querys in LDAP Server than now.. However, I think this is a "terrible" bug on IMP (because DIMP isn't working with ldap backend just now) and needs to be fixed before to make your enhancement.

06/21/2010 03:56:40 PM	Ben Klang	Comment #3	Reply to this comment
I think the bigger problem is that, like you said, the LDAP Prefs driver saves all prefs to the backend, instead of only the ones that have been changed by the user. I can't comment on DIMP's value being boolean vs. "horiz" since I'm not terribly familiar with the use of that preference. But I would like to fix the LDAP Prefs driver to behave more like the SQL Prefs driver.

06/21/2010 01:42:43 PM	leandro (dot) damascena (at) gmail (dot) com	Comment #2 New Attachment: prefldap.diff	Reply to this comment
I've found the solution to this problem... When IMP uses database backend for preferences, IMP saves just some preferences (I think "editable preferences", locked = false) and uses prefs file to get others. However when IMP uses ldap backend for preferences, IMP saves all of them in LDAP and it creates a trouble with dimp_show_preview pref. In "imp/templates/dimp/javascript_defs_dimp.php" line 70 'preview_pref' => $GLOBALS['prefs']->getValue('dimp_show_preview') === true ? 'horiz' : $GLOBALS['prefs']->getValue('dimp_show_preview'), This never will be true because LDAP returns a string type and not a boolean type. I've made a patch, can you guys analyze and give a feedback if it is a better way to solve it?

06/15/2010 09:07:21 AM	Jan Schneider	Assigned to Ben Klang Assigned to Michael Slusarz State ⇒ Assigned

06/14/2010 04:20:47 AM	leandro (dot) damascena (at) gmail (dot) com	Comment #1 Priority ⇒ 2. Medium State ⇒ Unconfirmed Patch ⇒ No Milestone ⇒ Queue ⇒ IMP Summary ⇒ Ldap preferences Type ⇒ Bug	Reply to this comment
Using LDAP preferences IMP (Dynamic View) doesn't work so well.. First login of user works perfectly, but the second time don't work and folders, inbox and others things isn't showed. Looking at debug I can't see no errors..