Tickets :: [#8623] Image Fatal Errors

6.0.0-beta1

8/11/25

Summary	Image Fatal Errors
Queue	Ansel
Queue Version	Git master
Type	Bug
State	Resolved
Priority	1. Low
Owners	mrubinsk (at) horde (dot) org
Requester	duck (at) obala (dot) net
Created	10/01/2009 (5793 days ago)
Due
Updated	01/13/2010 (5689 days ago)
Assigned	10/01/2009 (5793 days ago)
Resolved	10/01/2009 (5793 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	Yes

01/13/2010 12:12:58 AM	CVS Commit	Comment #5	Reply to this comment
Changes have been made in Git for this ticket: More refactoring to use exceptions Fixes issue in ~~Bug: 8623~~ as well. http://git.horde.org/diff.php/ansel/faces/image.php?rt=horde-git&r1=99c513d7984eb40527d9d15be4b8f09942c0a397&r2=80f9d4a48125528b296d75e294946328314189d3 http://git.horde.org/diff.php/ansel/img/mini.php?rt=horde-git&r1=0395936f19ae533fdc096354b5b358da57ae8036&r2=80f9d4a48125528b296d75e294946328314189d3 http://git.horde.org/diff.php/ansel/img/prettythumb.php?rt=horde-git&r1=0395936f19ae533fdc096354b5b358da57ae8036&r2=80f9d4a48125528b296d75e294946328314189d3 http://git.horde.org/diff.php/ansel/img/screen.php?rt=horde-git&r1=0395936f19ae533fdc096354b5b358da57ae8036&r2=80f9d4a48125528b296d75e294946328314189d3 http://git.horde.org/diff.php/ansel/img/thumb.php?rt=horde-git&r1=0395936f19ae533fdc096354b5b358da57ae8036&r2=80f9d4a48125528b296d75e294946328314189d3 http://git.horde.org/diff.php/ansel/lib/Ansel.php?rt=horde-git&r1=2b7fa252460f887cf6de878e23b8209640999b84&r2=80f9d4a48125528b296d75e294946328314189d3 http://git.horde.org/diff.php/ansel/lib/Api.php?rt=horde-git&r1=b6b4fd5d137fb6c18ac72de35fdb99d5423ac05c&r2=80f9d4a48125528b296d75e294946328314189d3 http://git.horde.org/diff.php/ansel/lib/Faces/Base.php?rt=horde-git&r1=c99612b45a5dc835c26ad39903baea1479a2f12f&r2=80f9d4a48125528b296d75e294946328314189d3 http://git.horde.org/diff.php/ansel/lib/Image.php?rt=horde-git&r1=d9c8264a7824e4ac77a980d895e2a06af245444c&r2=80f9d4a48125528b296d75e294946328314189d3 http://git.horde.org/diff.php/ansel/lib/ImageView/plainstack.php?rt=horde-git&r1=56ff4d1f06c12b89cbea7b93bc868990e429f8e2&r2=80f9d4a48125528b296d75e294946328314189d3 http://git.horde.org/diff.php/ansel/lib/ImageView/polaroidstack.php?rt=horde-git&r1=56ff4d1f06c12b89cbea7b93bc868990e429f8e2&r2=80f9d4a48125528b296d75e294946328314189d3 http://git.horde.org/diff.php/ansel/lib/ImageView/roundedstack.php?rt=horde-git&r1=56ff4d1f06c12b89cbea7b93bc868990e429f8e2&r2=80f9d4a48125528b296d75e294946328314189d3

10/01/2009 09:32:32 PM	Michael Rubinsky	Summary ⇒ Image Fatal Errors

10/01/2009 09:26:24 PM	Michael Rubinsky	Comment #4 Summary ⇒ Image Fatal ErrorsStill State ⇒ Resolved	Reply to this comment
Still a lot to do regarding exceptions vs PEAR_Error, but this batch should fix this particular issue.

10/01/2009 09:24:25 PM	CVS Commit	Comment #3	Reply to this comment
Changes have been made in Git for this ticket: More refactoring to use exceptions Fixes issue in ~~Bug: 8623~~ as well. http://git.horde.org/diff.php/ansel/faces/image.php?rt=horde-hatchery&r1=99c513d7984eb40527d9d15be4b8f09942c0a397&r2=80f9d4a48125528b296d75e294946328314189d3 http://git.horde.org/diff.php/ansel/img/mini.php?rt=horde-hatchery&r1=0395936f19ae533fdc096354b5b358da57ae8036&r2=80f9d4a48125528b296d75e294946328314189d3 http://git.horde.org/diff.php/ansel/img/prettythumb.php?rt=horde-hatchery&r1=0395936f19ae533fdc096354b5b358da57ae8036&r2=80f9d4a48125528b296d75e294946328314189d3 http://git.horde.org/diff.php/ansel/img/screen.php?rt=horde-hatchery&r1=0395936f19ae533fdc096354b5b358da57ae8036&r2=80f9d4a48125528b296d75e294946328314189d3 http://git.horde.org/diff.php/ansel/img/thumb.php?rt=horde-hatchery&r1=0395936f19ae533fdc096354b5b358da57ae8036&r2=80f9d4a48125528b296d75e294946328314189d3 http://git.horde.org/diff.php/ansel/lib/Ansel.php?rt=horde-hatchery&r1=2b7fa252460f887cf6de878e23b8209640999b84&r2=80f9d4a48125528b296d75e294946328314189d3 http://git.horde.org/diff.php/ansel/lib/Api.php?rt=horde-hatchery&r1=b6b4fd5d137fb6c18ac72de35fdb99d5423ac05c&r2=80f9d4a48125528b296d75e294946328314189d3 http://git.horde.org/diff.php/ansel/lib/Faces/Base.php?rt=horde-hatchery&r1=c99612b45a5dc835c26ad39903baea1479a2f12f&r2=80f9d4a48125528b296d75e294946328314189d3 http://git.horde.org/diff.php/ansel/lib/Image.php?rt=horde-hatchery&r1=d9c8264a7824e4ac77a980d895e2a06af245444c&r2=80f9d4a48125528b296d75e294946328314189d3 http://git.horde.org/diff.php/ansel/lib/ImageView/plainstack.php?rt=horde-hatchery&r1=56ff4d1f06c12b89cbea7b93bc868990e429f8e2&r2=80f9d4a48125528b296d75e294946328314189d3 http://git.horde.org/diff.php/ansel/lib/ImageView/polaroidstack.php?rt=horde-hatchery&r1=56ff4d1f06c12b89cbea7b93bc868990e429f8e2&r2=80f9d4a48125528b296d75e294946328314189d3 http://git.horde.org/diff.php/ansel/lib/ImageView/roundedstack.php?rt=horde-hatchery&r1=56ff4d1f06c12b89cbea7b93bc868990e429f8e2&r2=80f9d4a48125528b296d75e294946328314189d3

10/01/2009 04:07:48 PM	Michael Rubinsky	Comment #2 State ⇒ Assigned Assigned to Michael Rubinsky	Reply to this comment
Well, I agree that it would be more appropriate to fix it at the source... so I'll ignore this patch and fix it properly. Thanks for the report.

10/01/2009 03:59:17 PM	Duck	Comment #1 Priority ⇒ 1. Low Type ⇒ Bug Summary ⇒ Image Fatal Errors Queue ⇒ Ansel Milestone ⇒ Patch ⇒ Yes New Attachment: Gallery.diff State ⇒ Unconfirmed	Reply to this comment
With new Horde_Image code, if a image on VFS is corrupted or not existing the whole page stops rendering with fatal error. The patch avoids a page crash because of a wrong gallery tile image, but it will be more appropriate catch exceptions inside Ansel::getImageUrl() to avoid fatal errors Ansel wide. So an image cannot be rendered the error image is displayed instead of crashing the page rendering.