Tickets :: [#8390] Allow compound LDAP searches as global source filters

6.0.0-beta1

8/11/25

Summary	Allow compound LDAP searches as global source filters
Queue	Turba
Queue Version	2.3.1
Type	Enhancement
State	Rejected
Priority	1. Low
Owners
Requester	michaelbibby (at) gmail (dot) com
Created	06/30/2009 (5886 days ago)
Due
Updated	07/10/2009 (5876 days ago)
Assigned
Resolved	07/10/2009 (5876 days ago)
Milestone
Patch	No

07/10/2009 03:17:56 AM	michaelbibby (at) gmail (dot) com	Comment #10	Reply to this comment
I'm happy to take a patch that improves things and doesn't break existing configs. But I still don't understand why you can't just put in your example filter as: ''&(xxx=yyy)(aaa=bbb)' This should work fine, thanks. Do NOT forget to add this in document.

07/10/2009 03:13:33 AM	Chuck Hagenbuch	Comment #9 State ⇒ Rejected	Reply to this comment
I'm happy to take a patch that improves things and doesn't break existing configs. But I still don't understand why you can't just put in your example filter as: ''&(xxx=yyy)(aaa=bbb)'

07/10/2009 03:04:51 AM	michaelbibby (at) gmail (dot) com	Comment #8	Reply to this comment
The requirement is to not break people's existing configs. And you didn't answer my question about just not putting the outer parentheses around your more complicated filter. I just post my suggestions, and you developers find out the final solution. If you want to not break exist configs, you can add one more 'if' expression, such as detect whether the ldap filter is starting with '(' or not (maybe not a good solution).

07/10/2009 02:49:20 AM	Chuck Hagenbuch	Comment #7 Summary ⇒ Allow compound LDAP searches as global source filters	Reply to this comment
The requirement is to not break people's existing configs. And you didn't answer my question about just not putting the outer parentheses around your more complicated filter.

07/10/2009 02:37:34 AM	michaelbibby (at) gmail (dot) com	Comment #6	Reply to this comment
I mean people's existing configurations of just 'xxx=abc'. Change to '(xxx=abc)'? or add one more 'if' statement?

07/10/2009 02:22:56 AM	Chuck Hagenbuch	Summary ⇒ Allow complex LDAP filters

07/10/2009 02:22:37 AM	Chuck Hagenbuch	Comment #5 Patch ⇒ No	Reply to this comment
I mean people's existing configurations of just 'xxx=abc'.

07/10/2009 02:21:40 AM	michaelbibby (at) gmail (dot) com	Comment #4	Reply to this comment
If you think the patch should be applied, how about a check that adds the parentheses if needed so that xxx=abc still works? '(xxx=abc)' works.

07/10/2009 12:12:33 AM	Chuck Hagenbuch	Comment #3 State ⇒ Feedback Priority ⇒ 1. Low	Reply to this comment
Why don't you just leave off the outer set of parentheses? If you think the patch should be applied, how about a check that adds the parentheses if needed so that xxx=abc still works?

06/30/2009 05:02:34 AM	michaelbibby (at) gmail (dot) com	Comment #2	Reply to this comment
Currently, we can only use filter 'xxx=yyy', but we can NOT use a normal ldap filter like '(&(xxx=yyy)(aaa=bbb))' or '(aaa=bbb)'.

06/30/2009 05:01:24 AM	michaelbibby (at) gmail (dot) com	Comment #1 Patch ⇒ Yes State ⇒ New New Attachment: turbo.filter.patch Milestone ⇒ Queue ⇒ Turba Summary ⇒ Filter in global ldap address book is bad (patch included) Type ⇒ Enhancement Priority ⇒ 3. High	Reply to this comment
Currently, we can only use filter 'xxx=yyy', but we can use a normal ldap filter like '(&(xxx=yyy)(aaa=bbb))' or '(aaa=bbb)', so i modify the filter, please help to review it.